All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Tamir Duberstein <tamird@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	mm-commits@vger.kernel.org, stable@vger.kernel.org,
	nathan@kernel.org, hca@linux.ibm.com, gor@linux.ibm.com,
	ansuelsmth@gmail.com, andersson@kernel.org,
	aleksander.lobakin@intel.com, agordeev@linux.ibm.com,
	arnd@arndb.de
Subject: Re: + errh-use-__always_inline-on-all-error-pointer-helpers.patch added to mm-nonmm-unstable branch
Date: Fri, 12 Jun 2026 17:11:56 +0200	[thread overview]
Message-ID: <aiwhvPaHef0pdm3-@pathway.suse.cz> (raw)
In-Reply-To: <CAJ-ks9nHkcgwdh7i8efAv=ka2rtX9o6ZnGZk5KeroCX2G_t3mg@mail.gmail.com>

On Tue 2026-06-02 09:46:33, Tamir Duberstein wrote:
> On Tue, Jun 2, 2026 at 8:41 AM Petr Mladek <pmladek@suse.com> wrote:
> >
> > Adding Tamir into Cc.
> >
> > On Tue 2026-06-02 11:36:30, Andy Shevchenko wrote:
> > > On Tue, May 26, 2026 at 11:40:59AM -0700, Andrew Morton wrote:
> > >
> > > > The patch titled
> > > >      Subject: err.h: use __always_inline on all error pointer helpers
> > > > has been added to the -mm mm-nonmm-unstable branch.  Its filename is
> > > >      errh-use-__always_inline-on-all-error-pointer-helpers.patch
> > > >
> > > > This patch will shortly appear at
> > > >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/errh-use-__always_inline-on-all-error-pointer-helpers.patch
> > >
> > > Petr, shouldn't this also fix the problem with old (buggy) GCC for xtensa
> > > (IIRC) that we encountered in some tests a couple of months ago?
> >
> > It might here there as well. Unfortunately, I could not test it easily
> > because it required some old GCC.
> >
> > I wonder if Tamir could try to revert the commit 8901ac9d2c7eb8ed
> > ("printf: Compile the kunit test with DISABLE_BRANCH_PROFILING")
> > and try this patch instead.
> 
> Yes, confirmed.
> 
> I rebuilt xtensa-linux GCC 8.5.0 and tested printf_kunit.c with the original
> randconfig and branch profiling enabled, without DISABLE_BRANCH_PROFILING.
> 
> Without Arnd's patch, the original failure reproduces:
> 
> printf_kunit.c: In function 'errptr.part.2': error: call to
> '__compiletime_assert_313' declared with attribute error: BUILD_BUG_ON failed:
> IS_ERR(PTR)
> 
> With "err.h: use __always_inline on all error pointer helpers" applied, the same
> compile succeeds.
> 
> So Arnd's patch fixes this case and commit 8901ac9d2c7e ("printf: Compile the
> kunit test with DISABLE_BRANCH_PROFILING") can be reverted once it lands.

Great. Thank you both for pointing it out and testing it!

It seems that it is not in the Linus' tree yet. I guess
that it will appear in the 7.2 merge window, ...
I set up reminder to myself.

Best Regards,
Petr

      reply	other threads:[~2026-06-12 15:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 18:40 + errh-use-__always_inline-on-all-error-pointer-helpers.patch added to mm-nonmm-unstable branch Andrew Morton
2026-06-02  8:36 ` Andy Shevchenko
2026-06-02 12:40   ` Petr Mladek
2026-06-02 13:46     ` Tamir Duberstein
2026-06-12 15:11       ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiwhvPaHef0pdm3-@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=andersson@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ansuelsmth@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tamird@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.