From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C401DF26E for ; Fri, 12 Jun 2026 15:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781279863; cv=none; b=qX5G1zMS3VqVeBpMRoYrlylRv9hkNyqDR6YUj/gLktq+CnIKqpemqH96gnxEluUq+zeKb2yBiPfJ9Jvlrrbn0wv/un0vRlj44M5Sjc9hpWpGKNAjr9Yg9RWGoTNZPWkkxvAd4FMZG3ychu9lS9FLQwxHmQg7Uu4g1+f3kksGluY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781279863; c=relaxed/simple; bh=kdNKpuLWHhykyyMC2b1g63qanr0HAN4i73ilCgwKR84=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V9MztGEuT/SxJWvZrS5JbGnq2izxGBr7tgWaIuejWHXZkql02uu46ffssuJch0EVva8J7xPjSFZlPKAYg97dCqRFq+TZV0ni+Ik4J5ZENK20vpALAJ26obVzkCtc+lLVW8yjhYQTvbuyqwrP29b2DFIxr82vVGmy0wGZ1csx6Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mWk6gWQq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mWk6gWQq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1991F00A3A; Fri, 12 Jun 2026 15:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781279862; bh=TXy50/thz4PVQL4UBlbkqNt4vAqev8Z5e9GmH/S8x4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=mWk6gWQq2JHzV+TBt3fss6o21OVMj5wMElvakO8Ef6RrL0R4clbvJ4iT0zGwqNb2J PcWLzYCkVhGZBqg1Bvna4fEPxXIKGHlCSEpys68LG5qtLzEHddPqwOk9w/NJGW29Ob XIkZhhZ3qce7LCI+yM44mwzGyNvSszlLIaCOmsMeJ8Yr346G2x5sjwP2CpQfd7RhRT znLd91Z0id2rbRF1fJJVEGzA+aELv0in2f5vs/QhXNoK9KRr0kzvgaCk3mnKdG+q8I jLlxcrxYBlq5Svf6JGzdf6Q2qHuT+e5ys+2E4sP8PDbJ26GYWZPyCIXWJm0YToLF5G ybFpaD3V37Ybg== Received: from johan by xi.lan with local (Exim 4.99.3) (envelope-from ) id 1wY4GJ-00000002OVZ-3iZp; Fri, 12 Jun 2026 17:57:39 +0200 Date: Fri, 12 Jun 2026 17:57:39 +0200 From: Johan Hovold To: Richard Weinberger , Anton Ivanov , Johannes Berg Cc: Greg Kroah-Hartman , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] um: virtio_uml: switch to dynamic root device Message-ID: References: <20260424103101.2616338-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424103101.2616338-1-johan@kernel.org> On Fri, Apr 24, 2026 at 12:31:01PM +0200, Johan Hovold wrote: > Driver core expects devices to be dynamically allocated and will, for > example, complain loudly when no release function has been provided. > > Use __root_device_register() to allocate and register the root device > instead of open coding using a static device. > > Note that root_device_register(), which also creates a link to the > module, cannot be used as the device is registered when parsing the > module parameters which happens before the module kobject has been > set up. > > Signed-off-by: Johan Hovold > --- Can this one be picked up now? Johan