From: Peter Xu <peterx@redhat.com>
To: Avihai Horon <avihaih@nvidia.com>
Cc: qemu-devel@nongnu.org, "Alex Williamson" <alex@shazbot.org>,
"Cédric Le Goater" <clg@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"David Hildenbrand" <david@kernel.org>,
"Eric Farman" <farman@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"John Snow" <jsnow@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Maor Gottlieb" <maorg@nvidia.com>
Subject: Re: [PATCH v3 13/14] vfio/migration: Check VFIO_PRECOPY_INFO_REINIT during switchover
Date: Fri, 12 Jun 2026 12:22:31 -0400 [thread overview]
Message-ID: <aiwyR0JciBcpX_hm@x1.local> (raw)
In-Reply-To: <20260609075812.32067-14-avihaih@nvidia.com>
On Tue, Jun 09, 2026 at 10:58:11AM +0300, Avihai Horon wrote:
> VFIO_REPCOPY_INFO_REINIT is checked only during precopy, before the
> switchover decision. However, the switchover decision and guest stop are
> not atomic, so a VFIO device may want to set VFIO_PRECOPY_INFO_REINIT
> and request another switchover ACK in the gap after switchover decision
> has been made but before the guest is stopped. This would be missed and
> may increase downtime.
>
> Solve this by checking if VFIO_PRECOPY_INFO_REINIT was set during that
> gap, and request a new switchover-ack in the final save_state_pending
> call. Query precopy info after vCPUs are stopped but before
> transitioning from PRE_COPY state, when its valid to call the ioctl.
>
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
This smells like a workaround of a not-proper kernel ABI.. but I assume
it's not a huge deal.
Acked-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2026-06-12 16:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 7:57 [PATCH v3 00/14] Make switchover-ack re-usable and add VFIO precopy REINIT feature Avihai Horon
2026-06-09 7:57 ` [PATCH v3 01/14] migration: Propagate errors in migration_completion_precopy() Avihai Horon
2026-06-09 12:11 ` Philippe Mathieu-Daudé
2026-06-12 16:03 ` Peter Xu
2026-06-14 9:34 ` Avihai Horon
2026-06-09 7:58 ` [PATCH v3 02/14] migration/ram: Use migration_bitmap_sync_precopy() for postcopy discard Avihai Horon
2026-06-12 15:59 ` Peter Xu
2026-06-09 7:58 ` [PATCH v3 03/14] migration: Run final save_query_pending at switchover Avihai Horon
2026-06-12 16:03 ` Peter Xu
2026-06-09 7:58 ` [PATCH v3 04/14] migration: Log the approver in qemu_loadvm_approve_switchover() Avihai Horon
2026-06-09 7:58 ` [PATCH v3 05/14] migration: Replace switchover_ack_needed SaveVMHandler Avihai Horon
2026-06-09 7:58 ` [PATCH v3 06/14] migration: Rename switchover-ack code to legacy Avihai Horon
2026-06-09 7:58 ` [PATCH v3 07/14] migration: Make switchover-ack re-usable Avihai Horon
2026-06-12 16:16 ` Peter Xu
2026-06-14 9:50 ` Avihai Horon
2026-06-15 13:34 ` Peter Xu
2026-06-15 14:35 ` Avihai Horon
2026-06-09 7:58 ` [PATCH v3 08/14] migration: Fail migration if switchover-ack is requested after switchover decision Avihai Horon
2026-06-12 16:17 ` Peter Xu
2026-06-09 7:58 ` [PATCH v3 09/14] vfio/migration: Extract VFIO_MIG_FLAG_DEV_INIT_DATA_SENT sending to helper Avihai Horon
2026-06-09 7:58 ` [PATCH v3 10/14] vfio/migration: Add Error ** parameter to vfio_migration_init() Avihai Horon
2026-06-09 12:09 ` Cédric Le Goater
2026-06-09 7:58 ` [PATCH v3 11/14] vfio/migration: Add new switchover-ack mechanism Avihai Horon
2026-06-09 7:58 ` [PATCH v3 12/14] vfio/migration: Implement VFIO_PRECOPY_INFO_REINIT feature Avihai Horon
2026-06-09 7:58 ` [PATCH v3 13/14] vfio/migration: Check VFIO_PRECOPY_INFO_REINIT during switchover Avihai Horon
2026-06-12 16:22 ` Peter Xu [this message]
2026-06-09 7:58 ` [PATCH v3 14/14] migration: Enable new switchover-ack Avihai Horon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiwyR0JciBcpX_hm@x1.local \
--to=peterx@redhat.com \
--cc=alex@shazbot.org \
--cc=armbru@redhat.com \
--cc=avihaih@nvidia.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=eblake@redhat.com \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=iii@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jsnow@redhat.com \
--cc=maorg@nvidia.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vsementsov@yandex-team.ru \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.