From: Lukas Timmermann <linux@timmermann.space>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org
Cc: stable@vger.kernel.org, Pavel Machek <pavel@kernel.org>
Subject: Re: [PATCH] leds: as3668: correct name of config option to match Makefile
Date: Fri, 12 Jun 2026 22:16:10 +0200 [thread overview]
Message-ID: <aixoF5WDjhcdn7o_@archstation> (raw)
In-Reply-To: <20260610224244.128063-1-enelsonmoore@gmail.com>
On Wed, Jun 10, 2026 at 03:42:43PM -0700, Ethan Nelson-Moore wrote:
> The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668,
> whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This
> causes the driver to never be compiled. Correct the name in the Kconfig
> file to match the Makefile. Doing the opposite would also have worked,
> but the name in the Makefile better matches the format of other
> drivers' options.
>
> Fixes: c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
> Cc: stable@vger.kernel.org # 7.0+
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/leds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index f4a0a3c8c870..5ac63cb59469 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -107,7 +107,7 @@ config LEDS_ARIEL
>
> Say Y to if your machine is a Dell Wyse 3020 thin client.
>
> -config LEDS_OSRAM_AMS_AS3668
> +config LEDS_AS3668
> tristate "LED support for Osram AMS AS3668"
> depends on LEDS_CLASS
> depends on I2C
> --
> 2.43.0
>
>
Hi Ethan,
thank you for noticing that issue.
This was already fixed here:
https://lore.kernel.org/all/177815964265.1857555.230971455145782585.b4-ty@b4/
Best regards
Lukas
prev parent reply other threads:[~2026-06-12 20:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 22:42 [PATCH] leds: as3668: correct name of config option to match Makefile Ethan Nelson-Moore
2026-06-12 20:16 ` Lukas Timmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aixoF5WDjhcdn7o_@archstation \
--to=linux@timmermann.space \
--cc=enelsonmoore@gmail.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.