From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685542D7DEA for ; Sat, 13 Jun 2026 06:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331434; cv=none; b=NFOlYkZrVqFUA74Eg6GVsmv3XHjBHOx2nA96pEkCsVg3M1OMcMkgw7Qq0S1mnkFdue3fNcM+h5GmNH7LapyLcN+F4DEhBawCcwWeM/ii0MdW7PnbJJsbpH0xdNeJsmiom3xHK8ccL3xy7PriOXw34TRvxngq2TF6/qhEYZsKyQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781331434; c=relaxed/simple; bh=IDfj46W7vKL/Gr+E9OsZVvwB3Rdme4iy8oJeC3brNdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HD1J6PLJ6lSwLuDpzNbDI7mgZu3X/kqZAcLD8/I5MDVP68kdlQLFwdRYqWq3j1Sf94PNO2B5PnLqNcnmhMWjDe0WQngQA/3AMKmQR+gOfmzi+qQ1XxFoOu8kYxqXxLiJMEwDBU4MS+8vCIsgGMqVJ8oqE7lMHIf9C5u/HXU9wWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U2UJXinF; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U2UJXinF" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-8ccedaf0b54so12243326d6.0 for ; Fri, 12 Jun 2026 23:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781331432; x=1781936232; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1p3BAGZnV1gRRVE0W3J1YkAbfp6JIr+wulrSf/UbmkE=; b=U2UJXinFNsAbob1i1iXDXylctQ80Tq0dcDOK1DohKAcZygCS/uPDhYtOMGL5PaqMvB SGiUcOgPk7gtA6w8JIFso07WNrJgORLAJFQeO1+dcx92Anvf8I5ZwwXf2r33Im+rsvBo sEQJ9akI9tTpGxYUsQynpXz6FnHhj5FALCRXOdbzYa0c0aDERKmelgo44ZkwLWATDf0w Ps3/T9dK7LNmCjmppVwRK/5FmMn1OroXEFv/1bVWU5Ea9gD++5tJGC7G25OJVbgi7adX kuqpeBL6SP8bKua3ttUBHjGmmxrtU61KqkUFNLChOvucwde2M7rWG3SWE+6fl94+mGPz bBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781331432; x=1781936232; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1p3BAGZnV1gRRVE0W3J1YkAbfp6JIr+wulrSf/UbmkE=; b=n6PDR7kYDq6w8fQqXJ6WWsHHE7Qho0jn3W+CvDr+Icbbbi9UqbUGaIpES/TJL/GbBp agXHkdHesVL8RwrRMppctcwweXnagWRwVR/TAjIGvd3biv8M+XC6hTfF+EUKyplJdsDH wGAAk2kjaCFzK/0SF/Tr78odoJpj1w4VxQXncbOv4vAvICy5dd0SmmM4Mw0Ky1C+2Z/t MJQducHVY+yyhuROiq57CuVqiRkxwdbNEn5ThZyIvkaIDFQocnT1/JLt9hO+gmkkMMlc WhmqZeHsSVi3DFf05Y2XGbMCdXJg1aqtxPazAcDJ1vD5TOlvg5m8gpfeK/EGpHRROgxA JDpQ== X-Forwarded-Encrypted: i=1; AFNElJ8U+vZmokMKhx/eezbh4Tia1wFredb21Km6x2XxbK8dk8WpAFH+9YSF92vUX7y3xZlS4NLCUHVNzOI=@lists.linux.dev X-Gm-Message-State: AOJu0YzLTUclQEQeBRX83aV++45AsJf1gfJRt3a1tcIs/oQUANYqdS4Z LycidIBGBigMPYC+zWKG1bbAIciuofqVhWHp5pLOGYTehwa82MhTutyN X-Gm-Gg: Acq92OGrtHF0PX/X0eJitrDoAIxDXIRmv3uzVJWADaacoApvzO+KaIIB67hVYurzjFn 7/YhCJwCuxzO94+VIof425pzMrmAme4UYWAKhukQbcojgJ91PZXHUy70IMJLk4d2PDRXuXgVQIm whK4O4c8qqyr9+mg/9RO2gc9+wVKQN3/yRaHYs1INL4/zOTmYauOpVklOSswL7FkzbtuNZQiTtW gb/vu4fCSu3+IzphYNvrpYh7Kqb69Vldik+yJ1ZdyJNkLBLygnQHtOIqKRavF94MRq15+Xd13pQ 6LnAeFAOjjDQpidTWfz4H8BNg8Tu0SVfYpGA1Ik/DpihXC27L9Wxg6KjW9/fD9CTVQaIjQmHbNv f6UWB8lKE0xa/hUv/A7fSPs63iVnepD30SMrBlwUt6N4zc3EpDwYtycL1bkCxO4wQjLM8lkz8uE b5EyVyRs+jfRb5UX9e X-Received: by 2002:a05:6214:d83:b0:8cc:ebc0:6ec7 with SMTP id 6a1803df08f44-8d32ebcf12bmr100315286d6.38.1781331432342; Fri, 12 Jun 2026 23:17:12 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d305134b20sm43615736d6.43.2026.06.12.23.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 23:17:11 -0700 (PDT) Date: Sat, 13 Jun 2026 09:17:04 +0300 From: Dan Carpenter To: Brock Haftner Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , outreachy@lists.linux.dev, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats Message-ID: References: <20260613014905.48458-1-brockhaftner@gmail.com> Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Jun 13, 2026 at 09:15:08AM +0300, Dan Carpenter wrote: > On Fri, Jun 12, 2026 at 06:49:05PM -0700, Brock Haftner wrote: > > The sysfs_emit() function is used to format strings that are returned > > to userspace. According to the sysfs documentation, these outputs > > should include a newline character for visual clarity. > > > > Fix the checkpatch.pl warnings by adding the missing '\n' to the > > sysfs_emit() format strings inside several functions. > > > > Signed-off-by: Brock Haftner > > Please don't do this for existing code, only for new code. There > is a risck that user space relies on the old behavior. We should delete this checkpatch warning really. It could be a sashiko rule which only applies for patches which introduce new functions or something. regards, dan carpenter