From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32B3ACDB479 for ; Thu, 25 Jun 2026 14:01:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wckdO-0002WY-3N; Thu, 25 Jun 2026 10:00:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wckdC-0002V6-0w for qemu-arm@nongnu.org; Thu, 25 Jun 2026 10:00:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wckdA-0005iR-5t for qemu-arm@nongnu.org; Thu, 25 Jun 2026 10:00:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782396035; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xgj8sOWg5qXrfRt3VJ8AXcbM6gxEdTmL/j7w4b4Ut08=; b=YIfF4uVAFDaDmzjA0AHyDT2kXSMj6J78o7SATE0Y9+4i7otxqHkIOOnZesC8Lp+hZDoQr8 +1KNkFnpoUTzGj2VL21IPaw8Daaa2RK5m+7yeDP9JHdECuk9dVQI+ZUW2dg4RCNWLpJwDr 6uVaOKGutsPluUJ787XYu3LFyrQ5p3k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-5be7XB2bOeCUPYmSPTBh6g-1; Thu, 25 Jun 2026 10:00:31 -0400 X-MC-Unique: 5be7XB2bOeCUPYmSPTBh6g-1 X-Mimecast-MFC-AGG-ID: 5be7XB2bOeCUPYmSPTBh6g_1782396029 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3E2361873136; Thu, 25 Jun 2026 14:00:29 +0000 (UTC) Received: from redhat.com (unknown [10.44.50.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3AD1E1956088; Thu, 25 Jun 2026 14:00:24 +0000 (UTC) Date: Thu, 25 Jun 2026 15:00:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Mark Cave-Ayland Cc: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: Re: [PATCH 6/7] hw/acpi/pcihp.c: convert ACPI_PCIHP_PROP_BSEL from object prop to class prop Message-ID: References: <20260622112403.928954-1-mark.caveayland@nutanix.com> <20260622112403.928954-7-mark.caveayland@nutanix.com> MIME-Version: 1.0 In-Reply-To: <20260622112403.928954-7-mark.caveayland@nutanix.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: oI-y_Fb_MLcN5UXxlTuyxXJXjCk_qtWlzCtvGJbTQ5o_1782396029 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Mon, Jun 22, 2026 at 12:22:38PM +0100, Mark Cave-Ayland wrote: > Move the ACPI_PCIHP_PROP_BSEL property to the PCIBus object and update all > callers accordingly. > > Since the existing logic checks for the existence of the ACPI_PCIHP_PROP_BSEL > property to enable the relevant ACPI changes, set the type of the underlying > variable to int32_t with a default value of -1 indicating that the property > has not been set. > > Signed-off-by: Mark Cave-Ayland > --- > include/hw/pci/pci_bus.h | 2 ++ > hw/acpi/pci-bridge.c | 9 ++++++++- > hw/acpi/pcihp.c | 32 +++++++++++++++----------------- > hw/arm/virt-acpi-build.c | 7 ++++++- > hw/i386/acpi-build.c | 7 ++++++- > hw/pci/pci.c | 32 ++++++++++++++++++++++++++++++++ > 6 files changed, 69 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|