All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vme_user: bound slave windows to DMA buffers
Date: Thu, 25 Jun 2026 14:58:14 +0300	[thread overview]
Message-ID: <aj0X1ltvBoJDEbES@stanley.mountain> (raw)
In-Reply-To: <aj0WWwiOzjLGbY5z@stanley.mountain>

On Thu, Jun 25, 2026 at 02:51:55PM +0300, Dan Carpenter wrote:
> There are two bug fixes in this patch:
> 
> 1) The driver allows you to set any value for size.
> 2) The vme_get_size() function returns zero on error but nothing
>    checks for error.
> 
> There is a third bug as well which is not addressed.
> 
> 3) The slave.vme_addr is not checked and it allows you to read/write
>    to any memory.
> 
> It sort of looks like bugs 1 and 2 only affect
> drivers/staging/vme_user/vme_fake.c.

Actually, no.  The bugs seem to affect drivers/staging/vme_user/vme_tsi148.c
but the variables are stored to registers instead of variables so it
was a little more convoluted.

regards,
dan carpenter


  reply	other threads:[~2026-06-25 11:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  9:31 [PATCH] staging: vme_user: bound slave windows to DMA buffers Yousef Alhouseen
2026-06-25  9:47 ` Greg Kroah-Hartman
2026-06-25 11:51 ` Dan Carpenter
2026-06-25 11:58   ` Dan Carpenter [this message]
2026-06-25 13:54     ` Yousef Alhouseen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aj0X1ltvBoJDEbES@stanley.mountain \
    --to=error27@gmail.com \
    --cc=alhouseenyousef@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.