From: Daniel Thompson <daniel@riscstar.com>
To: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
Cc: dianders@chromium.org, david.laight.linux@gmail.com,
jason.wessel@windriver.com, danielt@kernel.org,
kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kdb: unify CMD_BUFLEN definition into kdb_private.h
Date: Thu, 25 Jun 2026 13:52:56 +0100 [thread overview]
Message-ID: <aj0kqPL04j7-n4kK@aspen.lan> (raw)
In-Reply-To: <l6b6bomrw3bvkehlv73fyghk6loz6jpdwqk5c4nthnhl7j7kzk@4jjhfpzv5zon>
On Wed, Jun 17, 2026 at 07:58:20AM +0530, Naveen Kumar Chaudhary wrote:
> CMD_BUFLEN was defined separately in kdb_io.c (256) and kdb_main.c
> (200), causing kdb_main.c to use the wrong size when formatting the
> prompt string into kdb_prompt_str (which is 256 bytes).
>
> Move CMD_BUFLEN (256) into kdb_private.h so all users share a single
> consistent definition, and remove the local definitions from both
> files.
>
> Fixes: 5d5314d6795f ("kdb: core for kgdb back end (1 of 2)")
> Signed-off-by: Naveen Kumar Chaudhary <naveen.osdev@gmail.com>
Thanks for this patch.
Just wanted to let you know that I've applied this patch (and your others)
locally. However, since I have to update the test suite to match the
changes to CMD_BUFLEN, I'm afraid they won't make the cut for v7.2
(since the merge window is about to close)!
Daniel.
next prev parent reply other threads:[~2026-06-25 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 16:44 [PATCH] kdb: use sizeof(kdb_prompt_str) instead of mismatched CMD_BUFLEN Naveen Kumar Chaudhary
2026-06-16 20:20 ` David Laight
2026-06-16 22:06 ` Doug Anderson
2026-06-16 22:04 ` Doug Anderson
2026-06-17 2:28 ` [PATCH v2] kdb: unify CMD_BUFLEN definition into kdb_private.h Naveen Kumar Chaudhary
2026-06-17 3:00 ` Naveen Kumar Chaudhary
2026-06-17 21:16 ` Doug Anderson
2026-06-18 10:04 ` David Laight
2026-06-18 16:02 ` Doug Anderson
2026-06-18 20:56 ` David Laight
2026-06-25 12:52 ` Daniel Thompson [this message]
2026-06-17 10:43 ` [PATCH] kdb: use sizeof(kdb_prompt_str) instead of mismatched CMD_BUFLEN kernel test robot
2026-06-17 19:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj0kqPL04j7-n4kK@aspen.lan \
--to=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.osdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.