Re: drivers/edac/versalnet_edac.c:785 init_one_mc() error: buffer overflow 'priv->adec' 152 <= s32max

[Dan Carpenter <error27@gmail.com>]

On Fri, Jun 26, 2026 at 11:05:11AM +0530, Datta, Shubhrajyoti wrote:
> 
> On 6/6/2026 9:57 AM, kernel test robot wrote:
> > BCC: lkp@intel.com
> > CC: oe-kbuild-all@lists.linux.dev
> > CC: linux-kernel@vger.kernel.org
> > TO: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> > CC: "Borislav Petkov (AMD)" <bp@alien8.de>
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   8e65320d91cdc3b241d4b94855c88459b91abf66
> > commit: 62a9fc50e8d947601ea3484e732b1a65a0a54b96 EDAC/versalnet: Refactor memory controller initialization and cleanup
> > date:   3 months ago
> > :::::: branch date: 3 hours ago
> > :::::: commit date: 3 months ago
> > config: arm64-randconfig-r072-20260606 (https://download.01.org/0day-ci/archive/20260606/202606061200.j14yIFYw-lkp@intel.com/config)
> > compiler: aarch64-linux-gcc (GCC) 8.5.0
> > smatch: v0.5.0-9185-gbcc58b9c
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Fixes: 62a9fc50e8d9 ("EDAC/versalnet: Refactor memory controller initialization and cleanup")
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Reported-by: Dan Carpenter <error27@gmail.com>
> > | Closes: https://lore.kernel.org/r/202606061200.j14yIFYw-lkp@intel.com/
> > 
> > smatch warnings:
> > drivers/edac/versalnet_edac.c:785 init_one_mc() error: buffer overflow 'priv->adec' 152 <= s32max
> > 
> > vim +785 drivers/edac/versalnet_edac.c
> > 
> > 62a9fc50e8d947 Shubhrajyoti Datta 2025-11-04  774
> > 62a9fc50e8d947 Shubhrajyoti Datta 2025-11-04  775  static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i)
> 
> This is a static function called from
> 
> 865         for (i = 0; i < NUM_CONTROLLERS; i++) {
> 866                 rc = init_one_mc(priv, pdev, i);
> 867                 if (rc) {
> 
> The NUM_CONTROLLERS is 8 so the value of i at max can be 8.
> 

Yeah...

The zero day bot doesn't do cross function analysis.  It cann't
scale well enough.

These warnings are normally filtered by a human before being resent, but
since you're using lei you get the unfiltered patches that didn't go out
to the public.  As more and more people adopt lei, we should probably
stop sending unfiltered warnings to the list...

regards,
dan carpenter