Re: [PATCH] mm: fix CONFIG_STACK_GROWSUP typo in tools/testing/vma/include/dup.h

[Lorenzo Stoakes <ljs@kernel.org>]

On Wed, Jun 17, 2026 at 01:09:26PM +0200, David Hildenbrand (Arm) wrote:
> On 6/11/26 03:22, Ethan Nelson-Moore wrote:
> > Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly
> > refactored the header file include/linux/mm.h.  In that step, it introduced
> > a typo in an ifdef, referring to a non-existing config option
> > STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.
> > 
> > Commit 40a4af52e047 ("mm: fix CONFIG_STACK_GROWSUP typo in mm.h") fixed
> > this typo in the mm.h header file, but did not update the copy of the
> > code in tools/testing/vma/include/dup.h. Update this copy as well.
> > 
> > Commit message adapted from the above-referenced fix to mm.h.
> > 
> > Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> > Cc: stable@vger.kernel.org # 7.0+
> 
> This is in tools/testing/vma. Why does this require a stable tag?
> 
> What is the resulting problem (in the test!) that we even care about the Fixes: tag?

Yeah I doubt very much that stable users are running VMA userland tests on
parisc :))

> 
> If there is no user visible (test!) problem, then this is merely a cleanup, not
> a bugfix.

Yeah I think moreso this.

> 
> Change itself LGTM.
> 
> > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> > ---
> >  tools/testing/vma/include/dup.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/vma/include/dup.h b/tools/testing/vma/include/dup.h
> > index 9e0dfd3a85b0..adbc3179085d 100644
> > --- a/tools/testing/vma/include/dup.h
> > +++ b/tools/testing/vma/include/dup.h
> > @@ -243,7 +243,7 @@ enum {
> >  #define VM_NOHUGEPAGE	INIT_VM_FLAG(NOHUGEPAGE)
> >  #define VM_MERGEABLE	INIT_VM_FLAG(MERGEABLE)
> >  #define VM_STACK	INIT_VM_FLAG(STACK)
> > -#ifdef CONFIG_STACK_GROWS_UP
> > +#ifdef CONFIG_STACK_GROWSUP
> >  #define VM_STACK_EARLY	INIT_VM_FLAG(STACK_EARLY)
> >  #else
> >  #define VM_STACK_EARLY	VM_NONE
> 
> 
> -- 
> Cheers,
> 
> David

Thanks, Lorenzo