From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C3B3F076D for ; Fri, 26 Jun 2026 17:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782494952; cv=none; b=I+Qlc19g20QSB88Sb5YvSwTauyeJxkJ7KJil6R0F+GLnuuz7WsEvJEW6H6oQrHO22UC1dUfJ4OZwvPEwXty2P1PArf9ePk2zwTjX6UG2Xm28rG/MKg/diQo9Fbc8nIMXdZh0bn305pQRHreJFio5rcNIqsrOHay5/RdOA5gVoyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782494952; c=relaxed/simple; bh=bmnqIteIrsdazyLdwoN0OJVJpD3EaqY64A0zc/yqpkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A+KPhpkkiQX4ZFGj9w1tlYcyyQFwTYoQqBQXqT4SFlqoiY7cEeer4bodWJw6aGCTJY4JyyRVw9iNd6RWOG5E0yOhsL/+IlFGW/k8jqZfLcfByZbh6v1sjrraPplIt8xTUNawOYNLIWDuHYoxWBhgZrh1BPaOdQ/Ch3M6uhVIiVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HOVEp9C4; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HOVEp9C4" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7e93e0a3364so928232a34.3 for ; Fri, 26 Jun 2026 10:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782494949; x=1783099749; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S/VSPjiBxVWzwoGtJrzRhtH5hK8hWcYXUpH5mPgMo2s=; b=HOVEp9C4MoqSx8QJQrG+E4MNqNVoojsAitCvjjTmXtFks9SeYrANVfNXQY5q5AbVeh msqhqUlgJLFyKsQz5qLla0xvKAch0rlZFmNNeNyfCtQLSt4z4ey6YyKNbXNyYEKfUfxO sMnjOqFHzbcPx4djTpEgQdYYRaCMAqcoRLiNLihWZZoRv/BkmRW4FtS8yRrQVxsCOGTe 2OHNDaVwlTQ2rgsN0VAXuSJFj9oTBq28PV6qCREHrktx17n6CLoo8tf4BCJailNrbIIc 0U5jyZRzxKMM9zKWsGuEG1G6iXkOBCVswIuyIaRLzp3cY7KlxEk3JGEvKwk+/N+QIaJd cDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782494949; x=1783099749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/VSPjiBxVWzwoGtJrzRhtH5hK8hWcYXUpH5mPgMo2s=; b=C/5tik6Xf7pIEhe1Q/71Ho/mMREOsBiFzz90zG8ujfy72diBDY8UgNOrtQe21WffrZ 8ctorp0lFfQGJFlYkNvQDBAn6XtyIXsrNavu7gfKh/HgsnA3/aYbzd6RVVhWPLNKvmqB bTbv+BFm8hmphBrdh+B7VZEZstEThJwnIhRp/5es0P+fy71KUpgD8Zn//F2R2Jp9c6PN oxKSoMwGAuBU0B7IvigxJqY7O2kiStnOgddDpCET8XKb1rVEW4IeZzlAcBM2rUnomWdD 5BJJgq+yregYTjBY9WNsldlWstnosgOtNB1Z5UEM6/Xna13e0eJLlhKDeaqjnvsjEKhW mRKw== X-Forwarded-Encrypted: i=1; AFNElJ+ijNngRJFgYE7S0c3x005QvyyPLIohzuTtmUpK4PIRmFDimi5BC3t/gPHXodh8vHT6Phg7jMkHPcklqw==@vger.kernel.org X-Gm-Message-State: AOJu0YwmDtqmkZe+BGaQqk/Ma2hQyYuATY/OgoykckNMM0m+YvcEatQH Fs6lgtN4UJTuzeAq7yF8a+gijwsH3OrUqhZZbCjSW+9F1971R6L2WvIQ X-Gm-Gg: AfdE7cli05cWAITujkuw3hCHaD9C/C1D3+zTXA5K8C2t4Flb6Szt2Iq5TQYp7dQkIkE t+OTUNlZeIuIuWIj4g5NVg/nGyBJ2M49p+yBI8vx/ph3uByo/5IZ2WjfiwWi37ASUuol0mH1AW3 OVWrS1lcm6W+5j+ZE1mDrD3GhIiVLOg0xGDWZAoyV/q3amrfmnR6lFdRksgY8M0YawBKumV/aGO lJVjzW0cDd0GIOkO5ptf3+8PAnQ84RRDOJNWWDbmNIc9Ysiw63Qe3ZqsULf2WXfLH+M1WrzjZaI Qk8M6Y0YJVCikNgx5RsJ7y5xxAJazCxNVAH64Ylp5ie3oLdGaJaLvgLJqqI1ElvjETMmeXYZYPK Ljh/FAEWcFu5Qj8uP2h3WcPogswYBryUkYz2/VgDpRA2dXeLw/MXsxre6ply6aNtSOK/GVc2+kg 34OwRz X-Received: by 2002:a05:6830:8291:b0:7e6:ed97:ce5a with SMTP id 46e09a7af769-7e99c2ec47cmr6930978a34.4.1782494948915; Fri, 26 Jun 2026 10:29:08 -0700 (PDT) Received: from localhost ([74.80.182.98]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9aa78751fsm2063757a34.13.2026.06.26.10.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 10:29:08 -0700 (PDT) Date: Fri, 26 Jun 2026 20:29:01 +0300 From: Dan Carpenter To: Doruk Tan Ozturk Cc: Neil Armstrong , Greg Kroah-Hartman , Mauro Carvalho Chehab , Hans Verkuil , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: meson: vdec: fix use-after-free of prev_frame in codec_vp9_rm_noshow_frame() Message-ID: References: <20260626164025.52694-1-doruk@0sec.ai> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260626164025.52694-1-doruk@0sec.ai> On Fri, Jun 26, 2026 at 06:40:25PM +0200, Doruk Tan Ozturk wrote: > codec_vp9_rm_noshow_frame() frees the first non-shown reference frame on > ref_frames_list without excluding vp9->prev_frame. When the previously > decoded frame was a non-show (alt-ref) frame and the current frame is a > non-show inter frame, the freed object is the one vp9->prev_frame still > points to; codec_vp9_set_mpred_mv() then dereferences the stale pointer > (use_prev_frame_mvs and codec_vp9_get_frame_mv_paddr()), a use-after-free. > > The sibling cleanup codec_vp9_show_frame() already guards this pointer > (tmp == vp9->prev_frame); rm_noshow_frame() simply omits the same check. > Add it. > > The fields that drive this path (show_frame, frame_type, intra_only) are > parsed from the VP9 bitstream, so a crafted stream fed to the stateless > decoder can trigger the free-then-use. > > Found by static analysis; not yet runtime-reproduced (Amlogic Meson > hardware required). > > Found by 0sec's autonomous vulnerability analysis (https://0sec.ai). > > Signed-off-by: Doruk Tan Ozturk > --- > drivers/staging/media/meson/vdec/codec_vp9.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/staging/media/meson/vdec/codec_vp9.c b/drivers/staging/media/meson/vdec/codec_vp9.c > index 8e80ecf84..572f418c9 100644 > --- a/drivers/staging/media/meson/vdec/codec_vp9.c > +++ b/drivers/staging/media/meson/vdec/codec_vp9.c > @@ -1247,6 +1247,15 @@ static void codec_vp9_rm_noshow_frame(struct amvdec_session *sess) > if (tmp->show) > continue; > > + /* > + * prev_frame is still referenced by the MV predictor in > + * codec_vp9_set_mpred_mv(); the sibling codec_vp9_show_frame() > + * already excludes it before freeing. Do the same here to avoid > + * a use-after-free of vp9->prev_frame. > + */ > + if (tmp == vp9->prev_frame) > + continue; I have not looked at this code before so I'm speaking from a position of ignorance but codec_vp9_show_frame() checks vp9->cur_frame as well. Shouldn't we check that here as well? regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0582CC43458 for ; Fri, 26 Jun 2026 17:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1RFU7HSkOAUhhKxyZH3MM6aPmx46/X+C7pv82whBZ2c=; b=40ToHI7YAAplrZ kEilRCv0FgX6isahGlUbMUoIRxvsCX65pOCnRQDIC7R0JiNET1KP6RvJCN+6pnYtMYNHfaU1b+Wl4 uEmH1dkcJ9PfakHDN4od++7Ijv4SFpMKdypq67JM5xDCfWXMjtyQctFC0eLhmdM2/TpggY0MScdkY mqAmCfeK1N7cCrjHD9R54M6InXsKhil8cBNu7/0x7nxb2CKDSTP8DzUuOxLoUsHez3tNLcpzLubZf j0G/1jsCSUtBwo9JhIhAzCRJlv1vZ4PWaXFd2HZOhAO0ox2MWLfrfuA5SKKxKjZhewaTQOjlsDpQa 85sECDE79WHyjRQpQcZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdAMb-0000000BhUA-1jaP; Fri, 26 Jun 2026 17:29:13 +0000 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdAMY-0000000BhTR-2Rk3 for linux-amlogic@lists.infradead.org; Fri, 26 Jun 2026 17:29:12 +0000 Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-7e93a984f79so878632a34.1 for ; Fri, 26 Jun 2026 10:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782494949; x=1783099749; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S/VSPjiBxVWzwoGtJrzRhtH5hK8hWcYXUpH5mPgMo2s=; b=Piz0V7OSUlEZJ6i1UN983vDF4MMa/LdpYdYWgW1J4FxTFboVcvXFFto1JpIk2ZNf11 fwRfcbqdJD81rT3R+bYKvj6ewoOyOumH8Vk7sXvkkFT0ARAfGXDZThu44XLIhYrZ5V5W cyjILQPkk/XV/LuHq16NwYE4fZAMy/mFLjSrRcIwmzcnAHdWgs/r6fDre0tMFo+Lmzuf 3M0GOYJ9BJbGy0gEM5yiHX3obb4kxxDOjESnNQ31Pcu4wCfZFbrh+6p1iOZE9XE7oXCb aEkoKg+7QifHf3HNJoCCq+cWA/rwT7dVIJmn12KR2N0sv6DFPx2hLNG5gYxRiG07fB05 kKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782494949; x=1783099749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/VSPjiBxVWzwoGtJrzRhtH5hK8hWcYXUpH5mPgMo2s=; b=FaOr34pVUYaw1kOtUw664ewr4FacQ8B4+IUo2G93uxbvsRuzX8tMYon/3KP7MON20E lHPsdMzE46J6DA5IekHWO8mHt6mJd8Pea0mUH4xHg+BLfBIi2ehg6U6PPjmgu+Buq5aE pRAIvB0TuUD9bFlRZDnmqrjO3n+Hc3k8BouJwaUEVJFaqAFl6ENpz550VGG4AvRUKVXz OnTRo6LhNHemkbYu8DfU8NSIkCReP+sMrUpn2kMGyed3aWbVr2xdN2954OChAVStg6cH 6ImJBMWvvaVnv0nULpUy1ANiMfP9GBx3GNPKNlcmRD+7DtztM/Av25UDuidmyacfNvGd 52Aw== X-Forwarded-Encrypted: i=1; AFNElJ8jUcQb/Uh9fwDfM8VuUg9we3pAC1j+E7aRps48xoCFciNk2bdSdIaUsZ79ReVpbuEIX2pIe6RFuGOg+ABK@lists.infradead.org X-Gm-Message-State: AOJu0Yx/zLav3DuFZckSBe/+3h2xoYq4hFe/8+AHG9zX7ccyxedjj270 d/KlFVX17pP/t+zggY09YIiIuxEuo4q9vcs3ASa0OH4DaOEakTw0+T6k X-Gm-Gg: AfdE7cmwc+J8Penm+dBCihyLRphZG80b0M4wQbmKsW2dg+PV/olQ/RU93KVWsyide/c tT07OTJHtMb1v1Dk7yKwhKkgbnjHIoJNmoZeJ5xUnQlBUWAjGuY383nvzclUTnx/3xA93pcyO/9 ONfWml8baGwc+YjLXsaoKhBE1OJSW9Kif9pYhkAea5D5ldR2CDOX4lt5L+x/C1DftSWc78K4TNA cuLG0GFrw8EfyrdtA9pM98bAHc/s3B96QeX/c+RCXpXWH0bbW3E0l894k+DimTZV6QVtY3RKIZB WrCQbCD+ItU5szyiRMmzB3eV+hNJ242K9kMrXNrYHd8lgly9w5I5/MLaTOXAFip3/MAxh8UEq0D 2RdL4/smVpqCryKYywJCQHXwSrc7liHPh2N7iU0X+YlDjpDRpZwLfD4AIcxXS210fFeLLBm+z9u ZYIHTX X-Received: by 2002:a05:6830:8291:b0:7e6:ed97:ce5a with SMTP id 46e09a7af769-7e99c2ec47cmr6930978a34.4.1782494948915; Fri, 26 Jun 2026 10:29:08 -0700 (PDT) Received: from localhost ([74.80.182.98]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9aa78751fsm2063757a34.13.2026.06.26.10.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 10:29:08 -0700 (PDT) Date: Fri, 26 Jun 2026 20:29:01 +0300 From: Dan Carpenter To: Doruk Tan Ozturk Cc: Neil Armstrong , Greg Kroah-Hartman , Mauro Carvalho Chehab , Hans Verkuil , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: meson: vdec: fix use-after-free of prev_frame in codec_vp9_rm_noshow_frame() Message-ID: References: <20260626164025.52694-1-doruk@0sec.ai> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260626164025.52694-1-doruk@0sec.ai> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260626_102910_632318_8EC19EF2 X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2026 at 06:40:25PM +0200, Doruk Tan Ozturk wrote: > codec_vp9_rm_noshow_frame() frees the first non-shown reference frame on > ref_frames_list without excluding vp9->prev_frame. When the previously > decoded frame was a non-show (alt-ref) frame and the current frame is a > non-show inter frame, the freed object is the one vp9->prev_frame still > points to; codec_vp9_set_mpred_mv() then dereferences the stale pointer > (use_prev_frame_mvs and codec_vp9_get_frame_mv_paddr()), a use-after-free. > > The sibling cleanup codec_vp9_show_frame() already guards this pointer > (tmp == vp9->prev_frame); rm_noshow_frame() simply omits the same check. > Add it. > > The fields that drive this path (show_frame, frame_type, intra_only) are > parsed from the VP9 bitstream, so a crafted stream fed to the stateless > decoder can trigger the free-then-use. > > Found by static analysis; not yet runtime-reproduced (Amlogic Meson > hardware required). > > Found by 0sec's autonomous vulnerability analysis (https://0sec.ai). > > Signed-off-by: Doruk Tan Ozturk > --- > drivers/staging/media/meson/vdec/codec_vp9.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/staging/media/meson/vdec/codec_vp9.c b/drivers/staging/media/meson/vdec/codec_vp9.c > index 8e80ecf84..572f418c9 100644 > --- a/drivers/staging/media/meson/vdec/codec_vp9.c > +++ b/drivers/staging/media/meson/vdec/codec_vp9.c > @@ -1247,6 +1247,15 @@ static void codec_vp9_rm_noshow_frame(struct amvdec_session *sess) > if (tmp->show) > continue; > > + /* > + * prev_frame is still referenced by the MV predictor in > + * codec_vp9_set_mpred_mv(); the sibling codec_vp9_show_frame() > + * already excludes it before freeing. Do the same here to avoid > + * a use-after-free of vp9->prev_frame. > + */ > + if (tmp == vp9->prev_frame) > + continue; I have not looked at this code before so I'm speaking from a position of ignorance but codec_vp9_show_frame() checks vp9->cur_frame as well. Shouldn't we check that here as well? regards, dan carpenter _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic