From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFFC63FBB79 for ; Mon, 15 Jun 2026 14:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533367; cv=none; b=OscsHezT7JSTA8L7RLfl4hhoKSp1aeyFOUfcoH+Evrwxq5xOI9dq3zDO8VaElNq+JV7nZfQN7hNZWJ4yP6CY4WV8qDp9hcvnjwOTOadkFaRAmnjQ9PCjgeDcu9wPvXwQ04qjpWljN+8B0ROLpJs2kfJWMaCEho68zkMQqbH+AEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533367; c=relaxed/simple; bh=ZQn8hPrkM36VCBIdCi3eFgK8VPUUP8gn25zK7fcuS7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1TZPlLfTDhlCOH2iefF+JWw9EjmOuuX+djSro8cVDa2O66f6rIH2pcEux29t4gkpLH3rtbOE2uk6BXg6LiFTrRfGRoNEO5C+yD3Ac6s1BRuQlsaXJHh2LcmxURHuYvcGl38tY9XiRP8lJtt6mAhRuYagL+fcjQMpZAEDl9kFXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PHy1hDd9; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kyk5KUQP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PHy1hDd9"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kyk5KUQP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781533363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zuMhQAEiwW8EZyF1+ggYbLN42TmxHM1hwGejQcOObs=; b=PHy1hDd9hnr0l5rMkejst0Pk1ZzCyMPErTf6dOtBVhuuit0fohZhNV9jJHocH3yso7zB6o UyeFwszIPW7wi4m+OzzqTkTRSER5aJ0qRQqMVuZILG5159upvN+xEidKENj6XXb1u8X61G eM5NtAIP8RRFHTMSHa3TpiUS1J5dnso= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-iCx-ICdxPauM6qRMWnbs_Q-1; Mon, 15 Jun 2026 10:22:42 -0400 X-MC-Unique: iCx-ICdxPauM6qRMWnbs_Q-1 X-Mimecast-MFC-AGG-ID: iCx-ICdxPauM6qRMWnbs_Q_1781533361 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915f7c37734so758595285a.1 for ; Mon, 15 Jun 2026 07:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781533361; x=1782138161; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3zuMhQAEiwW8EZyF1+ggYbLN42TmxHM1hwGejQcOObs=; b=kyk5KUQPY6IiQqZqKBxJpnYeLi+ufrcDYW01yXtg0oVYtHKe/78MdlnaHhlDLeV+vr AuGKAYKwGF0K6KQ95Jy22FMAwxzHu1YGZUChseL7c+z+6eUuHZtz+NKeClqnxING6tMz LVrIOBEqZmKh0qm27iVgplLFx895CjspBGoD+EQZ2fZcTDqwjijRWeTDi+UKPG3iW/xL aq5iLE7V7GoKoFX75aqJiwhGLWOgej1vuBdUjIzfxlek37xhNLaCW5+ahhklvo+m+dJ2 dMkreoclrGwnk2zn80pkYfszv7X3OCXipJEJDdY7hMQaP7nDN+7Cjy+k6t04CyX4x5D1 pKGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533361; x=1782138161; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3zuMhQAEiwW8EZyF1+ggYbLN42TmxHM1hwGejQcOObs=; b=qHF7veacwYj+y5Ibhp0kFX7tBFS7nMAV7LVBLNOv7TXcLXnKXxSpFfYUENH3OQCc25 UNGkViPUb1PyNRMMOZ5sD5w3LkvKuucc/ysQ9viggHGWaTeiZWV3RqjFays0SyXhIZKn 0Yg11Y9bVCS5JJAkSfKwzON6brmKaBEjEvIwoQ24z8uB50PXKDn7mDTILyrbpifhTH8h MoNY2HMZxWBFm1LtyJAwYQ9fFMbBQDhPm29YRK2jcof8txrv7JsQ37SwyeXcN6f8L44B FzGr96U4kg/o87LAVfK737DC95vnDWB0uDdvBbiZf7khxkj3OUWqLVHO9WVduvgc9Nia R6Tw== X-Forwarded-Encrypted: i=1; AFNElJ8rOAzPTy2ylUdbau3/S5y2GyjKsLn0a7ajE9TsKfCIO3DM+7IxZ7IbBUzR5hEkko3pWtgyT6P7AZ98zQ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2JbqiNMoAGD+HU0nBP+2e7+x5daPrE5y7ZPqfBUlllg9gJyQS 0x1y6u3C/mGHsIAucK8vrh1eCQDcap+I6a8UqpHvYhvGCQS0ukYmsEUL56hQLc9Vy4lVJEPdHWb cRHFNT3kHtHOd7NuPz7ifxISSzPg0uEY3qxkUqtdYPcCmgzZBv4Z20HQDaG0Aa9Ulhvm4hSj2XQ == X-Gm-Gg: Acq92OHlQaLUlinLRuKFnVzh+JTkLtCSY1VCDWc0lxTYTFzZQ++7a3jQ/lbLMx+klg/ f38s3cw3M05XoY86purn6gqRHr55AbEp6whzqIUBo0RSJOkZIIKH2YNGNNpKKjUXQz/Q1AI7UlD 5IiAY/9KruQ3qbWpFXb7OgaeXKz9cS1kA1zPyD0kla1EUucQN2277J7KnB5yeO+vS9tvdjxAY2c TAb1E/ep3Sqd9+2hQafREEsjXVhhOiWFJp4tBBqmdfYo9SewDbV41qppVcmas6TGE7tIa71aDNK a+VS2IquwWg7pFRH4QNCC/duh3LrjuUEherqkf++Rg7J0MLm/iH+ZOwkJez9lwftyWugyItEs+u XtMadQIH+gn20S8FauhGBteTM5i1P/t85lpRgfDSZnRNVFp0qoEcbRBnW X-Received: by 2002:a05:620a:8906:b0:915:8c48:4975 with SMTP id af79cd13be357-9161bc8d76dmr2160614885a.34.1781533361189; Mon, 15 Jun 2026 07:22:41 -0700 (PDT) X-Received: by 2002:a05:620a:8906:b0:915:8c48:4975 with SMTP id af79cd13be357-9161bc8d76dmr2160609685a.34.1781533360658; Mon, 15 Jun 2026 07:22:40 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a006ef0sm1087098485a.24.2026.06.15.07.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 07:22:39 -0700 (PDT) Date: Mon, 15 Jun 2026 10:22:37 -0400 From: Brian Masney To: Jens Glathe Cc: Saravana Kannan , Abel Vesa , Maxime Ripard , Michael Turquette , Stephen Boyd , Russell King , Bjorn Andersson , Hans de Goede , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/4] clk: qcom: convert from icc_sync_state() to qcom_cc_sync_state() Message-ID: References: <20260603-clk-sync-state-v1-0-457120eed200@redhat.com> <20260603-clk-sync-state-v1-3-457120eed200@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) Hi Jens, On Sat, Jun 06, 2026 at 08:25:45AM +0200, Jens Glathe wrote: > On 03.06.26 16:21, Brian Masney wrote: > > Convert all of the qcom clk drivers from icc_sync_state() to > > qcom_cc_sync_state(). > > > > Signed-off-by: Brian Masney > > --- > [...] > > diff --git a/drivers/clk/qcom/clk-cbf-8996.c b/drivers/clk/qcom/clk-cbf-8996.c > > index 0b40ed601f9a..0d920bd5a992 100644 > > --- a/drivers/clk/qcom/clk-cbf-8996.c > > +++ b/drivers/clk/qcom/clk-cbf-8996.c > > @@ -6,7 +6,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > @@ -249,7 +248,7 @@ static void qcom_msm8996_cbf_icc_remove(struct platform_device *pdev) > > > Hi Brian, thank you for the patch set. To successfully build there seems to > be a header missing. I tested this in my tree on Thinkbook 16 G7 QOY and > Ideapad Slim3x 15Q8X10 without adverse effects, looking good. > > jglathe@tb16-jg:~$ sudo dmesg|grep "unused clocks" > [    0.492547] clk: Disabling unused clocks not associated with a device > [    1.178818] clk-rpmh 17500000.rsc:clock-controller: clk: Disabling unused > clocks > [    1.314479] qcom-edp-phy aec5a00.phy: clk: Disabling unused clocks > [    1.327608] tcsrcc-x1e80100 1fc0000.clock-controller: clk: Disabling > unused clocks > [    1.544869] qcom-qmp-combo-phy fdf000.phy: clk: Disabling unused clocks > [    1.614767] qcom-qmp-usb-phy 88e5000.phy: clk: Disabling unused clocks > [    1.616222] qcom-qmp-usb-phy 88e3000.phy: clk: Disabling unused clocks > [    1.690273] qcom-qmp-combo-phy fd5000.phy: clk: Disabling unused clocks > [    1.726354] qcom-qmp-pcie-phy 1bfc000.phy: clk: Disabling unused clocks > [   10.956342] qcom-qmp-pcie-phy 1c0e000.phy: clk: Disabling unused clocks > [   15.858926] q6prm-lpass-clock > 6800000.remoteproc:glink-edge:gpr:service@2:clock-controller: clk: Disabling > unused clocks > [   15.867120] rx_macro 6ac0000.codec: clk: Disabling unused clocks > [   15.867990] wsa_macro 6aa0000.codec: clk: Disabling unused clocks > [   15.868589] va_macro 6d44000.codec: clk: Disabling unused clocks > [   15.970465] wsa_macro 6b00000.codec: clk: Disabling unused clocks > [   15.973614] tx_macro 6ae0000.codec: clk: Disabling unused clocks > > Tested-by: Jens Glathe Thanks for testing. I'm going to put the Tested-by on patch 4 that actually adds the sync_state support when I post the new version unless I hear from you otherwise. Brian