From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 2/4] block: respect iov_iter::nofault flag in bio_iov_iter_bounce_write()
Date: Mon, 15 Jun 2026 08:05:00 -0700 [thread overview]
Message-ID: <ajAUnIft39_yly9N@infradead.org> (raw)
In-Reply-To: <35a61301ea76c71d101533bf7d4aeffb7752fb85.1781253428.git.wqu@suse.com>
On Fri, Jun 12, 2026 at 07:21:13PM +0930, Qu Wenruo wrote:
> diff --git a/block/bio.c b/block/bio.c
> index b33ff69bb722..01bb76d9717c 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1335,7 +1335,10 @@ static int bio_iov_iter_bounce_write(struct bio *bio, struct iov_iter *iter,
> break;
> bio_add_folio_nofail(bio, folio, this_len, 0);
>
> - copied = copy_from_iter(folio_address(folio), this_len, iter);
> + if (iter->nofault)
> + copied = copy_folio_from_iter_atomic(folio, 0, this_len, iter);
Same here, please keep a sane line length.
next prev parent reply other threads:[~2026-06-15 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 9:51 [PATCH v3 0/4] btrfs: use IOMAP_DIO_BOUNCE flag instead of falling back to buffered IO Qu Wenruo
2026-06-12 9:51 ` [PATCH v3 1/4] block: revert the iov_iter after a short copy in bio_iov_iter_bounce_write() Qu Wenruo
2026-06-15 15:03 ` Christoph Hellwig
2026-06-12 9:51 ` [PATCH v3 2/4] block: respect iov_iter::nofault flag " Qu Wenruo
2026-06-15 15:05 ` Christoph Hellwig [this message]
2026-06-12 9:51 ` [PATCH v3 3/4] iomap: reject NOWAIT and BOUNCE direct IOs Qu Wenruo
2026-06-15 15:05 ` Christoph Hellwig
2026-06-15 22:43 ` Qu Wenruo
2026-06-16 1:00 ` Qu Wenruo
2026-06-16 5:19 ` Christoph Hellwig
2026-06-16 5:18 ` Christoph Hellwig
2026-06-12 9:51 ` [PATCH v3 4/4] btrfs: use IOMAP_DIO_BOUNCE flag instead of falling back to buffered IO Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajAUnIft39_yly9N@infradead.org \
--to=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.