From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD1F3CAA48 for ; Mon, 15 Jun 2026 16:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781540738; cv=none; b=k2hEZ3tQTMIwzuNuzdLDsvrHKg8SY6HHpDWY30oCmJeYvV+IAgQtshnf05CQu4J5g7UiBawt9eWRO/5VV3IWsOptP73mZAAICgO70Y8BOvlVkJtbzE6reyZpu8f4XrTGagXHVM8AAXxzKmpLepLTADZ9GubQbOwcufV08Lloao0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781540738; c=relaxed/simple; bh=cpdanrEZZHYCGntBgvw4/HKw7MxEee3lLVlcLcKZywU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=llKyPXo4Fpggui44DWSnSOs4TEMpnlLdofMsPnW7ZP0DrwdnbO4XzcTU1Jvpt8muXztrKeRY/mYslV46PxqWSO24IVFrmkzPc/7jeYWMPJ+R73k6Xcex1NPdbhNOd8icGmzlkZObzkhY+e8P96FHnaClCS6GfQLa2vx2c5Lssjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZZWZBHaO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UxI81Gix; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZZWZBHaO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UxI81Gix" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781540736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S6+ytjL/MSnSv+jJWWBaXjsErY34EnWmvQDfkC5ZS6U=; b=ZZWZBHaOMs8G6UGyW7YUJJGrymmgZqHWj+VpZY4pd1gUrPdOlS+FfPEvVckAWHc6cnoC++ vAJUUkvKBo4SELjiyYUWXTEPVYS2R77O3txSHywpvuo92n4pclsWg1smX2z4jhCTQ7YR6r PraG5N/b0BKFwrZapi6uso/I+uBV+nc= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-xKxmrkzqNUWZDkBIp0M2Zg-1; Mon, 15 Jun 2026 12:25:35 -0400 X-MC-Unique: xKxmrkzqNUWZDkBIp0M2Zg-1 X-Mimecast-MFC-AGG-ID: xKxmrkzqNUWZDkBIp0M2Zg_1781540734 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5175b7946d5so28745671cf.0 for ; Mon, 15 Jun 2026 09:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781540734; x=1782145534; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=S6+ytjL/MSnSv+jJWWBaXjsErY34EnWmvQDfkC5ZS6U=; b=UxI81GixQn8BVYbGGU0vTt8siOAEeEtsCcrdjfidMq9FMT4l0lFCnZJxeJvhhU+dXi t9840OqsEQWAX6PZgdWUBFWu5bTGykh6AW6bF3rZWJjp9qiKVK776o0fL3mzNkqTCPdT Tq5m+REgq+QBMjZcw40RN5PbN5QREZ31tqIEoT29mN5H7IykRWAYHfs0bQ7nm2VTMFgw 5bm3/pw7Ug1bxAKL/s1kIRhpJ3XbjH21kVXv2hxdb9ai17/ix/g2mf088QERVvB5tbX1 izVtKKAVsIb7PcilTVUyxq/DFRLKMutpTEVuuHKQmmTJlItjgrXK89IVIBcFnVltHr8B nJTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781540734; x=1782145534; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S6+ytjL/MSnSv+jJWWBaXjsErY34EnWmvQDfkC5ZS6U=; b=IWKLY+zKO+VNzdd2ucBnqs+dBCCBU72F/jTvPKYQIjArsrU/C9F/uffaH2e7AOM+tA hBYi8jORuGr8jlsuE6OsIQmIX1uExJz1tyRdXNuPspnBmgR9u1N/kVTsd+OYy1Kkh9r5 WPsanhWSbat2H/LKHKmbe7VdQ/0GuHTXoIjDSkQboOWRW4TOkfqxI67kLlef0vGkNb2D WSgaH249dNgITU50ROnUecKZVcmE07tKB4JLueCv6wKCu4pce86FbNp6cqNqNAFuNypV Efd5tqIHQkh9jsiL0ds4TaTRjGXm0IJX5C5Qqc+4q6IDSZep50Sb4tPoXovAgBL6g4vu Yjug== X-Forwarded-Encrypted: i=1; AFNElJ/L8xKQkGHbhnbffaSS0X3ug2QU3EOFlVKM9j3xNDRcIN6F528zREjMNsNSw6YD+kJBvzp76DIQnYEdRhs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj6TWRIg+nptzbx4HkZFpyV976dO+bnWTiMTmJs5RpoVlNEsCB Exjf5W+4heuVcj5wiygx0V6eH8d72KG7YnMyJGe9k7ymvja9Q7atQjVb9kvIo5NHHzKHLcRvFFu DqzZ5IhA5mrdJnyhuykqT33Rlye8DNXaOiQHafRvs8SpCtdHTWQ3zqp2r8bp57kW1SQ== X-Gm-Gg: Acq92OFlvBtkqjSbTM7NuP0CggOWTlURSPKnULT3A1nTFSDTs7/BeazO58QDDlJJ5+C hh8w1xOIYvbrH3Xzlz0RWXXqdzEznSHyxLthPj7QQYjd8Y/4gVkv+UqTo+NgKDNisxyqga7iN+E OYObMwAxgdF7xT4QXkEjAoMd9L6LaSCWcSW8cxnBpLfmiVAR9LLEFfMLefDM6lJury7zp8UhfID vAw6cr2+9O6lEqDN+SV0Gj/rCIpk1hitMPw89GNuP11VUnzOiSvwlBPyToiH3pwYHf2At3pELQf zkWGMvmK+U7t46BrlRPdRvg9lKojAYVZauIUHHVwPCC27ppGyEwYBrgyyItEgaet/ddDJf9sAgY H8o/BIvNILNSJkC2oFuLdE2qLEsvebpYr8SDq7rHjl04qUoZT2N07fcUu X-Received: by 2002:a05:622a:8d10:b0:517:75d8:b95d with SMTP id d75a77b69052e-517fe5e362bmr202151381cf.40.1781540733540; Mon, 15 Jun 2026 09:25:33 -0700 (PDT) X-Received: by 2002:a05:622a:8d10:b0:517:75d8:b95d with SMTP id d75a77b69052e-517fe5e362bmr202150821cf.40.1781540732938; Mon, 15 Jun 2026 09:25:32 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f4557d43sm2803126d6.31.2026.06.15.09.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 09:25:32 -0700 (PDT) Date: Mon, 15 Jun 2026 12:25:30 -0400 From: Brian Masney To: dongxuyang@eswincomputing.com Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, huangyifeng@eswincomputing.com, ningyu@eswincomputing.com, linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com Subject: Re: [PATCH] clk: eswin: Add CLK_IGNORE_UNUSED to NoC clock Message-ID: References: <20260605092118.1945-1-dongxuyang@eswincomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260605092118.1945-1-dongxuyang@eswincomputing.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Fri, Jun 05, 2026 at 05:21:18PM +0800, dongxuyang@eswincomputing.com wrote: > From: Xuyang Dong > > The gate_noc_nsp_clk provides the essential clock source for NPU, > DSP, and PCIe subsystems. During kernel init, the clock framework > attempts to disable unused clocks when clk_ignore_unused kernel > parameter is not set. > However, gate_noc_nsp_clk is required to remain enabled for these > critical subsystems to function properly, causing PCIe boot failures > when auto-disabled. > > Add CLK_IGNORE_UNUSED flag to gate_noc_nsp_clk to ensure it stays > enabled even when clk_ignore_unused is not specified in kernel > command line. > > Fixes: cd44f127c1d4 ("clk: eswin: Add eic7700 clock driver") > Signed-off-by: Xuyang Dong Reviewed-by: Brian Masney FYI, I posted a series to implement sync_state support for the clk subsystem, which should fix these type of issues for the long term. If you happen to have time, I would appreciate it if you have time to test this series on your hardware, and drop a Tested-by. https://lore.kernel.org/linux-clk/20260603-clk-sync-state-v1-0-457120eed200@redhat.com/ I have a new series ready that I'm planning to post tomorrow. I'm waiting to hear back about the ongoing conversation on that thread. Once this lands, there shouldn't be much need for the CLK_IGNORE_UNUSED flag. I'm curious if you revert this patch in your tree if the need for the flag goes away with the sync_state changes applied. Let's get your change in the tree though. If we merged sync_state today, it won't be eligible to be backported to the stable kernels, and the CLK_IGNORE_UNUSED flag is an easier backport. Brian