From: Lisa Wang <wyihan@google.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>, Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
rientjes@google.com, seanjc@google.com, ackerleytng@google.com,
vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com,
tabba@google.com, dave.hansen@linux.intel.com
Subject: Re: [PATCH v4 5/7] mm: selftests: Add shmem into memory failure test
Date: Mon, 15 Jun 2026 19:08:52 +0000 [thread overview]
Message-ID: <ajBNxPKzhARLFk9X@google.com> (raw)
In-Reply-To: <6963083d-6725-4081-b2a2-894a0510c6fb@kernel.org>
On Fri, Jun 05, 2026 at 01:38:28PM +0200, David Hildenbrand (Arm) wrote:
[...snip...]
> > static jmp_buf signal_jmp_buf;
> > @@ -165,17 +170,21 @@ static void check(struct __test_metadata *_metadata, FIXTURE_DATA(memory_failure
> > case MADV_HARD_CLEAN_PAGECACHE:
> > case MADV_SOFT_CLEAN_PAGECACHE:
> > case MADV_SOFT_DIRTY_PAGECACHE:
> > - /* It is not expected to receive a SIGBUS signal. */
> > - ASSERT_EQ(setjmp, 0);
> > -
> > + case MADV_SOFT_DIRTY_SHMEM:
> > /* The page content should remain unchanged. */
> > ASSERT_TRUE(check_memory(vaddr, self->page_size));
>
> You should likely use "fallthrough;" ... unless you are missing a break; here.
Thanks, will fix this in the next version.
Lisa
>
>
> --
> Cheers,
>
> David
next prev parent reply other threads:[~2026-06-15 19:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 21:55 [PATCH v4 0/7] mm: Fix MF_DELAYED handling on memory failure Lisa Wang
2026-06-02 21:55 ` [PATCH v4 1/7] mm: memory_failure: Clarify the MF_DELAYED definition Lisa Wang
2026-06-05 11:30 ` David Hildenbrand (Arm)
2026-06-09 7:45 ` Miaohe Lin
2026-06-02 21:55 ` [PATCH v4 2/7] mm: memory_failure: Allow truncate_error_folio to return MF_DELAYED Lisa Wang
2026-06-05 11:32 ` David Hildenbrand (Arm)
2026-06-09 7:51 ` Miaohe Lin
2026-06-02 21:55 ` [PATCH v4 3/7] mm: shmem: Update shmem handler to the MF_DELAYED definition Lisa Wang
2026-06-05 11:35 ` David Hildenbrand (Arm)
2026-06-09 7:58 ` Miaohe Lin
2026-06-02 21:55 ` [PATCH v4 4/7] mm: memory_failure: Generalize extra_pins handling to all MF_DELAYED cases Lisa Wang
2026-06-05 11:35 ` David Hildenbrand (Arm)
2026-06-09 8:03 ` Miaohe Lin
2026-06-02 21:55 ` [PATCH v4 5/7] mm: selftests: Add shmem into memory failure test Lisa Wang
2026-06-05 11:38 ` David Hildenbrand (Arm)
2026-06-15 19:08 ` Lisa Wang [this message]
2026-06-02 21:55 ` [PATCH v4 6/7] KVM: selftests: Add the guest_memfd " Lisa Wang
2026-06-02 21:55 ` [PATCH v4 7/7] KVM: selftests: Test guest_memfd behavior with respect to stage 2 page tables Lisa Wang
2026-06-03 20:48 ` [PATCH v4 0/7] mm: Fix MF_DELAYED handling on memory failure Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajBNxPKzhARLFk9X@google.com \
--to=wyihan@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=jiaqiyan@google.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=michael.roth@amd.com \
--cc=nao.horiguchi@gmail.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tabba@google.com \
--cc=vannapurve@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.