All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Thomas Falcon <thomas.falcon@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH] perf: Document recent additions to the perf.data file header
Date: Mon, 15 Jun 2026 16:55:09 -0300	[thread overview]
Message-ID: <ajBYnQMctGqDVFTN@x1> (raw)
In-Reply-To: <CAP-5=fXicnkOSeRCgZu2OXNvOJYVM9qOQdrUStOomnoT2powkA@mail.gmail.com>

On Mon, Jun 15, 2026 at 12:21:10PM -0700, Ian Rogers wrote:
> On Fri, Jun 12, 2026 at 12:28 PM Thomas Falcon <thomas.falcon@intel.com> wrote:
> >
> > Add documentation for recently added HEADER_E_MACHINE and
> > HEADER_CLN_SIZE data to the perf.data file. Also fix a typo
> > at the end of the header section.
> >
> > Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>
> > ---
> >  .../perf/Documentation/perf.data-file-format.txt | 16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> > index 0e4d0ecc9e12..b90cba9168f8 100644
> > --- a/tools/perf/Documentation/perf.data-file-format.txt
> > +++ b/tools/perf/Documentation/perf.data-file-format.txt
> > @@ -464,7 +464,21 @@ struct cpu_domain_info {
> >         struct domain_info domains[];
> >  };
> >
> > -       other bits are reserved and should ignored for now
> > +       HEADER_E_MACHINE = 33,
> > +
> > +ELF machine and flags data. e_machine is expanded from 16 to 32 bits
> > +for alignment. Format:
> > +
> > +       u32 e_machine;
> > +       u32 e_flags;
> 
> Thanks Thomas! I found that endianness was missing from the
> e_machine/e_flags for capstone disassembly support. Part of me thinks
> the unused 16-bits of the e_machine could carry information like this.
> That said, we also have endianness information via the perf.data magic
> value. Anyway:
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next, for v7.2.

- Arnaldo

      reply	other threads:[~2026-06-15 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 19:28 [PATCH] perf: Document recent additions to the perf.data file header Thomas Falcon
2026-06-15 19:21 ` Ian Rogers
2026-06-15 19:55   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajBYnQMctGqDVFTN@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.