From: Carlos Llamas <cmllamas@google.com>
To: syncrain <iganschel@gmail.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
brauner@kernel.org, aliceryhl@google.com, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: synchronize Rust Binder stats with freeze commands
Date: Mon, 15 Jun 2026 20:36:20 +0000 [thread overview]
Message-ID: <ajBiRJANx24mVNUW@google.com> (raw)
In-Reply-To: <20260615201737.262-1-iganschel@gmail.com>
On Tue, Jun 16, 2026 at 01:47:37AM +0530, syncrain wrote:
> From: Keshav Verma <iganschel@gmail.com>
>
> Rust Binder stats use BC_COUNT and BR_COUNT to size the command and
> return counters, and use event string tables when printing debug
> statistics.
>
> The Binder protocol includes freeze-related commands and return codes,
> but the Rust Binder statistics code was not updated to cover them. As a
> result, those commands and return codes are not accounted for or printed
> by the stats debug output.
>
> Update the counts and event string tables so these commands and return
> codes are included in the debug statistics output.
>
> Signed-off-by: Keshav Verma <iganschel@gmail.com>
> ---
IIUC, this should have tags:
Cc: stable <stable@kernel.org>
Fixes: eafedbc7c050 ("rust_binder: add Rust Binder driver")
But other than that, it LGTM so:
Acked-by: Carlos Llamas <cmllamas@google.com>
Thanks
--
Carlos Llamas
next prev parent reply other threads:[~2026-06-15 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 20:17 [PATCH] binder: synchronize Rust Binder stats with freeze commands syncrain
2026-06-15 20:36 ` Carlos Llamas [this message]
2026-06-15 21:09 ` Alice Ryhl
2026-06-15 20:50 ` Greg KH
2026-06-15 20:50 ` [PATCH v2] " Keshav Verma
2026-06-15 21:05 ` [PATCH v3] " Keshav Verma
2026-06-15 21:10 ` Alice Ryhl
2026-06-15 21:17 ` [PATCH v4] rust_binder: " Keshav Verma
-- strict thread matches above, loose matches on Subject: below --
2026-06-15 17:48 [PATCH] binder: " syncrain
2026-06-15 20:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajBiRJANx24mVNUW@google.com \
--to=cmllamas@google.com \
--cc=aliceryhl@google.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iganschel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.