From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5989369D47 for ; Mon, 15 Jun 2026 23:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567546; cv=none; b=uBTv8ZOTDE/UM0QtMT8owuiODlBqSDFxiVdt3hXvxcj/4t7r/0P/xhyoISjY37eITYjfy1Lx8i27SUkEURCMYYTq0hDchuwRNw2DnR9qFnJ1Ze1pi/2i0c1gTX+3ikVOrYH6pkfjRXp258Jxr5kDVJWNsVNqdn1gA7G/tuxvIIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781567546; c=relaxed/simple; bh=SOt5i2BywBkXFWly41PQ3BQqKk6IVCQhp/5l3Wfdr+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NCQiDCdx5j1pzY8Hogu5MBIeOGd8bh6khTwe823ztugkZwRb4EOOuS0UmIao0chBo/zJo9mNuGzpBMfMFutinITAye/xL5wlj8/6IHJ9bfRMo8cV2cx6nPwOxjiwx1T30iA25bxLB+tWkdbu+1i2JzhvxCCSDpugcTl3lXHEsDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Vt+7+KmS; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Vt+7+KmS" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2bf2d865383so13365ad.1 for ; Mon, 15 Jun 2026 16:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781567545; x=1782172345; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UbKI26CmQkmpXGjuaVtHQErivgQSDI5Xz1YBBq2PiBs=; b=Vt+7+KmSubreIwphlu65ysJvm38Ij84QD6Rr0bhcdYFqgbXgk1rDzJdBWusnHsLmhF kknVxv/wlxE+EPXhXaHy2G4xnTK3K8wvcKD+HwrnMIC/VHs8DE9r0V+eLl9gWpPIHWxF bqJM0H45Ifu23Wwtvd9mZ5FhLFL82wwWc5B2AC0sHEZvL2/4n3UykXuJUYJRGcEN8A1d cdkMRyB+A5KXjQSUEM+p7vBsxB4j5nCmEUJGH7jyaClHTR+pbmMkYDayUJc5EE6j4hJW HV6RGQORGq7XZLyllGSzy3by22X65yqzjJp2EbXfoCXZKfcSMZDBdKbU+VSuNiGL2e0l A5EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781567545; x=1782172345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UbKI26CmQkmpXGjuaVtHQErivgQSDI5Xz1YBBq2PiBs=; b=L+LXL7snAWyCZbecORNbw1GzHMTXP50IrHTV4Hz+TO7zXnlRRK7L5H4fQOLTaKZXdR ZJMHZmAzqnnyKPjC9ZvKZ9/Opj/Sovft6p7jGTt+w1KtwqSdaVZCDCmzkg2El+D2VCaR 6Wt9exCUuGuGVXBcqAg3Pn6T907/Vge1RajFUKfSZELpchUYpulo9ZRUlzg/aZRvrjQH gEDSoDlUhvnR06SzJ2UNkS3BDeOEVU1pYn6o/V/9kj0aJAtrV3yYhfHklztyilekE6me 6C7wM6FTVganee+RuJ23nd2X+dyOCL99ALyCdBtxv/yCiihOC3HqJwGoMTe+wbW66ckt JC1A== X-Forwarded-Encrypted: i=1; AFNElJ9vdRGV7HbTDh8Nwlx9pzhKfe6dVTFt2u/h/kaHrj6DDe8/JOCD8vwTMZeLYhODJITpiBQKksy6exKCKCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9Zr+sxfKe8AQ579cv1maaer7StV96VX+mzefI5Nh9iJoPLHFj ZXQiYLzqe5OplloVs8q2QKbtG4nnZKd0lKxg3KsLZOiEyRoyPSwsZzhAgt3lcVerXA== X-Gm-Gg: Acq92OHEZNT0T38lyYmkiGpUCWcFU7rEO2b3S2RVo8Lpmdyb+UqqoQMTmcPb31prb/S sw3wWvWOik2wpsfTirYPu/v5ZZTOeq8W4U/+KI3bHPWK6y6XfWBUdCFB4E0Vt6ECDoGCZz4VZHI kh9FcXUupZzoEJdpw0ghUBiajrWoYVg+WAKuLodXXtcUzUFhQny7W0c8ZP0eZ0NwDVLqzZZBdeD bJCPYsNB3/kaJjXgy8CvH//7s7mNpsy2CAIJJTUrVu4XQ438//QnOrspQ57f/2Opr0EgNw6UODK 4KxQxVBVfZiBqCdNT6+v/nuKeK1L2FwoZ37+tPe+VBMQQYNNNJrx5aUePR09GqfQdSWfrvne8rl oltVKY68/xR0zXno42uVhS4VJI6UO7jWp72+YyEyoU52bHduif7yiFUB30hZmyG6qIsrEU1YkrJ kBfWhjDVinHXq7l3smsff8JFydtkoxqY29IHciNqnxEtO6TwvvEvlaCRKhtzit X-Received: by 2002:a17:903:1a2e:b0:2bd:6dad:7ccd with SMTP id d9443c01a7336-2c69c30a638mr593135ad.25.1781567544491; Mon, 15 Jun 2026 16:52:24 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434afc9fa8sm11601182b3a.32.2026.06.15.16.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 16:52:23 -0700 (PDT) Date: Mon, 15 Jun 2026 23:52:18 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Will Deacon , Robin Murphy , Baolu Lu , Kevin Tian , Bjorn Helgaas , Samiullah Khawaja Subject: Re: [PATCH v8 3/4] iommu/arm-smmu-v3: Standardize ATS enablement failure reporting Message-ID: References: <20260604182116.3179005-1-praan@google.com> <20260604182116.3179005-4-praan@google.com> <20260612133638.GG1962447@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612133638.GG1962447@nvidia.com> On Fri, Jun 12, 2026 at 10:36:38AM -0300, Jason Gunthorpe wrote: > On Thu, Jun 04, 2026 at 06:21:15PM +0000, Pranjal Shrivastava wrote: > > Update arm_smmu_enable_ats() to wrap the pci_enable_ats() call in > > WARN_ON(). Since probe-time checks now preclude configuration errors > > any failure during hardware enablement is considered a kernel bug. > > > > Reviewed-by: Kevin Tian > > Signed-off-by: Pranjal Shrivastava > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > Reviewed-by: Jason Gunthorpe > > > + /* > > + * Since pci_prepare_ats() has already verified the HW capability > > + * and programmed the STE, pci_enable_ats() should not fail here. > > + */ > > + if (WARN_ON(pci_enable_ats(pdev, stu))) > > dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu); > > } > > I would fold the dev_err string into the WARN though Ack. Sent out a v9: https://lore.kernel.org/all/20260615235037.259909-1-praan@google.com/ Thanks, Praan