All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: Guenter Roeck <groeck@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Sung-Chi Li <lschyi@chromium.org>,
	chrome-platform@lists.linux.dev,
	Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec: remove reference to nonexistent CONFIG_SLEEP_TIMEOUT_MS
Date: Tue, 16 Jun 2026 01:39:46 +0000	[thread overview]
Message-ID: <ajCpYqXs8-yi6Mw-@google.com> (raw)
In-Reply-To: <20260616001411.66231-1-enelsonmoore@gmail.com>

On Mon, Jun 15, 2026 at 05:14:07PM -0700, Ethan Nelson-Moore wrote:
> A comment in <linux/platform_data/cros_ec_commands.h> refers to
> CONFIG_SLEEP_TIMEOUT_MS, which has never existed in the kernel. Simply
> remove this reference, as the default timeout is defined immediately
> below the comment.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.

Thanks for the patch.

NACK.  This file is intended to stay in sync with the EC firmware header[1].
While the CONFIG_SLEEP_TIMEOUT_MS is indeed unfortunate for a non-Kconfig
macro in the kernel, we have historically kept it for consistency with the
firmware code[2]."

[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h#5248
[2] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/config.h#7178

      reply	other threads:[~2026-06-16  1:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  0:14 [PATCH] platform/chrome: cros_ec: remove reference to nonexistent CONFIG_SLEEP_TIMEOUT_MS Ethan Nelson-Moore
2026-06-16  1:39 ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajCpYqXs8-yi6Mw-@google.com \
    --to=tzungbi@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=enelsonmoore@gmail.com \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lschyi@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.