From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126423DA5B1 for ; Tue, 16 Jun 2026 06:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589736; cv=none; b=Y8yhq910tLCLtguODLNJS/S5xfhmNPZUbp6sHQcx43sDZm/ODe6MpwD9RuKM6I64htmhWHd3PDCqiAcKnHv3FFo/VrF8YG21OX7RXFqA9JNSrdFmyOHomKgJ0o+tGlJb3I+l1dbWezmlTHys3SfyrKKb5Zt0Tku/dXuUhlgsFhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589736; c=relaxed/simple; bh=70HVzoXgBf9xx4KP/aPDIabbIQagBnvWfiUYl/XUnfM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=af6iEKT0gxnyWhTHyh/BKdmneHKY49EWKpdXP88IPHICC7ImsMQX0uPhUG5NyJ0w2WoJuD3ndgL2k5/U8VC+r8Q9n9azuYSVn6oCNqZmjYeaIGJnCNVndo6Atb6pn6vXebXtk+9ugRdqImvlViDNWRbXdgJ8qywXwbN/8+YvjMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BFluq+23; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BFluq+23" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-30807ba471bso11688974eec.1 for ; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589734; x=1782194534; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=BFluq+23cj9Yym5RSM07lnEdhFpFhNcEgV54UGAgICjgSFNUeTGFIhlEhSkzd7hpuO u5bTilgsZQ1wdLlYLm5HOD9xytna11XlnYt7DqHvzCFGmMXDbPGJLTwIvvCEcG814W7k n7azhY1+iww3TzPMXz0TSTS3TmJbNNkzJJyewmzUH7iJUaxaAQQue6phkcEZXh+UQPHf NaQ+JVieyFdoWD58mKWTDGb2VNTl2Y9PZmdHdjZdBV4J5bFQ1naC+oZDdwfZ8DjbsSTn kejXlQryo2zK0EWYm2I6JEv/LvT3XKKblJDK0Dxpqa6WTmBZf6dyBQRQix6bJIoXua5p vnnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589734; x=1782194534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=Fe+e/V2IVkkM9Teg7nvvxn0WjqPLOgZ/7Jk5xUS7wU0Pb1t8zmoStofMnjPIiJJlTq vSTblSVpZU2edLwJoXqwiaHDlxXO5UkMDPgrQbQvLyz/xxCLG6OFHOcR35WgnSt5EJbh 5hau7xAS9aGvhyjBdSPSxbP8oxYkGCCcaJV+4YTrrolXtWmFoIBE0buWoT15nz83wQ6f aQlQzIrThTmE7HIr7FCw1xsIP2SKQ35o3LrCf2NAH+44u0pe22Sc+TJmZbaOWk2Ua7cf jmKHx6gyIKyPxG6Je3ZLlxVaKAnYDp5QGpNCoAGvUjogMPzx2NtU/xwUwiZn9YgxYHlO G11g== X-Forwarded-Encrypted: i=1; AFNElJ/01gwlix+NalMTtLEi4LgIimCBOV5t42q8zM2nvPG9aTMWxTrIpmmbIgg9w66j0lLGkKU=@vger.kernel.org X-Gm-Message-State: AOJu0YxefWMQ+WCFtx7ibs7N9GP0c3mXts8TE4NOPRmUoT17X+ckMGgN //yqqHXOCuLMFkOiwPWGLrvNyrXLCsl3MfKaPeG+UYOS94kBArizmmLU X-Gm-Gg: Acq92OHD+oXiC3JH/wrJKcvN9Cy7rBOLGGki9Fbq5w7u5BLlsxhsVzXd4f4YtjXW6pM qBWBeximibTwSBc6ZvLyz8AQvJ0Uk+1o5HKL4yeHxU+KqVvYo1iAMcQd0qyJWi4a6F/YLCKcBBR iVS1Hoqj/tvRSnScivLjAIwc/ukZ+eRqTBWyBKj7l0Qln7rF0Nzj+0SBjAt3UwMZbGgPbS1HEma dSxi6V2JCXJ/GFAMboVu1uCB/10FJruB9hhPdrod+vJt1yNaCmWQ6XERse5uSjG9Tq1Ui4g5mG8 Ufehgd/4wqbG/r27NuzdocGXQwxDxEsQOjEmcVR3EQIQu4Kzxda37pzj9S4GtCahoIL2QexHjM1 HzSTFFWBx55mtWsRsUJ3yCmcsS9mXebJm1C24/3co9szA8jNigvQ0mNGsJNAbObBEXdngQV+P4x 24oPg+f1vh8RM= X-Received: by 2002:a05:7300:e882:b0:304:e2a5:689e with SMTP id 5a478bee46e88-30ba5989923mr1369233eec.2.1781589734142; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0357sm16552304eec.11.2026.06.15.23.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:02:13 -0700 (PDT) Date: Mon, 15 Jun 2026 23:02:11 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 03/16] riscv: kgdb: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-3-54b4736a1e77@gmail.com> <87pl1xehi4.fsf@yellow.woof> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pl1xehi4.fsf@yellow.woof> On Thu, Jun 11, 2026 at 08:08:35AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > +#define riscv_insn_branch(_insn, regs_ptr, _opcode, _pc, _comparison, type) \ > > + ({ \ > > + unsigned long _ret; \ > > + if ((type)riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs1(_opcode)) \ > > + _comparison(type) riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs2(_opcode))) \ > > + _ret = riscv_insn_##_insn##_extract_imm(_opcode); \ > > Should be > _ret = _pc + riscv_insn_##_insn##_extract_imm(_opcode); Hmm I am surprised my test cases didn't catch that. Thank you! - Charlie > > > + else \ > > + _ret = _pc + 4; \ > > + _ret; \ > > + }) > > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5479CD98D2 for ; Tue, 16 Jun 2026 06:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Ej4XTuNyFBFor9BuTTzjdPxZprRVZKo5YRCjadjqec=; b=ujgQt3li+pCLov oitmPPtuOdQo+VX5Q8dHm81qr/iUGRWqfhFZ/Hmh2nEmc8y8xKaQNJTw0o8jynwirCYOMNI9WX1Vl OxmcYXTEccHujWel2GinGd+Nm1xylD940TOyWer1sWm7MBaAI8itvTag0mdzF9yjCNQr9xaa84tDg 3hzdWt77GyMXmRVxAXTXmuZtkuXsPAG7LrtKNlmVQiy9tk3gnjWMGZdV+G4XEIU873p0PsQAYHXr/ aLhEFIwTrqveEQS7kw89C9o+5M96liNWA4W8+1MQKVaDNO7ejyT1t+Bezh2BTKDfdRH8GEnQXpIQQ 1YELDP6e6ptfcKOk+jAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMsL-0000000FHCK-1WQ6; Tue, 16 Jun 2026 06:02:17 +0000 Received: from mail-dy1-x1332.google.com ([2607:f8b0:4864:20::1332]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMsJ-0000000FHBf-103J for kvm-riscv@lists.infradead.org; Tue, 16 Jun 2026 06:02:16 +0000 Received: by mail-dy1-x1332.google.com with SMTP id 5a478bee46e88-307631dbfedso8823413eec.0 for ; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589734; x=1782194534; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=QAccRqQCduxGPRvsQTx53WlGOx1A7O6L+buXDsC0JjjuCyzlpjBpGRJsMHGFYIi+mU IuKq1c8c1JHDeFOZP9ewoUYD18haJBaGFQaPMg73IMCs2Hu8UKqAZIC/0dfFahLntXyj OQs3hRkkPJXc2gupkj3fQ0APa+NZj0vpQ+Gtk79F5bB9ipEkzlLHVuS30ZC0iA5sIr+9 F68lsF8T/u1RDc76yrpwbdsXepfikbqYfEbjxzke/GiNRGr7yJ3UpC/T7rK6R9XFnEee MkMjDpfoL6XUD4nUAaJw297+hzVmnMuPcO+vsr9WM9k+LxbUW9b6diZZmbugt/onmEqq oBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589734; x=1782194534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=fHLCw5+geg68kqUDNVvnlBuRoYehGlNVMesJG907rn7bIIEJY9bhmi6/sWDXmH3qaj ZAhbiR1m4QfK7cHpu3dvnaJ6BwWe1e5WemiBqGhvnoYDhe52bZDi04qKyogt4uscW963 hZ9Ajfne4vcDmy8Jx9InD/bh2pnFWlAdARS+ZU11+c4tovOfsIbKxfvZBs3XFvo2rtqx xbcV85GTDeZ3PBwMxkstsmhJ/xk4kQehVMRSQ6rjHfi/ZgmSD+8B1wVhum93vgzh90p1 ULYP0K3QFHbw3vvbVmccXpxqNcdpu9EH1V53ZHL7MIROTX8ujbiz8TvWK2LZw4IRVbmg NBDA== X-Forwarded-Encrypted: i=1; AFNElJ9C0hkPph+TP/wicfO8HX1tBw6ZCdCKkKyY7G97Nl9jIA5mRh76dsSftNoNt8uOEfsB87enYn9djgw=@lists.infradead.org X-Gm-Message-State: AOJu0YxiyvNKQoR24jIOyTYdpHNfu+OfRIMa5/LihtC35slhnEn2u9w+ cYDp4QU8UAfv1ovBUmBc5jkJxTtZSEj+BwxGLX0EhAURtCgwv5n4P8XN X-Gm-Gg: Acq92OF8ORkzxZvgOH9WGgenQfrfK2NK6BavXi+w1xwS59dyERiQ7LrrLSsgdV1z4kR dcvvzPtpAhegdIEOEzw4drK7+LhGtFBpSWOrP44U+JHno2qLokT4UYIa0+xCbCvphv+XanEXsl/ KE317ndeuDNhhHuu9YexYGtHC667h9fWZdlTYpKlxrrv0+nlODTXhRjtS5QJcdjtFlk53Mq17mM b98I6uWobqLvr/lUZO5Ut9rIa6tZVVtICtZ2fKTkYu8hnK9XnkN0/WnPTgG0ZkkZuX6lN4DojFB Dz1fA3HqdfS7adGXYASMCywXCzgmxU9rCZ5AA0aB50K/0RcS+dAE6ExRa4u+VCndXV0mnRawPH2 D8ubMkKHKwABIkqSk8GpvrGWr5fei+Cl9kgofvPivK1v6Rd9ld9cVDuQdBvq/bZCoNDVY2DjOQb 0+vTMS5QlDhXc= X-Received: by 2002:a05:7300:e882:b0:304:e2a5:689e with SMTP id 5a478bee46e88-30ba5989923mr1369233eec.2.1781589734142; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0357sm16552304eec.11.2026.06.15.23.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:02:13 -0700 (PDT) Date: Mon, 15 Jun 2026 23:02:11 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 03/16] riscv: kgdb: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-3-54b4736a1e77@gmail.com> <87pl1xehi4.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87pl1xehi4.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_230215_299997_D8C5EC75 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 08:08:35AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > +#define riscv_insn_branch(_insn, regs_ptr, _opcode, _pc, _comparison, type) \ > > + ({ \ > > + unsigned long _ret; \ > > + if ((type)riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs1(_opcode)) \ > > + _comparison(type) riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs2(_opcode))) \ > > + _ret = riscv_insn_##_insn##_extract_imm(_opcode); \ > > Should be > _ret = _pc + riscv_insn_##_insn##_extract_imm(_opcode); Hmm I am surprised my test cases didn't catch that. Thank you! - Charlie > > > + else \ > > + _ret = _pc + 4; \ > > + _ret; \ > > + }) > > + -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1CE6CD8CA8 for ; Tue, 16 Jun 2026 06:02:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BvbYer5lw0cnFciB10lGIYm0FsUi5jYh7Osw8BwcTv8=; b=QwNG0yCKeRTPq7 nduyKsgwTR1qXCe/By0nt0tDno0w3aDmC5P1ua4vMwV7Q4WJGNvFKoNC46RNqpabsnEopL3B5U5hS mVSewJSRE/wSBGbOPHNG0x/tznEIbWNqRKXp9ilp918nHghnXR+c540s6uw8s/Si+HoB1sKywJ+t4 VVzxkbE3cFRBA5ogBJ5AAncwRua5Uv8PTViqPKiICY8woFnPapw0baJ5kg9rZjxQBudwvu0M77i/l UcyWN+0+yo+v6ke6TO74DSwd1Cvebs/C8aGf6LIBjSA0qgt2fC3wNYIqOllSvUZijl7d8hcYb1FHQ icFPuxu8kUlT4kMK0PDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMsM-0000000FHCd-1k7y; Tue, 16 Jun 2026 06:02:18 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMsJ-0000000FHBg-0zqH for linux-riscv@lists.infradead.org; Tue, 16 Jun 2026 06:02:16 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-307631dbfedso8823414eec.0 for ; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589734; x=1782194534; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=QAccRqQCduxGPRvsQTx53WlGOx1A7O6L+buXDsC0JjjuCyzlpjBpGRJsMHGFYIi+mU IuKq1c8c1JHDeFOZP9ewoUYD18haJBaGFQaPMg73IMCs2Hu8UKqAZIC/0dfFahLntXyj OQs3hRkkPJXc2gupkj3fQ0APa+NZj0vpQ+Gtk79F5bB9ipEkzlLHVuS30ZC0iA5sIr+9 F68lsF8T/u1RDc76yrpwbdsXepfikbqYfEbjxzke/GiNRGr7yJ3UpC/T7rK6R9XFnEee MkMjDpfoL6XUD4nUAaJw297+hzVmnMuPcO+vsr9WM9k+LxbUW9b6diZZmbugt/onmEqq oBNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589734; x=1782194534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pI5rWxtEe50KjcsP0jF926SZexIl8kuuOKapFR5YRg=; b=U7nYN1MRphbXHm5DZmMSvsrHiIINwxpSC5POSic4w+zJ1Fea+wIyqHYT55SL9dHLH/ YY6yFXz1Rg9kjr5ch6Xo69GA8KnlCRnBsLasbb6gLNhFaAqYHbt1fP4e7cSg40SnFNIJ oz+9JcTe0FOroZhmx+zF9+BULD8Qd7jf4446CZG8nsvhKBe51yGSu8fJNK9ZmlYeiu/r nr6Ia4jBEh9ANjHd18TwbDi6QLM/z5CYkpKFvOH9iI/AWF5ABZ2hnjyh+hXjoS+0M8L5 TF9VBNlj7V1u6rcgsl21IOwM7pFp7+6PBpWiekhzMZneyzO+FR8AMUjZ/YJhbQvXAllK ycbg== X-Forwarded-Encrypted: i=1; AFNElJ+o4DBq37q7NS/t+FkChwXCiZISf48641y8TgOSo2OqnliE8+/dn92cnwCjXNkoXXOCg+bRRvKnIP+n+A==@lists.infradead.org X-Gm-Message-State: AOJu0YzQz70oPcd15MEkeBwVfrz9HrvywEefwGnZ53d6VL3GiZI0sIPc l34qw8pTVXYhwg2hcGMkZwrB5PIRTO1f1egwdp+fLexGTODHsSUzvOnk X-Gm-Gg: Acq92OHVy/+4zmv/yIBuWzvnZOp8copA1xuOxnXz4nGLh6N20W2E9fxleeXK+fcbyIK xAOcIYoFj0SNKl7lFNJV1vtAv7EpVAoGhZIXP2T+SYsah3cUDr0YhRpzzP5iMc1EtK2WseWQDOW hAN1BiJ17SoP6NMAj4Ji5fRc2cFfq1oFyzsRF0k1N18JwObMFDOM6VLeL9WxSuGqo0vv64mafZT 6PBrIb+If4ABk6uyn6WQnXhDTvJtkm3s2yP4VfwsPZcexknf+0xz8NkifyEVu5AVmQUH1ofJBGz fHILaUhilfnCSGI/DXD3L8b0Cd5XpcPvDhJu1xst5b03/1/vlgbkppetCDxEBe50xSSew/Q5s4j nqW1Zxzhob00xQLG+tx8jltS125gAXk/fdG6CREfg2VwQ3BnN5sJo8is9datih+3S5x92p+5B+/ gZYXW9VHvPE/s= X-Received: by 2002:a05:7300:e882:b0:304:e2a5:689e with SMTP id 5a478bee46e88-30ba5989923mr1369233eec.2.1781589734142; Mon, 15 Jun 2026 23:02:14 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e5d0357sm16552304eec.11.2026.06.15.23.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:02:13 -0700 (PDT) Date: Mon, 15 Jun 2026 23:02:11 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 03/16] riscv: kgdb: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-3-54b4736a1e77@gmail.com> <87pl1xehi4.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87pl1xehi4.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_230215_299150_F793CCAF X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 08:08:35AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > +#define riscv_insn_branch(_insn, regs_ptr, _opcode, _pc, _comparison, type) \ > > + ({ \ > > + unsigned long _ret; \ > > + if ((type)riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs1(_opcode)) \ > > + _comparison(type) riscv_insn_reg_get_val( \ > > + regs_ptr, \ > > + riscv_insn_##_insn##_extract_xs2(_opcode))) \ > > + _ret = riscv_insn_##_insn##_extract_imm(_opcode); \ > > Should be > _ret = _pc + riscv_insn_##_insn##_extract_imm(_opcode); Hmm I am surprised my test cases didn't catch that. Thank you! - Charlie > > > + else \ > > + _ret = _pc + 4; \ > > + _ret; \ > > + }) > > + _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv