From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6512A3D6CC3 for ; Tue, 16 Jun 2026 05:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589511; cv=none; b=Z5OQzYKIyoCsTQFZssL0deTmXrDJF6EpguRxpESvecUHFgLPpAU+sT2SKUL+w+d+PvrLyqdrssMftQtosdWHqj7EOu2DRiodf5fGv7/+dsnu7eQ7B4kHYp/B/gCpTf6mSf6BiGeKGHlnBEOwV2FPv5pjXjaTNAWueq9HyAHIcZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589511; c=relaxed/simple; bh=pjMEfY3K+/Xw+PmVqjvzMCI+L/T2uYNTTllsMVPPgSo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rJJHj4exxbqSDkQDMggIqsDA7IOFEjNdnUYNxDlVgq0kcmiVSQ+wIL6ES78X/KbekJseb4MnGZAAVkYX8ioUY3mVuAmPSMYfRk+aTbnm4Ev8eZB5ZWCmDY/ys4JeaPU24xbM3zZrVMrh+KfCgPFqSjW1ke/vR/zQeudDfIkKsnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hd1F8ffK; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hd1F8ffK" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-30bb7d20ad9so70736eec.1 for ; Mon, 15 Jun 2026 22:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589509; x=1782194309; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=Hd1F8ffK4luKmn10FBey4LNmAziM2x1JdWre5YrYI3qDbm0qTH0T2U2DTCDooEeC6K kjfv1HLJFQLK/H11d/csXCEOO+nWvzSAjP4hzFNSvQhlbqEbKcwIGEaqCCJ0nX2YILs+ MzF+fOLkosX+N8nTUV7H/L55DfkX2ZVyWwhrvjg8A3cldnZR+UsU5rC31BmpL2zCwjlH embfY1INszhyMb5imBI+bBrasYRUCOwW3qOP97l6Gz4B3yXB60d/TngHIMCKPh9OsPvG ujTw0DuHQF57+grr6rYfchZKmlnXAjuqCrEPn3NSVnx3jmC2Ia/7Ek85oyaDrQSBT8pw 03xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589509; x=1782194309; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=qkx+HiaTDqW85tfmY/XjmpwBLon0/T0mjRe9XMhfzffn9MsleIHWUJxLlSJq76ffsv Hwj0qdg/yJfGS63kp2NRaYcAxyCbve40hzz/n2vbdHRx+YrqBQlVcZx3pPv76xCwgeu5 y0lhJ8Ta+Xph9OMsEsegNDZrfopgUBLJs80mg05Vr7rysp5u2dkhh+TKUki4PQuRRCnd W9UK5z/4ZrK5AudA6Jx7AEkBwCvZyT/h8EzMH+hnFuK55Uoe9ZJ9Hh7yM+hYtBhxSlq3 jdNBkII7nrMcCKoxqRdynRHuFX6Fy3fdoaNlZYbROGE7GpaB+pM6PtUI9W16FQsUuxjn kDqA== X-Forwarded-Encrypted: i=1; AFNElJ+TYLhdJcoOna6J6Zwc3YK8uf2631cAfHHUfYT0GORAoD44U10Ds+5klvf9u3JjvZGpROc=@vger.kernel.org X-Gm-Message-State: AOJu0YxfE2VmtJEMxz8St3MY2zKi2IT6PXCMgxGVVABl6rmf+G6rnEsT piD43DyQXrKph1CmJINGYvitLDUKqDCZmVxP9z9oFbjcrJVThrhYFYK5 X-Gm-Gg: Acq92OGzEs1t+s4VoXwCKtLQB4CGiBF0gr2QjoqJg2hNTQSPbVazdjfYNsgiQqz1Z9U ZFjCnPK1M9dHsHE0CczQDShzWZd08j0a9W+53Kcz2U0bH+B7CyoBTJCoAlH2ZIpWpYE2/F8I/2E MmXOsWpYqvYnQNrm2yHxt38nZagHj3sQtcEXaaPMV+tgxaehdqWs2W2RGnL3jC3+c1xnxScZxVE 4IVepJ7pwzStPvppRcA6oQYxetwsTt3Zmu8YS7a2JG8QrT3hwjlTPFkXpBRbmKcMz69+YcZr5KM zrsPwZpIml0dPp0k0jd1HgGhtQ6bGzS4f6pYhgqdfzOlWbpdSQiu9MRl4FEIfu4A32373KOf8Yu RcR50KAACJZtW8G1Wp8qntWWpgx0HOnaMFiw2/iEN6/Y8m+A7Wj2oCiBahbZHUqr9yQOFlLfRh4 Y6waTkXhUHcP8= X-Received: by 2002:a05:693c:63d4:b0:30b:6191:7f96 with SMTP id 5a478bee46e88-30b6191bf72mr3509252eec.30.1781589509451; Mon, 15 Jun 2026 22:58:29 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e92096esm18135283eec.15.2026.06.15.22.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 22:58:28 -0700 (PDT) Date: Mon, 15 Jun 2026 22:58:26 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> <87se6tejoe.fsf@yellow.woof> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87se6tejoe.fsf@yellow.woof> On Thu, Jun 11, 2026 at 07:21:37AM +0200, Nam Cao wrote: > Charlie Jenkins writes: > > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > > of the data is generated from the riscv-unified-db and because it is in > > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > > description [2]. > > Oh :( We probably should amend the base spec to mention that. > > >> > + compressed_name=${name##c.*} > >> ^^^^^^^^^^^^^^^ > >> this name is misleading > > > > That's fair, I can rename it to be something like "compressed_inst"? > > My issue is that "compressed_name" indicates that it holds the > compressed variant of the name. But it actually is empty if the > instruction is compressed, otherwise it is the original instruction name. > > I am not sure what is a better name. Perhaps just inline this to the > usage below. Oh I see, I'll come up with a name that is more clear on inline it. > > Nam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E1FACD98D2 for ; Tue, 16 Jun 2026 05:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r1nPZHYPpbxuoCYlPy7zsm5gaDdrZRiG9EOAqQfHqxY=; b=05icAAafzEpIkg HXwo8/Zp25dhbHM/wQ4GIEuuT00EhrQdTpJeoHB9wFB0k4ENO1/OCQx/oSdEGJ7bn98dAeLuWuCyp HDgeVoyBjkvemcKtoY9tc/D0CYr2at+77KF4cgjaon2Rptv9tI8bRUwNvoaki5dH5Qv5A8wcfZARQ h9ZGqXFUglstWQcgCS5xfoeJljhEZWCLKk+7PaJt/C+t/x3GFJUgBTLhyIO+cg+BJCt+cJHQWfp2b /WTttbtjjZf+g7aucuqvj6hSN8akmnxUv5WqGJ/yl7ndI9V72LGKAhuK6p47JE2dMC/FTf9TLSSxE R0yWAGYqxL7SK9PTISqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMoi-0000000FGyQ-3tQJ; Tue, 16 Jun 2026 05:58:32 +0000 Received: from mail-dy1-x132e.google.com ([2607:f8b0:4864:20::132e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMog-0000000FGxi-3axD for linux-riscv@lists.infradead.org; Tue, 16 Jun 2026 05:58:32 +0000 Received: by mail-dy1-x132e.google.com with SMTP id 5a478bee46e88-30bb7d20ad9so70737eec.1 for ; Mon, 15 Jun 2026 22:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589509; x=1782194309; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=eiEm9Ido7Ts6f/iS7TxUvCuz+yry19/S9SiEopMQe/zXxznA6UFUtm+qIx6wLbEKO9 4fNUF24FzybQJqPI4tX1S8dIMqNyfEeHga2lnlNWVy3GbPO5n2kwmpvJUm0mK85A65Xc h2eNakVrmSMTEEBsXBpDVeCJ/3LVSj2y5omdtE/qqe1+pfB664FIE81UV1NZ7/DP7+32 a1WyeaFVUGx3ArPlwKYpS37eV2pXN+ZPC05IIunz31UWY4ZgR8Z+9y3NSQBRxoC+cmvn qWzYFzU5fB5sfrmo9f07WWTLHp6osNZIPXcaVnGZcYxE3k9eKtL1MyUsxczz0DeN+tqw 7EJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589509; x=1782194309; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=D/KHvrh0NMsKLpBuCA9N6MNLXSOViGk3X8zNhXIFiEBsP0di8v2BCUn30c80D00QLt ICY/pgj2d94wi46FgMzUY1gXM4+iswEaK+JGNBppALBgzQMEUeERleY204ejJtc0GEA6 +VhpzsC5o54/bAFJRLTmYJHBQPd6SSjCd2IZjTh9+TpuAPSL3U62NhFz2/p5rsnE+50p 3n7OM5yQvTV00mgMMGtrHxQd2v/PDZIH9O2buYm5xHPbQAqlsPnqoJvDcf4FSLlDr90v 3HZaleidxLMbzlJaz7yguN9PT/59DueL7YS9bvPFOTJfAxNWE4TKTtT8tMIiV8gf55VW jXaQ== X-Forwarded-Encrypted: i=1; AFNElJ9yvt99mH+L+CfSaitqwgcOdJdUTmVIuDTuzkiSFY8xvkv894NLwtgekHxY+S9kPu2dH27CUtccIj/EJA==@lists.infradead.org X-Gm-Message-State: AOJu0YwSDeCy3bo+jFIvK6r9TJtBBudiFzTFMAymQFtimi8KTpqERGQg 9wUyQ268/lDA7qL5B+2wjW/yNWzlLoZRUbjTpMdWrviHizAkKrj+h6DzVwGQGEYY X-Gm-Gg: Acq92OE7V+4GFd5690i0cxGyBURUPUyql08z+c8tJlViXUueIIbM6KCgVIo38kjj99j /b1ISy8f5KAAy6WtWFpRlwCo/rNMMeoog3wUJMurXpQEzP/WNrBnEPPAvzcp6SwZPwO80ktD9vR pXiUbbsSfGiuaxq0nS5X08zWXSZ/imIY1otiWJmrGwXeFkqjgqGABhSER1fSHSdWvvCaWgiITf+ VQlhZo2CiGLSUdjbXmLU/fK0LEOgKLFlBIW2LEJFjBX6RIcJETRAUKYSOhDfZK0zI5Lw4Mx0a0R fakf7yHmiVUuaZdz2MRFdBkBJnDN9tG7RxOvfHkweuJ/zb6UqjKZl2F8qiwxdSJe+4swQzK78ps yIQqRhujkyw0bJI0IEKtw2XKMMo//7xz7OguaJ8a2Bs/LRjOR0PMTJDSrk58byiEJgoXNEYWNCu e8T8D5jrHUI/g= X-Received: by 2002:a05:693c:63d4:b0:30b:6191:7f96 with SMTP id 5a478bee46e88-30b6191bf72mr3509252eec.30.1781589509451; Mon, 15 Jun 2026 22:58:29 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e92096esm18135283eec.15.2026.06.15.22.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 22:58:28 -0700 (PDT) Date: Mon, 15 Jun 2026 22:58:26 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> <87se6tejoe.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87se6tejoe.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_225830_898376_39C098BC X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 07:21:37AM +0200, Nam Cao wrote: > Charlie Jenkins writes: > > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > > of the data is generated from the riscv-unified-db and because it is in > > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > > description [2]. > > Oh :( We probably should amend the base spec to mention that. > > >> > + compressed_name=${name##c.*} > >> ^^^^^^^^^^^^^^^ > >> this name is misleading > > > > That's fair, I can rename it to be something like "compressed_inst"? > > My issue is that "compressed_name" indicates that it holds the > compressed variant of the name. But it actually is empty if the > instruction is compressed, otherwise it is the original instruction name. > > I am not sure what is a better name. Perhaps just inline this to the > usage below. Oh I see, I'll come up with a name that is more clear on inline it. > > Nam _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C061CCD8CA8 for ; Tue, 16 Jun 2026 05:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wJ/gLq8J3cdx/DJA1ptH5jcYONaHnXWNF3t0zCj8U1w=; b=V50KivBDNRo5PB 5/zTu7Xq3aqMj7ln4UfnCeSb8UBWNf5FMPTfEIzJFlAwXJf/gx7UqwBDgPRTmZ52o+S/ZQyOJ02rs gnm1s3k3kmATr66yvtmQFynmTHq+zbuwP8uuXTtNQFf0glQbOqLFCmRi8WslHTzSGYzfmTR2CA4/f Xp42eXm2wsci41bALi5vq11gUETC0BpY2E4wmYMltycuheTLtFZK3JreZCWld02cLRQXn7MsFNOxC 1rkVdJxrqr9ZxU+jP/8v7e01LAzxYoVKBk4yFMcm2d81zZeoM6dzrChBu8npBR3/6XCqgBfMbsi8A E7nY/VjM6PtfiBXD/+KA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMok-0000000FGyV-00FT; Tue, 16 Jun 2026 05:58:34 +0000 Received: from mail-dy1-x132d.google.com ([2607:f8b0:4864:20::132d]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMog-0000000FGxh-3Zqr for kvm-riscv@lists.infradead.org; Tue, 16 Jun 2026 05:58:32 +0000 Received: by mail-dy1-x132d.google.com with SMTP id 5a478bee46e88-30bb7d20ad9so70738eec.1 for ; Mon, 15 Jun 2026 22:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589509; x=1782194309; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=eiEm9Ido7Ts6f/iS7TxUvCuz+yry19/S9SiEopMQe/zXxznA6UFUtm+qIx6wLbEKO9 4fNUF24FzybQJqPI4tX1S8dIMqNyfEeHga2lnlNWVy3GbPO5n2kwmpvJUm0mK85A65Xc h2eNakVrmSMTEEBsXBpDVeCJ/3LVSj2y5omdtE/qqe1+pfB664FIE81UV1NZ7/DP7+32 a1WyeaFVUGx3ArPlwKYpS37eV2pXN+ZPC05IIunz31UWY4ZgR8Z+9y3NSQBRxoC+cmvn qWzYFzU5fB5sfrmo9f07WWTLHp6osNZIPXcaVnGZcYxE3k9eKtL1MyUsxczz0DeN+tqw 7EJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589509; x=1782194309; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PSlzuZQ4Daz0lqLHFL3WubdgzTXoK9WA+8u5CazoU0=; b=q3of62UFyaeTIHkSYvX1IO9Nf12rby8W6uVe6vxwzr4AQsSHO4o2zwynlkdCbVrShT r76uv4QeCO9zB3vPW9hpCG96YmV4UD2keVblUzPlmBFModpQNUFOTrYuhsdlJCfcLlqj mbNmOuTbxEFIU/TuztNTNDv8AkQkZv5VtGygMwLnNOUHkoA8Wt1/5Aa4Cszmq1rTuae/ 15L6Ag8supKU7WAJIk3PBJsrjrP/zD5ZhS5aQQmgAKVpkjHFv6Ybd8NGyh1nh1cpoEiN vkDHW+isKKqY4U38+KsE5skIjKke0+2qqRVK7CfEcDq31nzaol+ZHq/52SwjfaJHycJT 6WJg== X-Forwarded-Encrypted: i=1; AFNElJ/6BjnFJrqURAhZah8HWjxU3e9ruCbwMOCneAvbt7qt9mZHZyETYhhA1lXhzZeL0Vi5dgzn7xALuNk=@lists.infradead.org X-Gm-Message-State: AOJu0YzYEEs9VhT1kJMt9a1qlXX6aBf/wpNYpDwHIc68l+nmux8xBjvK hsVYgUO55bNsyOj3jlV6Vw9xvZfPH3CNhGMa7J9Z8xkRp0FwXqedXTLz X-Gm-Gg: Acq92OF7lFgrD00SyznHG700vWxctogPSm/94hBymk6gQRHUwkEa7LkGG6CqlCDhv2A wOcjeBEdIFngxkB3VuKolCci+Shzlum6aRRhtMdRpSPSkFd8KitrAp3ES/4Xwq9Q1d6fTkZu3EB aU87+WLjMbSBnmWbv/sQV/z+cPee9C+IzOUuESW21bOblBY5AQunCdz32vbTu9ADXE2PowPnPsb B5d/tO1ZSD4Vh5Pssa2tOpyngoNvTHXUqCKqdUYwFaLVOaS2B6OY0Od5SNq5wGBknAnwHS6Z51w N4DnIU204IarVPdwsO0ux28QNNrbUH3zZlTaNA0NzLTAGp/FqFTn54fKMqyfMuUA7F1+xdNnSuf SfEb7aWXb4hQP5YV0iQTJnj+uuLLBKH9aM/q5RNSlBjzOXsJHnAvkjUO7UKRLXjWvrbTHdZlITp FijkCD2crS788= X-Received: by 2002:a05:693c:63d4:b0:30b:6191:7f96 with SMTP id 5a478bee46e88-30b6191bf72mr3509252eec.30.1781589509451; Mon, 15 Jun 2026 22:58:29 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e92096esm18135283eec.15.2026.06.15.22.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 22:58:28 -0700 (PDT) Date: Mon, 15 Jun 2026 22:58:26 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 01/16] riscv: Introduce instruction table generation Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-1-54b4736a1e77@gmail.com> <878q8m1j9y.fsf@yellow.woof> <87se6tejoe.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87se6tejoe.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_225830_898325_2DE58DAE X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 07:21:37AM +0200, Nam Cao wrote: > Charlie Jenkins writes: > > This is a weird one. The Ziclsd extension introduces it for RV32[1]. All > > of the data is generated from the riscv-unified-db and because it is in > > the Ziclsd extension, c.ld is included for 32-bit in the c.ld > > description [2]. > > Oh :( We probably should amend the base spec to mention that. > > >> > + compressed_name=${name##c.*} > >> ^^^^^^^^^^^^^^^ > >> this name is misleading > > > > That's fair, I can rename it to be something like "compressed_inst"? > > My issue is that "compressed_name" indicates that it holds the > compressed variant of the name. But it actually is empty if the > instruction is compressed, otherwise it is the original instruction name. > > I am not sure what is a better name. Perhaps just inline this to the > usage below. Oh I see, I'll come up with a name that is more clear on inline it. > > Nam -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv