From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6BB23DA7C6 for ; Tue, 16 Jun 2026 06:06:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589996; cv=none; b=PczIVStpravx04lp9Dh57NbAf57YQ1B3X8ybUuVyGwz+HstPyjOqEeU369xdNTZYExaoaBmy5j2iyYnO5wf/irwVez26c1OyTcrv9s/0Q+5ruuYWXlqdEIb1XcNlVAUIk/fx9jny8vJLysTZiV7ZvB95jKtXGufCgvu4Kn7FtB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781589996; c=relaxed/simple; bh=mePsKDgnT7KOddPsWmdqbXoE1a6nKcnpxg0gh2nBVl0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C1w6pXht/UdDswF/FktjG9ETfRsJKlFuD3O4nOkp/no3aOusJpjVyKtv+HdZNVpHkOe8pMKrkchNcw02keKkCSEoV24olcw4RB+i/I1RBabquJTHeV1k0jA6uT5fncqHSl7mmq2feTwikZUfu28Bkr9rOE9lsCZrOvPc6SR4QZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UsRXjzhh; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UsRXjzhh" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-13721dfd471so4560541c88.1 for ; Mon, 15 Jun 2026 23:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589995; x=1782194795; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=UsRXjzhh/OPRjISmvTo/9WfMbQdKEGrdt3absXsOCVkL+IU9aoHRe/USl0dQD1RCiW AhYg/uwMkg+blc9s/8JI3jwvDyfgh3zV9SraUR/NwCgPUNdumH5nJevwgpKBDdus3Qt7 jAGQ+9rUQCBx641pyaBNpkFtqwDZlL+XXje9JET9IW35adAKfQwhGxsdldxUbUHF+X2k QayaiDrJdCF4/+lLViZSpatRRNy+T2sLPpLG+1tZq2vq3zSvZz5mWCvo8ByHNvvho3F/ BeNSb3eEfXLL64YEANpULqntGFHZvUaTB0hVCCAJxnRYaYZB4FIooebNzbQSdKlqg1q9 P3jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589995; x=1782194795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=P6Oql+1XQxlbsIcaY18bLWl5B3VxToAHGOjJWdRzEf5t3LHwRXmniEQ9vDVAKhVVh2 vPkm6m+3spGKJiFkWdx4EQRJ+U3eUcm8zNSch1mXH1dDBmObOXlLLVeBLHEEgClQfDGd kWqOwGIGNKLNx8xCx2qOToJiWr0kkk58CvrHRo31iCNTQUz1k1zVgNRZeI/W+HMnBa7R LEwi3Ce1ix7FpoVXWB/zR17b/k4zFBTdqxIUuPjY9Lad/6ZZ7Bivn6rmYfI6mmOQyIK7 XflOJn2Xj6BBx//V29QyIUxJKQsbBz0a5PU0HvIzc6BsbUOKGG36wemfkTvMORSEVUl5 2oZg== X-Forwarded-Encrypted: i=1; AFNElJ8YlEJPkZJ4+1kjlZX4fzUbvb83hT7luBncPst3gJPu0f2IjfHJnX9fnaW5KfDElCXZDGY=@vger.kernel.org X-Gm-Message-State: AOJu0YyIhBkPvBEj0vrrC6lNCgjMfs1cJo7aSo47VMikwD9KttwQKQb5 2HPuO+Ve8fOErNS84FE3UbT7YV4K8zWSYiHh5IYc60SjLwKGQVmJXfQK X-Gm-Gg: Acq92OEEqXN7gkkyhpAPaBfwQ2t8KG9wAZLajER/Il31acavjsqUx/tCJRIdfOdt5iS BW6CzVvoVg9rrh+eg0aODdqTuVsdUd2lByGkRTbR+0TMGu4O8J4BRxjCuKQYps087IreAA2Di20 AJVwwbbphLXSNQgdCDgW1rlSvG2Xq4M4iQKz5OpIvpgWuU/n2yyBlyRaGkl3LNGjmxBLKFD8ykg NpQCAtKjLWewlszboivXKwuJDx/bEKAw4sQqlZTMeSUfJWjkFP3uAdPejw6XwtCcSRXASCHkURW zZqsbwhPjiUyuNniOukgaWyA14/+qExo5V6LSYe6v9bY+F16eUwFbfuzTwP0wwBiIwS1jb/P+oQ lv9avFdHyiX360+N0UcRA1julvzSwzr+a9abqJSHH5zvNQHuCeDx0DQIFyz0/8q29ixsQsJqhAN XY5r5CeSyTak0= X-Received: by 2002:a05:7022:305:b0:136:b370:64de with SMTP id a92af1059eb24-1387901e454mr5481988c88.32.1781589994812; Mon, 15 Jun 2026 23:06:34 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b96d6c4sm12930812c88.9.2026.06.15.23.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:06:33 -0700 (PDT) Date: Mon, 15 Jun 2026 23:06:30 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com> <87mrx1eh8c.fsf@yellow.woof> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mrx1eh8c.fsf@yellow.woof> On Thu, Jun 11, 2026 at 08:14:27AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > bool __kprobes simulate_c_jr(u32 opcode, unsigned long addr, struct pt_regs *regs) > > { > > - return simulate_c_jr_jalr(opcode, addr, regs, false); > > + unsigned long next_addr; > > + unsigned long *regs_ptr = (unsigned long *)regs; > > + > > + next_addr = regs_ptr[riscv_insn_c_jr_extract_xs1(opcode)]; > > + instruction_pointer_set(regs, next_addr); > > + > > + regs->ra = addr + 2; > > c.jr does not change ra. Looks like my tests need some work :/ > > > + return true; > > } > > We have CONFIG_RISCV_KPROBES_KUNIT now, please try that. I can try to extend those to cover more. - Charlie > > Nam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE848CD8CA8 for ; Tue, 16 Jun 2026 06:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DYbh2QELkQ7N2s3n0IrE0yqQ0hkAy7uZr8dHnnNrN9s=; b=2fBb2MxBdNOVFZ zCfZGCNmoQ1Q9GSLql70y6pFTo8mWnOQsfX5bR4hGSQCHRHsjg5t/NRTn7e8F435S6JODnkObVmrB pO+N1FN+Cg0BIq2Ea9msQNEqRWD7w4Iz3FsPH8PHN224Fxc1XKXgDPv82o+QwFhVrxxiVF3cTqV0p U2FnMaOkZu198qcO1fNLtaecllIqWf/Gzg9u1jsXAlPW6g2PVp1DTyddk3HAovdlAgnAGxc65RhRK JKdeadgvM4gVhdTWqp9J3H5zzSs+R61vT01MfJvGT+Et5S4VR17mrC0v+QFZ6VC1IqrGQ8/06YMFY 4VZDtVLJ9xsAolvx8PrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMwX-0000000FHhy-2F61; Tue, 16 Jun 2026 06:06:37 +0000 Received: from mail-dl1-x122c.google.com ([2607:f8b0:4864:20::122c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMwV-0000000FHh8-3SUR for kvm-riscv@lists.infradead.org; Tue, 16 Jun 2026 06:06:36 +0000 Received: by mail-dl1-x122c.google.com with SMTP id a92af1059eb24-137ec563a95so4523576c88.0 for ; Mon, 15 Jun 2026 23:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589995; x=1782194795; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=Bv5N4JKWgxIzfHSkJbJSLWfq4G6AFxPkWLZOijSs9KkEPwBPbY6Rarnw9axNViDHa3 To5IHfeakl0hGtzd/4C/TKyat8ceGndCRMjRKIfPL4ew8apEq0GJ8EzRYBwFmibBuTj3 Vucy/mL9ZFXZP6VtNpZYVHh0/rpVzi7TX7p5ppUHDzM3reSv+RyIpkVhXCd0SVpj6MBI dM4O5K8rGcGZ/EHBEhSpyvo022JNoD2ANFzAI/MWAwMvP4jSsjtsIGg1PY+voLDfPz9I smPsJYAdOIP2tp5CXuI6XtVh8cipqAxmziT71SjslLClReJ25YqmJW25s8LgRSD+w7Py idaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589995; x=1782194795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=kBFEBjfmE4uAtpYJaryfYmo5GXAmnbQF22dRbnBeydwlZ72fsu+DPrfhTZqcyu6D+a XPfj4aE+Y6TqeGmlseoWBHIehgWuhoGAZZiYkotxp4VQzvnnFj9Zt2x0VL669EUBOVnP gCPTTfRaHxMWMxJAqs7L6Mac1BzI73WDaCeRNNu6n8qqI4DY5QV+9fK7ModFUfmp+p9d F/iS7XpOJbN4G40IPZaIy63XoY1Z6z+NI+S8bvZhW6NNgu6S+TM5r/scX9eK2LE8HRsL Zy8bY3pDxK+zq4Rra+2QKnSh78a9BYbPkiaRJsWtFVGI3cwIdRqWEwtj/Peghl6Er8nw vqlQ== X-Forwarded-Encrypted: i=1; AFNElJ/7jfDdgR64zkYbJ/JBL9ULnJauTzK7GlZild5oxjCzRStFIrj1ImGRwZe/IgS0fEHdTN7apnlBSL0=@lists.infradead.org X-Gm-Message-State: AOJu0YwENGfgs4bE8zQfFrmuOBXJ4S1CICCX3cepj7i42I3vOZT+YcyY LHtxaAE5IeIgkgWnFA2pyxSKRi6B5d8/D9rxtUePeeZHvI9KtKu4DVm4 X-Gm-Gg: Acq92OHKVWtiUH9M8NMTHw90IKtKttN5RKaLLwsnAWnmtvcPh6rfe4tTVASzwTF4KsU TwbUFJ2sy/PQgEJ5nUHh8/bI0XuiffrdaL9ENTlhiCKHnkY463Ul5PhPo0qYSaYh0dxDJ3RhQ5T WeCYjjjj++yDAH6Qee6vPjX+ow4MUcLsk+1rxXh0CRs70vY2T2vBWG7kjLzCwYyob9WO5fROY6h N5GngxyVqna3KZZnS6pyeevs3lYgr42yjhhCFmnT14SgIokn8tUjRrikJmOjgfsbUDb2MdZRt5w Elby0Kfq8Xk2FhZQBklxPTONwQ2wDlhcrxqgG8aW9fAEcB4QfAtyicOr4XFFW0VRCilGCqngWjb Gsd31JdbQPXk2vjqOGqFIbYXD2LtONS3Vz3bK4/YsCvFj0pwaQUOFt2qPuut2P3xu5zWLfuBo7c 8s3YBNZ2vie8o= X-Received: by 2002:a05:7022:305:b0:136:b370:64de with SMTP id a92af1059eb24-1387901e454mr5481988c88.32.1781589994812; Mon, 15 Jun 2026 23:06:34 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b96d6c4sm12930812c88.9.2026.06.15.23.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:06:33 -0700 (PDT) Date: Mon, 15 Jun 2026 23:06:30 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com> <87mrx1eh8c.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mrx1eh8c.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_230635_865692_877C0EDC X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 08:14:27AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > bool __kprobes simulate_c_jr(u32 opcode, unsigned long addr, struct pt_regs *regs) > > { > > - return simulate_c_jr_jalr(opcode, addr, regs, false); > > + unsigned long next_addr; > > + unsigned long *regs_ptr = (unsigned long *)regs; > > + > > + next_addr = regs_ptr[riscv_insn_c_jr_extract_xs1(opcode)]; > > + instruction_pointer_set(regs, next_addr); > > + > > + regs->ra = addr + 2; > > c.jr does not change ra. Looks like my tests need some work :/ > > > + return true; > > } > > We have CONFIG_RISCV_KPROBES_KUNIT now, please try that. I can try to extend those to cover more. - Charlie > > Nam -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90E0DCD98DA for ; Tue, 16 Jun 2026 06:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FCry95rWS4tEZWYsBlx4w5FW8axC1hZp6YZjL1FxGEk=; b=Gq+BrTe1xeSZFi Gkv4bgDMNXGrnO4ujjA7C8exuEzJVPSMobGA86HH2UTi4tR1d7CHTV17pDJu4Bv8UiMqQlNzo5eqS QBdDmlwbnn8did64gddz3Xln78dSoR7ugDev/znISEF0ktT+gSyjyDFLhWvYmrik3NmOLHvLJww3A 24KRl9WosqHEviqak9azyV1Ner6nMSupPxC4k1SE1tU3DnqFvDUfV+TMaI5+WUehNPOOjNu78gdrf uzPpISvL2pK4L70aS93TleNmRlezDxxxCAnfCUsUMSA9c17Qfq2HYB6vRj9EAUfE9np9wLqxdrBOn Gk8LBN47flEvAB7tWKCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMwY-0000000FHiV-2St7; Tue, 16 Jun 2026 06:06:38 +0000 Received: from mail-dl1-x122b.google.com ([2607:f8b0:4864:20::122b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZMwV-0000000FHh7-3SM5 for linux-riscv@lists.infradead.org; Tue, 16 Jun 2026 06:06:37 +0000 Received: by mail-dl1-x122b.google.com with SMTP id a92af1059eb24-137ec563a95so4523573c88.0 for ; Mon, 15 Jun 2026 23:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781589995; x=1782194795; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=Bv5N4JKWgxIzfHSkJbJSLWfq4G6AFxPkWLZOijSs9KkEPwBPbY6Rarnw9axNViDHa3 To5IHfeakl0hGtzd/4C/TKyat8ceGndCRMjRKIfPL4ew8apEq0GJ8EzRYBwFmibBuTj3 Vucy/mL9ZFXZP6VtNpZYVHh0/rpVzi7TX7p5ppUHDzM3reSv+RyIpkVhXCd0SVpj6MBI dM4O5K8rGcGZ/EHBEhSpyvo022JNoD2ANFzAI/MWAwMvP4jSsjtsIGg1PY+voLDfPz9I smPsJYAdOIP2tp5CXuI6XtVh8cipqAxmziT71SjslLClReJ25YqmJW25s8LgRSD+w7Py idaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781589995; x=1782194795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IYT2HIZ/TljEaPuQNyUPwKuwE+O4A3F++I0Be4tA0UM=; b=qbtcC2KLDksrYYQiAMPPYUg6Xik7V6tdJCmh/8SGxUHqMIk5eLstrPjhn2N8OdAYy6 pVASFiLUcqZ3csh5nnl12eviYKANDAahZWyPGGDQbt52Qzcau49fvBbJJVwHaLGhFWTg p8SFimP/1MQMk+RXs3j4879yi9kTkDh6jHZLMedkpXRnlGmrJR5f5U9TMINVoCuW41q9 Vj7wvZbaSSkObmSOD9CCoxTuvV8qJefK3OD6hQ+EL6GGrFHpXuhBs3IKxzyTQLNKoFAV UYkaklPXC09OhZNuWku4k2+pJnb70drVtvIubJJB8CECk0FSLBsYfeoerTQaX/7Kt6MK gYEg== X-Forwarded-Encrypted: i=1; AFNElJ+D97EuIgiiNFcOytlkw4hQvNWH8r9Pf5zMi/puqs5fReFKReQoyddAiZRzAA1Jrs/MKj22WXVEhNNm2w==@lists.infradead.org X-Gm-Message-State: AOJu0YyvJTl9CcEKMwhQPiAZ2d4hiUBlc6JTqIM/498XWTnh9lt9TLK7 CNdEZcRRopoJkQUr3Bxen32nWfJ4haJ3Px9zVCB1YNTD5TNqI0aFeX56 X-Gm-Gg: Acq92OGfuQcNilLKf3i7CJSM1O1tVsvTjCw1GxJgZLBVvqpct2Fgk0h+7GP1oNPeN0z eVTKK9wtbgIN5ogiCnMAzgsVZWmotWcodrmuO9/mS5G5vVVhyIC37NVB4U0AftA6eCL2D4LEXbr gzTSWte9F6iHPgjHdp1IHhH1e8oQmSDPSRRjAVoEy3dmcGMV8d3UAsbWupPGynTAYSDrLWd514c MORN6wnwLcuPdoQjnFYR0AiQbcERngtA0Qp0KPhNZGwneBM3Eltyt19AqxN12iMYkPCCBdZOLZ7 7MPDVRpiy4P/At750qKj8CTxF8DTOndsty2OEGUB8S4MqNpkgnyNv+/uP7AFJpanSpCmuSXrk+e CtS+0i41QLZev2YHsJP80ux95j+9mcivsyCIhiNk2zmtiUOYLSp5p8QqA1m1ogr6DP0n9JS0sMl Q6kItrgD4JLU4= X-Received: by 2002:a05:7022:305:b0:136:b370:64de with SMTP id a92af1059eb24-1387901e454mr5481988c88.32.1781589994812; Mon, 15 Jun 2026 23:06:34 -0700 (PDT) Received: from blinky ([2601:647:6700:64d0::92d1]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1384b96d6c4sm12930812c88.9.2026.06.15.23.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 23:06:33 -0700 (PDT) Date: Mon, 15 Jun 2026 23:06:30 -0700 From: Charlie Jenkins To: Nam Cao Cc: Charlie Jenkins via B4 Relay , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , Anup Patel , Atish Patra , Conor Dooley , Paolo Bonzini , Andrew Morton , Shuah Khan , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 04/16] riscv: kprobes: Use generated instruction headers Message-ID: References: <20260407-riscv_insn_table-v1-0-54b4736a1e77@gmail.com> <20260407-riscv_insn_table-v1-4-54b4736a1e77@gmail.com> <87mrx1eh8c.fsf@yellow.woof> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mrx1eh8c.fsf@yellow.woof> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260615_230635_866236_DF2E79A0 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 11, 2026 at 08:14:27AM +0200, Nam Cao wrote: > Charlie Jenkins via B4 Relay > writes: > > bool __kprobes simulate_c_jr(u32 opcode, unsigned long addr, struct pt_regs *regs) > > { > > - return simulate_c_jr_jalr(opcode, addr, regs, false); > > + unsigned long next_addr; > > + unsigned long *regs_ptr = (unsigned long *)regs; > > + > > + next_addr = regs_ptr[riscv_insn_c_jr_extract_xs1(opcode)]; > > + instruction_pointer_set(regs, next_addr); > > + > > + regs->ra = addr + 2; > > c.jr does not change ra. Looks like my tests need some work :/ > > > + return true; > > } > > We have CONFIG_RISCV_KPROBES_KUNIT now, please try that. I can try to extend those to cover more. - Charlie > > Nam _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv