From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: rodrigo.alencar@analog.com
Cc: Michael Auchter <michael.auchter@ni.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH v3 07/12] iio: dac: ad5686: add ldac gpio
Date: Tue, 16 Jun 2026 13:32:24 +0300 [thread overview]
Message-ID: <ajEmOCh8hdmfTHKW@ashevche-desk.local> (raw)
In-Reply-To: <20260616-ad5686-new-features-v3-7-f829fb7e9262@analog.com>
On Tue, Jun 16, 2026 at 09:21:13AM +0100, Rodrigo Alencar via B4 Relay wrote:
> If wired LDAC, should be held low when unused (pin is active-low), which
> allows for synchronous DAC updates. This will be used to update all the
> channels at the same time when adding buffer support.
...
> +struct gpio_desc;
+ blank line to decouple generic declarations from local ones?
> struct ad5686_state;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-16 10:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 8:21 [PATCH v3 00/12] New features for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:21 ` [PATCH v3 01/12] dt-bindings: iio: dac: ad5696: add reset/ldac/gain support Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:32 ` sashiko-bot
2026-06-16 12:48 ` Rob Herring
2026-06-16 8:21 ` [PATCH v3 02/12] dt-bindings: iio: dac: ad5696: rework on power supplies Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 12:50 ` Rob Herring
2026-06-16 8:21 ` [PATCH v3 03/12] dt-bindings: iio: dac: ad5686: add reset/ldac/gain support Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:35 ` sashiko-bot
2026-06-16 8:21 ` [PATCH v3 04/12] dt-bindings: iio: dac: ad5686: rework on power supplies Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:33 ` sashiko-bot
2026-06-16 8:21 ` [PATCH v3 05/12] iio: dac: ad5686: add support for missing " Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 9:33 ` Joshua Crofts
2026-06-16 10:29 ` Andy Shevchenko
2026-06-16 8:21 ` [PATCH v3 06/12] iio: dac: ad5686: consume optional reset signal Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:30 ` sashiko-bot
2026-06-16 10:30 ` Andy Shevchenko
2026-06-16 8:21 ` [PATCH v3 07/12] iio: dac: ad5686: add ldac gpio Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 10:32 ` Andy Shevchenko [this message]
2026-06-16 8:21 ` [PATCH v3 08/12] iio: dac: ad5686: introduce sync operation Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:21 ` [PATCH v3 09/12] iio: dac: ad5686: implement new sync() op for the spi bus Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 10:35 ` Andy Shevchenko
2026-06-16 8:21 ` [PATCH v3 10/12] iio: dac: ad5686: add triggered buffer support Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 10:42 ` Andy Shevchenko
2026-06-16 8:21 ` [PATCH v3 11/12] iio: dac: ad5686: read_raw/write_raw: use guard(mutex)() Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 10:43 ` Andy Shevchenko
2026-06-16 10:50 ` Rodrigo Alencar
2026-06-16 10:52 ` Andy Shevchenko
2026-06-16 11:00 ` Rodrigo Alencar
2026-06-16 8:21 ` [PATCH v3 12/12] iio: dac: ad5686: add gain control support Rodrigo Alencar via B4 Relay
2026-06-16 8:21 ` Rodrigo Alencar
2026-06-16 8:34 ` sashiko-bot
2026-06-16 10:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajEmOCh8hdmfTHKW@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=michael.auchter@ni.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.