From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A7362F8EB1 for ; Tue, 16 Jun 2026 11:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607853; cv=none; b=Z4RX+qy868FjXqFo6+DqA2j66L7C1PvH3DWdnQjhH+yfOzmne30f2DdZR0RUKLCdQUANSP/gj/6FRd6lbmLBhaRBfS9L2yEubxVy3DTJ4ENzoU+h1WCUwhnJDJOQa0LuLEuo+nZh5UnUi4QREpNe5+qYgP79Xr/bNc5sZGeb52c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781607853; c=relaxed/simple; bh=XlPIUwQWeqadeAZDmEp0GLBep1xi7s+pwmjoBlJkbXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qfR+QYWhewZnCi25mUCvmD/RItwgdhm7NMXVFI22YpiEbacxQb9QtFdhR/Bdsl/fCl1kCYKLoc6ZBznYpG1XKuD1F8ATD1ryLCljVf72+Q8a3nYTY4WfvF35fw5PgzeONf53AUu52nSOKiQNzYVRqzP3v2QLfPMiHTy+tOKU1sQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1wZRaN-0007FY-00; Tue, 16 Jun 2026 13:04:03 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 08FFAC012A; Tue, 16 Jun 2026 13:01:36 +0200 (CEST) Date: Tue, 16 Jun 2026 13:01:36 +0200 From: Thomas Bogendoerfer To: Ethan Nelson-Moore Cc: linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP Message-ID: References: <20260610220124.97261-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260610220124.97261-1-enelsonmoore@gmail.com> On Wed, Jun 10, 2026 at 03:01:22PM -0700, Ethan Nelson-Moore wrote: > CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove > deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in > arch/mips/mm/c-r4k.c. Remove it. > > Discovered while searching for CONFIG_* symbols referenced in code but > not defined in any Kconfig file. > > Signed-off-by: Ethan Nelson-Moore > --- > arch/mips/mm/c-r4k.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c > index 10413b6f6662..d8aadd3dc057 100644 > --- a/arch/mips/mm/c-r4k.c > +++ b/arch/mips/mm/c-r4k.c > @@ -1757,11 +1757,6 @@ void r4k_cache_init(void) > build_clear_page(); > build_copy_page(); > > - /* > - * We want to run CMP kernels on core with and without coherent > - * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether > - * or not to flush caches. > - */ > local_r4k___flush_cache_all(NULL); > > coherency_setup(); > -- > 2.43.0 applied to mips-next Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]