From: Keith Busch <kbusch@kernel.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Vjaceslavs Klimovs <vklimovs@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
trnka@scm.com, Zdenek Kabelac <zdenek.kabelac@gmail.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: Repeatable, raid1+O_DIRECT, hang/warn
Date: Tue, 16 Jun 2026 10:05:29 -0600 [thread overview]
Message-ID: <ajF0Sc8AveHoiVBs@kbusch-mbp> (raw)
In-Reply-To: <27311df3-2c46-08be-825a-157ea906bdb2@redhat.com>
On Tue, Jun 16, 2026 at 05:55:13PM +0200, Mikulas Patocka wrote:
> I thought that reverting 5ff3f74e145a and re-introducing the alignment
> check in block/fops.c:blkdev_dio_invalid would fix it - but it wouldn't.
>
> The same problem existed even before 5ff3f74e145a, with the pvmove
> command.
Also before 5ff3f74e145a, you could still have devices that are
perfectly fine with dword aligned dma, so sub-sector vectors would have
passed the checks and gone through to dm-raid, which would have
miscounted the remaining.
> So, I think that the proper way to fix this is to teach dm-mirror/dm-io to
> deal with unaligned bio vectors and handle them properly.
The block layer already handles it, so I think just dispatch it and
check the bi_status is all the stacking drivers need to do.
next prev parent reply other threads:[~2026-06-16 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 17:57 Repeatable, raid1+O_DIRECT, hang/warn Dr. David Alan Gilbert
2026-06-15 10:34 ` Thorsten Leemhuis
2026-06-15 12:50 ` Dr. David Alan Gilbert
2026-06-15 23:16 ` Vjaceslavs Klimovs
2026-06-16 0:06 ` Keith Busch
2026-06-16 1:25 ` Vjaceslavs Klimovs
2026-06-16 12:57 ` Dr. David Alan Gilbert
2026-06-16 13:08 ` Dr. David Alan Gilbert
2026-06-16 14:04 ` Dr. David Alan Gilbert
2026-06-16 14:19 ` Keith Busch
2026-06-16 15:55 ` Dr. David Alan Gilbert
2026-06-16 15:55 ` Mikulas Patocka
2026-06-16 16:05 ` Keith Busch [this message]
2026-06-15 13:07 ` Zdenek Kabelac
2026-06-15 13:20 ` Dr. David Alan Gilbert
2026-06-15 15:20 ` Keith Busch
2026-06-15 15:35 ` Keith Busch
2026-06-15 16:37 ` Dr. David Alan Gilbert
2026-06-15 17:19 ` Keith Busch
2026-06-15 17:42 ` Dr. David Alan Gilbert
2026-06-15 19:25 ` Keith Busch
2026-06-15 20:09 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajF0Sc8AveHoiVBs@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mpatocka@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=trnka@scm.com \
--cc=vklimovs@gmail.com \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.