From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C84AD34E741 for ; Tue, 16 Jun 2026 12:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613815; cv=none; b=myWGqJeb5vUzjjf0rDNBKfegb8KaILrNHwyGiXBJOE6d2eGSLqE7++wVvATyOHAgHqopVNwKccxUBFJ0NITXfyDjGWOrFHUVveHPhYYE2wkKATlY/jw0o8Jj2oVl30m0ZMrD0dRzJbZ9CiEt23E7WyqWaUl5Lp7xuedBryugXtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613815; c=relaxed/simple; bh=NIZ5AB/YJJK+M4EayGLezVTYifS++JF2plQt5DG/qIE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TvSh69CLfJetOMCFoLFC86Zsn/3BCxkCC04rdpBtcyrHWac8d2jE4N4MKxkWXfensLn+2FFAE/MhFr8WqoccKYqmFkdEnkGV3Fb206WbH0Y5ifS8/RdbUIaShATqV3uLhmhu3IwAYQscEyp3Ha3lfxfAtf983czW8eORzqRmr3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LB1B8ubi; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LB1B8ubi" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-6870ad8072eso10102164a12.0 for ; Tue, 16 Jun 2026 05:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781613812; x=1782218612; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J8dPq5z6m1qmF3lfWoJltmjfpShaHtrEx/mXnH1vSGM=; b=LB1B8ubibMo32+gnyFogUJxQWtM99pr+m4lb1H4PL8SrR9eMg6s87gZcq61FqMVtH6 oXaPv6GtETWpuDzksBfenc79Abfh99i5911/DgFnbi44ab76Q3t53xPjD1m0eT6wwvZp 0cqQlsMSsCBPfeyob5e7KzM3O/OainPwfp0behd9cKhCeUGhkXT2QEnAu1LTSVsEh9yS iZ5jqtk0V7uyRYlXeZwf/2GvExMHIeCS6vr8bOuHUZYE50CIzEMZew9olb8b/A7ds6L9 C7xVd7h9vxGY2ZzxSXZRmShp/Ckeq3Jl6Dan3D7v4dx+/lA+w/72+iXvk5DccziTVp3Z 8JxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781613812; x=1782218612; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J8dPq5z6m1qmF3lfWoJltmjfpShaHtrEx/mXnH1vSGM=; b=rSIAVPBVugpzWi27zd1hJIkVHJW4br6BYfdI8/JH2WfbtL4yc3VxMF5dRWLtXbBrKz uwBlwLYflrCltxDq+Q+hmXt/0nOwMZikQDtqCyUq9jfvlC83Qm3klmplS3+0PM1G6GbB a2g35ASpB48SMVveIEiaB8PlS/ufX5gvpRgVQnxirIkAcEibFk/BJ6KRyEwioX3lgfpK fffpJIClDI38reTX6CCQHdLjXWj2/oUVnlRtkPmVpPXTlBiVKVgnndv+h1NqnjYZYp/L Bp+hj+KTN9DZ0a5LTmNVoOvFOdd5wvclLCsEdIrcAzXsXHI4dNKSGZSkR20kQXV2oC4R i9pA== X-Forwarded-Encrypted: i=1; AFNElJ9kFRANeF2THh9S1VzH9VGikIc30S/8wvGaE2OVTG4qKMrhemXGV8JPv4Tfpzrtudn0obVzsHWoEGyDwYY=@vger.kernel.org X-Gm-Message-State: AOJu0YyTzfGXektRTPOrNCF9oNz/w52NwrmAZyHq8YansNEAe3gAXc6x h+dAFMGg8P9E3MsxBrfZQCWJ2vmfxf9rYpTSJjIqQIPrUPR7oTOS4RXPNJ4nNcEosA== X-Gm-Gg: Acq92OH//oAWJoejBM6jgNaXVh63xqXxMh71dq2daDB4W/7nCB72Wg2gqrRXoMzt+pC +0EjFiee/wso9J7fx2S8qu3KblPP240nfQNVPDTiCjwJSUooPMizV0euZDEistTiXtv+hAyfMAq v3ujPuGHiSF96zpgTpjFx/A2wnVyvFABROWqSvcJMyWgp/N2RtQ7hFOZkgeevnjYF86LL1sz8Es tJNL/rfUHnNVJVLNv9ybPGFRBSTCNuFqBvPtwUi7x0UKVYN8jRdKdrnC5/yOYusiHD4EpsOJ5DG H/sPSPgjdx184KHXFX2sWtkeOGOQtS5IeaA3DQFqjkzYkfDOIPB56BoS7DOPSEn+d5TEoaNbQMx HgprkKb5PVDP1JtH6V3FOs/FE69/DCUpNyP5HRB1T0Dw1F18x6nBxhZD5M8jLo1kFpYyomUD/ek +InZ0/Ht23IrHsELLuWQoKW/b+8h0A1Lm4rI92kXBEYi2V3vd5uABGS/slEpDui+2otL5HbkRPY KorDA== X-Received: by 2002:aa7:c047:0:b0:68f:9fd9:435a with SMTP id 4fb4d7f45d1cf-69508237df1mr1454321a12.17.1781613811803; Tue, 16 Jun 2026 05:43:31 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6937938a524sm5008893a12.18.2026.06.16.05.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 05:43:31 -0700 (PDT) Date: Tue, 16 Jun 2026 13:43:27 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 2/7] KVM: arm64: Support FFA_NOTIFICATION_BITMAP_DESTROY in host handler Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-5-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616105417.2578670-5-sebastianene@google.com> On Tue, Jun 16, 2026 at 10:54:11AM +0000, Sebastian Ene wrote: > Allow FF-A notification bitmap destruction messages to be forwarded to > Trustzone from the host. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index b1e5f9ee86ef..49a43c38a931 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -688,7 +688,6 @@ static bool ffa_call_supported(u64 func_id) > case FFA_MEM_DONATE: > case FFA_MEM_RETRIEVE_REQ: > /* Optional notification interfaces added in FF-A 1.1 */ > - case FFA_NOTIFICATION_BITMAP_DESTROY: > case FFA_NOTIFICATION_BIND: > case FFA_NOTIFICATION_UNBIND: > case FFA_NOTIFICATION_SET: > @@ -876,10 +875,12 @@ static void do_ffa_part_get(struct arm_smccc_1_2_regs *res, > static void do_ffa_notif_bitmap(struct arm_smccc_1_2_regs *res, > struct kvm_cpu_context *ctxt) > { > + DECLARE_REG(u32, func_id, ctxt, 0); > DECLARE_REG(u32, vmid, ctxt, 1); > struct arm_smccc_1_2_regs *args; > + u32 idx_unused_args = func_id == FFA_NOTIFICATION_BITMAP_CREATE ? 3 : 2; Hum, this one applies weirdly too as it's been introduced in the previous patch already. > > - if (ffa_check_unused_args_sbz(ctxt, 3)) { > + if (ffa_check_unused_args_sbz(ctxt, idx_unused_args)) { > ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > return; > } > @@ -952,6 +953,7 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > do_ffa_part_get(&res, host_ctxt); > goto out_handled; > case FFA_NOTIFICATION_BITMAP_CREATE: > + case FFA_NOTIFICATION_BITMAP_DESTROY: > do_ffa_notif_bitmap(&res, host_ctxt); > goto out_handled; > } > -- > 2.54.0.1099.g489fc7bff1-goog >