From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E94F357D11 for ; Tue, 16 Jun 2026 12:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614631; cv=none; b=o+tLpU42BvJ617+p58pYDC/Nq4EgU83P0yvW6i1NSFPWfUhkSSqg9U08fx7zK5yVBiXgSSB3i/oGsPqPSLk80vQEbDSudBKwZvPEF/DyqOP6iv4joFAbDNeBBturOh+96dCPlLtTs2pz02iW7ow43GkZoyFoEe+3VSUonEE9YyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781614631; c=relaxed/simple; bh=1gJeLA1ceGuOa6thELNhy/k8icK8S4yN36ZY1cPSRpY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SlFiE3UjZ1/LasfYHQ/YYm3dhTBJLlgNlKcMUq0bvFKzwYGO43FQXwRsdzXNJ4xLzoW7z11B9nRyKFBMGFzXNwP+Z02q/RU6S0TRf8JTJ8w4/UvvCj8pvyC61kI6gEoT/LWgS/+ASZSa9T+sQaBLEGpLvFXD1GzPMrGa0vIjgtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=I3fDjrSA; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="I3fDjrSA" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4921e4dd62dso26723665e9.0 for ; Tue, 16 Jun 2026 05:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781614629; x=1782219429; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Mpy4FzFqtRj6SPrvV7X5m3vgs6nWYRoqA6az5Ccp918=; b=I3fDjrSAGZPNul/e3QVH03bTRzilS2TyUldT/MIM/xMud4TVO5ta36ELvxwvTDP7Lr wPlYXe0293CWXq/ybo5/nAWFsL13+iIl9aFUsi+d+zAVQMLG2vQWkaWls0eMg8/CGVF1 zdNxfCYuTZMESM+iByeDQW8zz6jU0m6tPXt/aDzz/m4mW5bfsu+XQKlZCRS/ZNzYSvd0 oTrPyztaKH3it43YhwGbTASmIcmxnfyFY6iIWAeSMXPffFsxxNzyh2LCdFmByflCShhZ ZO0Ewb1GgvuWXp9okW/JmT4/GHcfgGuIrV+1XL4X7NplUy3mqCJ2zdJjGXeNiLIpa8VF 9dBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781614629; x=1782219429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mpy4FzFqtRj6SPrvV7X5m3vgs6nWYRoqA6az5Ccp918=; b=m8AcRFoEsnvQaw5GvRlGRpNvBLrZNzYM7LwpjvgCcILg5VTSp3wQEw/I54awBomF4Z DhaPcKArVOGudOPMvN7hedWXfuF77OB8P4h05MsXqQWOyw0LgT88JFlZ97JXOGefd9so xS04kcDq964frk3rU587vMNf7EyGrD3JBlnG1gyGGJi2WGu3msMOTCY4OvHgSjlcU4Pu nZEauuHADFmIZcgLi5tSs81b4h91TmgRW67VRUWlr+uEW9flfGxGh3poUgso+vjLbB3R RKdd16/H2mQ94M1pwUPn5Sd2a4HABvv30xOXwyn0ktsN6cfUTu7CfKaeHxoRINdFkajJ Qo7Q== X-Forwarded-Encrypted: i=1; AFNElJ8DnShfD9YKYhD3VodxCvvn/VnLBK7Ill1jEje1Wzo6FNwqC7z/K6uJx3RO2e0CENpdL4DicXZZNvvXDW0=@vger.kernel.org X-Gm-Message-State: AOJu0YxbERo7pch8W7OtL7mpzle528E28MNLSAhet5f+NMDP3iV9fz66 PdxJ4WPqDdztqkCuMu0100V0NhV2G2TG/S1Ul/p+0LcDMVmP6l/UZkASpWT/d9iK0Qk= X-Gm-Gg: Acq92OHnAbLhoLgNrt0eACXlrhz7g3NEp8J4UXHhRi2RmgqH6GCqnP6j9Q3aYPjJJML 4XMVYZa4bfpiBREOrcOcuwyCAR3JEaxhWfe0r1WMmMYgkR/r6tsZDZ0yApCw47HQuKgy7yxPJP3 QsRHW20woHmqT61C6Nx+50Kw6YZKlC7pab7nBVyVh27bhuGzirrzQSnP8z2O63ilo7SAeyTr7k9 0B4nvOI3dMpux10wBjiOaL17gHJ5KbHEekZXmuMX0RrcZiaYsQEO2XDXxB/E5P3ew4MdDbFAv4w BLnNsUuPMwstgU8p8ekuRzTDTVxL0A+H6aSaiUbc0TnhwK2PxM5chNYqSS0Lexe9Z+hg0CCGfHQ VtZrQmF2n1Gv/NnzKC/YqP/7aEYFwy9RNBwQa4VQM7dveMma24n4x7IAUJt7JpJI6f/rtdLiZoG k5T8INAvxGSAN0fqGkvgbnSXsqbA== X-Received: by 2002:a05:600c:4e45:b0:490:5000:917 with SMTP id 5b1f17b1804b1-4922fab2489mr48138855e9.1.1781614628730; Tue, 16 Jun 2026 05:57:08 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490ea94f5b0sm302285105e9.1.2026.06.16.05.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 05:57:08 -0700 (PDT) Date: Tue, 16 Jun 2026 14:57:06 +0200 From: Petr Mladek To: Breno Leitao Cc: Tejun Heo , Lai Jiangshan , Andrew Morton , linux-kernel@vger.kernel.org, Omar Sandoval , Song Liu , Danielle Costantino , kasan-dev@googlegroups.com, kernel-team@meta.com Subject: Re: [PATCH v2 4/5] workqueue: Show all busy workers in stall diagnostics Message-ID: References: <20260305-wqstall_start-at-v2-4-b60863ee0899@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2026-06-16 05:44:12, Breno Leitao wrote: > Hello Petr, > > On Tue, Jun 16, 2026 at 02:38:11PM +0200, Petr Mladek wrote: > > On Thu 2026-06-11 07:50:04, Breno Leitao wrote: > > > > > > Unfortunately I didn't get the other pr_info(), because of console settings, > > > but, I can say the following from this issue and previous code: > > > > > > 1) in show_cpu_pool_hog, found_running variable is set to false. > > > 2) hash_for_each() never found any running task > > > 3) The following code was trigger and was very helpful: > > > > > > if (!found_running) > > > trigger_single_cpu_backtrace(cpu); > > > > Great. So, the extra complexity was worth it. Should I clean it and > > send a proper patch? Or would you like to do so? > > I am happy to do so. I had a chat with tejun yesterday, and I got the > impression he is OK with this patch as well. Great! > > Also I wonder whether it would make sense to revert the commit > > 8823eaef45da7f ("workqueue: Show all busy workers in stall > > diagnostics"). > > This patch undo that change already. Would you like to see a full revert > or, are you OK with this patch reverting that behaviour? Maybe with > a fixes: tag? I do not mind how exactly it is done. Reworking the behavior is perfectly fine. And the fixes tag would make sense when it was not a full revert. Best Regards, Petr