From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E327136493F for ; Tue, 16 Jun 2026 13:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781615182; cv=none; b=XcK09NMhUWRqSrLmHw+aVDAoJWGLD2nF+dUuo+x+NAmcUoujnCpfV4Mp05OwkONUFPQ/og9/6r0bADAlUHGj2gZJahg7C62hPagsofPU8JeWMiPhl4rWDMv5rqfUeUDeI8/ehM+d3vp1NiFx6W00ovorsdrrzO/Mi1eJKE9ywyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781615182; c=relaxed/simple; bh=1LzCSrcwoDPbXsWcbplaeIlKCaf6O9hUMjJNmMKJDKU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyXBz11wGEIPzqKaoagzP7XpX8je7for53/XmEZg7dqY85Ir6PNkzMeW4Srq/My9yEyK/ftm6Eb+1LUzx9BzCAm54IxHzjc4ZN4ulqWJzh6nR/MZlW8WPZeAzB6+jdZfJCp5XlNv7L0o55XDNot/2pVa6E4BOHVbMPel2bL9DO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YUNXgLGP; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YUNXgLGP" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490be29c1c5so49837035e9.2 for ; Tue, 16 Jun 2026 06:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781615179; x=1782219979; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QnzW1lCgZUE9U3suyJwPj7ScgyD/az5VlYfMmVApb6U=; b=YUNXgLGPm0rIwVBUaRvlDNMGetlhs8ThvmGY6ONtG7mvXGOCUZNEl1GzSZW2oYj2Zr T4JcG81BEtudRDQpo5NPtSVWgk7XSw3woAbaqSRtbXZqCP5xuX0T2Wa3+rIZIwXwQG9v U1j0eWlqS6hzNbBaYTnka7qoGTjD10sdSTtQ44ptwcu1i6VLYTbyRqQtp/SDYXXIc94s 49l4ifQo0yD9f5h9FXO/JxA9TqebWtqqbhwTFn8N2M5w9UJkwEnmAf2kB1aD1IkrF+gw sdwc91eHNK9/mDQafqM7T5RmKZ+pxnD1MLPwpnqpLWIrzEZA4bhMcvZDZm9aP+U5ClH7 +d7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781615179; x=1782219979; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QnzW1lCgZUE9U3suyJwPj7ScgyD/az5VlYfMmVApb6U=; b=qhROTawHinjLMQ3MYzMpfHmlfpDizteoxqEe1HA21bHiwRRxfU2ajQA8rofjUlYIrb 0zp7erwQZpz3EQCa4UzYdUjRqFyEa7sSjjnwjueFVvF0DtgOUXY6T+PU6cIpMKsjbSw+ K5JIu1jnezGH9395VmJhTOTN0FFRYo2Kv4O5DHQFJCl9OERNnJDvioQE9vOwhuF7v5RM uWPREmLqXYdF6IImLZ+9cTzsMILH+WEri1B8RRkj46DHe0/Xnne2z5ZaAZ77GgRmSG+3 u2DxzfpKi7e7gTGy+R68rgh7++Px+TmWbxB5XMv5DVTKkpr2PkIs+8C2n5pe75VjpT9T xPxg== X-Forwarded-Encrypted: i=1; AFNElJ9xl5OZi7+SC4D4YniuUzZ1clpUI263PSvzDySfDf4yGJMbUVw/NG1oMhCZf/oyg67vYPlwW1BD53bCBVE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2gxyGWF0eoSujzDfd1ckVlcdjRHN0EPQ9j5ZmRAZMfZq+p9zR ak3HQoeCCQwS2wdl/FeIuApJ7cyFyJ+vPYGYLhixhjxtb5B4ZdydpfZSP5sNTufBuQ== X-Gm-Gg: Acq92OGMfILJzqJvn4rGgIrpeRQC12c44yMfPPoFX4QLFG6BdSc5wYxMNj52ux+Mw6j AajL8f8GVU59NTLGDo35P5as4A+BmnE0wfUwJL5UQIquq7RBy+MoXPgLi3/wgRFsJGu+OHhzS2s FveHbXJtwPakeu2S3rSwjgcIPEFHDSAxkL7jpEGDUpF0URosKoBXVBhGruNfXHNxCpILMbPgF+u lmZkCst1HqFfu60I3iS4/7+aoApuU13ajWrC3cPO/uw5X1a6pRCaDTEiqNceYX3+YVCYCT5nBaH oxoW11bhJV+yzU0UFw7AJ30CL7xjGnqfSls8nDNGf+18B8scZzQWFzkquwDm4AtRmXLH5MHk2Qa /1I+vM6RKSMet9jsDcA4wtgkGMfyvLsIowKetXiulg7uwSi9IANdq2A7jfwvZD780cXnN2SNZDk dJSMUehCNfRLUbe7UjI0giGhva5HqW+TOBmn/heZ2hXjHjXYCUkqaE2r6JcA5Dh22GTIg= X-Received: by 2002:a05:600c:46d1:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-4922ff7bc90mr57743445e9.16.1781615178301; Tue, 16 Jun 2026 06:06:18 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4922fa47ce3sm88174375e9.6.2026.06.16.06.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 06:06:16 -0700 (PDT) Date: Tue, 16 Jun 2026 14:06:12 +0100 From: Vincent Donnefort To: Sebastian Ene Cc: catalin.marinas@arm.com, maz@kernel.org, oupton@kernel.org, will@kernel.org, joey.gouly@arm.com, korneld@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, mrigendra.chaubey@gmail.com, perlarsen@google.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 3/7] KVM: arm64: Support FFA_NOTIFICATION_BIND in host handler Message-ID: References: <20260616105417.2578670-1-sebastianene@google.com> <20260616105417.2578670-6-sebastianene@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616105417.2578670-6-sebastianene@google.com> On Tue, Jun 16, 2026 at 10:54:12AM +0000, Sebastian Ene wrote: > Verify the arguments of the FF-A notification bind call and forward the > message to Trustzone. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/nvhe/ffa.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c > index dc7496ec295f..3d8ed829f558 100644 > --- a/arch/arm64/kvm/hyp/nvhe/ffa.c > +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c > @@ -42,6 +42,8 @@ > */ > #define HOST_FFA_ID 0 > > +#define FFA_NOTIF_SENDER_ENDP_MASK GENMASK(31, 16) > + > /* > * A buffer to hold the maximum descriptor size we can see from the host, > * which is required when the SPMD returns a fragmented FFA_MEM_RETRIEVE_RESP > @@ -713,7 +715,6 @@ static bool ffa_call_supported(u64 func_id) > case FFA_MEM_DONATE: > case FFA_MEM_RETRIEVE_REQ: > /* Optional notification interfaces added in FF-A 1.1 */ > - case FFA_NOTIFICATION_BIND: > case FFA_NOTIFICATION_UNBIND: > case FFA_NOTIFICATION_SET: > case FFA_NOTIFICATION_GET: > @@ -929,6 +930,32 @@ static void do_ffa_notif_bitmap(struct arm_smccc_1_2_regs *res, > hyp_smccc_1_2_smc(args, res); > } > > +static void do_ffa_notif_bind(struct arm_smccc_1_2_regs *res, > + struct kvm_cpu_context *ctxt) > +{ > + DECLARE_REG(u32, endp_id, ctxt, 1); > + DECLARE_REG(u32, flags, ctxt, 2); > + struct arm_smccc_1_2_regs *args; > + > + if (ffa_check_unused_args_sbz(ctxt, 5)) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + if (FIELD_GET(FFA_NOTIF_SENDER_ENDP_MASK, endp_id) != HOST_FFA_ID) { "A Receiver uses the FFA_NOTIFICATION_BIND interface to bind one or more notifications to the Sender" Does that mean that if the host issues a FFA_NOTIFICATION_BIND it is the "Receiver" and not the "Sender"? (Same for unbind) > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + if (flags > 1) { > + ffa_to_smccc_res(res, FFA_RET_INVALID_PARAMETERS); > + return; > + } > + > + args = (void *)&ctxt->regs.regs[0]; > + hyp_smccc_1_2_smc(args, res); > +} > + > bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > { > struct arm_smccc_1_2_regs res; > @@ -991,6 +1018,9 @@ bool kvm_host_ffa_handler(struct kvm_cpu_context *host_ctxt, u32 func_id) > case FFA_NOTIFICATION_BITMAP_DESTROY: > do_ffa_notif_bitmap(&res, host_ctxt); > goto out_handled; > + case FFA_NOTIFICATION_BIND: > + do_ffa_notif_bind(&res, host_ctxt); > + goto out_handled; > } > > if (ffa_call_supported(func_id)) > -- > 2.54.0.1136.gdb2ca164c4-goog >