From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC466351C10 for ; Tue, 16 Jun 2026 13:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781618251; cv=none; b=Q++DewTPgYOgHXFAkCe5OVjA/Iqa8mjshj0y1pnNyf4uxgW+pN5pBeNff924Lz4+JWoYJRgQZkuuPcFhCdgeR4HHaPy30PL7lDbmw6/hi6B/2Z+rEQGJCHnuC9chsWkeieVoZwzvIeemYvxv2RyCGw7bJEMyK/aIXjfNHMt2Uho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781618251; c=relaxed/simple; bh=bxcq8XVvLvRb2QMDpderqYCbiU3FJspLGdpwGMLxIQY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M3IMs1L+aYzS4xVEf0UB+Qe38DSdKMkSFs/vxKXSQoTvqqkXF932QTEU4M2li/rf3ZRejofc7Gs8N8O++C9hmg+K0uC0ptpLM19iTQzYb2ioypc12aJULFBWaZuZg8NWDRhIouzKtzsfUvqjTsqjs5Jo5a7idjf5SpSSQWUNS+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=XsIQCVjV; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="XsIQCVjV" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8cebfb15413so49779766d6.0 for ; Tue, 16 Jun 2026 06:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1781618249; x=1782223049; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iYWyDql/Cg87tBDufvcG34GqN5pKohUk/nA1HD30SzE=; b=XsIQCVjVsBDoi2tQGAZPcv5MfUsnmEkU9Sj195Z6frpntF0lPO/88Gp5P4fkmegwwp q6os0tny6sPN3yJtLZVAEVFqKR6RQMxEH0cVRGxs0mZj7pmd9mMvXZYBrWBgi/fPHhVc nUNzgmhvTGyjnlz1NCEmWusiKU78ZZ6x8CMn7HiXHUKK8SgilGKyelk3rI3ArYowpnCc MWvfbcqWK1iAp46E/EPSmeW5lxExG1BOMrIfSaZ2+tz8nlwtw4AS1n9RpDsA+9hjATgo Fo2zJSnS/k71/iHIojx6S2PcqvP18iWyIHLYubi/iel8b4VXC1+0n3n75cyWMg25kbMl 9hpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781618249; x=1782223049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iYWyDql/Cg87tBDufvcG34GqN5pKohUk/nA1HD30SzE=; b=rp0CirK1NiigOBvPgIwdBlpE8Vd9sHqGLEL2eSFbgc+RpsQTV08Neid30QUCZBBrq1 kDt4VPxioUYHfPl6AY4PXDVIBMnlWnxpHis5915J2fa6FPtIXrt8OK6KK9ufKtLutKfs 7XPZkWtsTdkvexvvzPH5cLtjmo+egsHe87xr53REOuWApn1241VDdVP14bYeWZcrcMa+ K1v7+AyrsdBR4xhVLO3JJAaVZ74WSr3X15DvyJAtVPXY1MT/nD0RLmSGNvWYZsiZ/vSU MtWCQJSR0omcp7SKTEEfcqKGayxWsthDZFxC19bu7S70NTFxpPUDo6Y9On2GgUrJMpM4 Ve/A== X-Forwarded-Encrypted: i=1; AFNElJ94LeWhBYzDQ4Qw0H7xu7SdSccn7rDr3ohJkwJ0OfQjfSgDuMBsMBAtaDw8XTAk6Lp42eP3aCQKjNx5vy4=@vger.kernel.org X-Gm-Message-State: AOJu0YxaHViGgybD70Xfoi1nmLVf6boLzWPuLwCdiIsf+2LGGJTmMH8j IaoVYOqy09NB/Lp6ehgUjfSf1rluoSlXrBmg4TIF33RUx1Pnoe0rmgtT/Mzlc+7YXEQ= X-Gm-Gg: Acq92OG03P2DKCNQHKaL57fwP7PP4q/r1gzYmTbm/W2baOIhlYW2J7RWvNaj2GgIrD0 9YBEP1/ntXrJScTg+4miWS/6JqmA5Zt69j/XcpiWCbRgqH1r39B1eMdHhpP83V1/5SdvMLLYM96 9TpXzu5bXSFv7r4XnTQseciSxNdVICDDPKLwqfmXzA21lddsBQKQNZHNypzQ6uMy06LSmSTaCRR MG8UYdQu69wjmfZboP/YY/orEablLwIJBbV9ICY6CWciZRxFxdPZv+4/myRCZ15JnDLcSmk0Wyd WQu1ZXfmu8HPiw5RywCk8tGk/0FNy772ieVDDkeaY0BhwZWJbM30z8/v6K3KuDxJlakd2YVUGay HuknMh56wLsreqKwp3QOX6+lwyw7an8OAMmvdukhu4ZhkyD/5yrx6FkIx38AmMipdsGqmTFmfSO Q+e244i6eFaZe3z6HSnkNj6LgBIqCWdr4= X-Received: by 2002:a05:6214:5008:b0:8cc:2a92:11b6 with SMTP id 6a1803df08f44-8d44c5acd58mr247438456d6.9.1781618248553; Tue, 16 Jun 2026 06:57:28 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F ([2620:10d:c091:500::3:437e]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f1fb4bdasm32959256d6.20.2026.06.16.06.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 06:57:28 -0700 (PDT) Date: Tue, 16 Jun 2026 09:57:26 -0400 From: Gregory Price To: "David Hildenbrand (Arm)" Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, hannes@cmpxchg.org, surenb@google.com, peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com Subject: Re: [RFC PATCH 2/2] virtio-balloon: add stats push mode Message-ID: References: <20260513165006.2790857-1-gourry@gourry.net> <20260513165006.2790857-3-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 16, 2026 at 02:33:43PM +0200, David Hildenbrand (Arm) wrote: > On 5/13/26 18:50, Gregory Price wrote: > > > > The pull model remains available and is the default. > > I don't quite see the big benefit here, really: either it's a timer in the > hypervisor or a timer in the VM. A slow VM will, in either model, delay the > update of stats. > > If you need some "liveness detection", is virtio-balloon stats updates really > the right mechanism? > > I don't quite understand the "Latency-sensitive consumers" problem. If the VM is > slow, it is slow and will mess with latency-sensitive consumers in either way? > Latency sensitive here should probably be defined as "Does not like blocking operations". This was prototyped in the context of cloud-hypervisor [1] and an orchestrator trying poll 1000 VMs on a single machine for stats. The poller couldn't determine the difference between "guest is slow" and "guest is hung" and so had to block on the operation (I didn't see how to solve this async). Similarly, having a single thread just round-robin poll the VMs is bluntly inefficient and provides poor guarantees about the liveliness of the stats (a couple slow guests can cause other guests' stats to become stale for 10s of seconds). Definitely an RFC here because I'm not sure if I was missing something that might help me solve the problem. ~Gregory [1] https://github.com/cloud-hypervisor/cloud-hypervisor