From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311A52D2488 for ; Wed, 17 Jun 2026 03:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781667683; cv=none; b=NFXXnYU6hfZzUq+Md19kQjvdtKA/OEI0oBavfg0KsgW8GIE/e3+SkvuIgpg6bInAAmBM4hc32l14/MlOtUnPu6cj7efP0qf0tD729eQF7fSJLfG7w0fTnNJoEnUFHis62cdw2OVThgzFlNCp++h7nHIcH1r05+aVFWjWjxuwW5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781667683; c=relaxed/simple; bh=ejKlcD3ojZM/P1bfToXGF2SV9BXp3bkfJzxqQ6vqRMw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s/nntRLNndV9VDDdH3WKut3UfRjOOeXencNcvx12p40GrjDgiHa1uzAHik1eVcYjyHmvEDBdJYo8+SYC008pwu0FD3R7zHRUqjgZSWHzmOgFe0mw1yotPmivTRk+mZpw07lhwNVUAWHSDCaP3g/SvdXYt+R6ANbartHt7ULKoH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Tl9xDgmK; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tl9xDgmK" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36da8439078so4569728a91.2 for ; Tue, 16 Jun 2026 20:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1781667680; x=1782272480; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gix0nvCYK1OhR2Kcuql53IhC6b91d4kE/6Woyx2T6JY=; b=Tl9xDgmKmasCIwxyfeEMKDiN5nHV2Ssko8Nh+INXPud4chIGoKDnKCtH9mm8R8Ler9 qXtWDwNF46vYWsQTSzqp3Wjffk8XQKrIiXpS00ANsxqQwxKdN0xX+8rGJsvVAqDEll1M zYM3Uic/IRVymEVLeG/b3UBiLeB/b+OTire1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781667680; x=1782272480; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gix0nvCYK1OhR2Kcuql53IhC6b91d4kE/6Woyx2T6JY=; b=SbP8E6u07IL6uksreb+OrSZPg40ZEr3bF4EStODgviSqsIBShAWblJbm34nXdQgI50 veEsciC+vUYut1zfT5CLMxBSBzcwbZvT36ReOiVsUXqm3brm7nzAG3nMtEYrUTSef5TM ZApwKVshgr9f1oFNOY1bCNTlWLC5paeoC/Au/nYsyEuRZX2yWn8jYaXcA+ATYfqDe8cl 98RySIp/8zQrWhjmNwnhVe8+OGoU6w83rjYVtaJKWoRIP1YNP0JZlni6FnYhxLTm8S/9 BNB3SsNlp0D7d8Ip15pHYkBLfKq7fJ6UA9ijWGZg3HJCv6khQVxYggrC/9lWsJpjojvu 9wgA== X-Forwarded-Encrypted: i=1; AFNElJ8ywFQqql5H8hxOquBN7zFCRgX4ZgqAAqoYn4shxYMTZ9UNCyGYfNSX6gqRF00UTwSzu2/fohCM2bgChNiqX8M=@vger.kernel.org X-Gm-Message-State: AOJu0Ywax0VVPLkVCgLUMZnExorryBXD+ZoVO/JdkivcMCe9u7Tg3VBo rEpF9QxVe5u236YaeGEu06O4YeuuG8muy6+Sw2WEQz6raGGGcnNYMg/dUAAAI/wCqw== X-Gm-Gg: AfdE7cnLtPV2axx2zS61F+E1F4FW57XtS5G/izuGY/4S4cEnG1mpmbtTub6HEdiAcu+ iJlzkq/C2Cql+/8Q6/0fxio23RMlotePEy4awVEs1ESCgYJVpbAl4nId8Os6djYGD3Y4juqM1Wi i2MsQjmUPeRZ+5rEifD08apANr0cIpMmB/yjkGAWNk6HKisewN+luSIEnFW7deX3jVTkl5o6UZB D4Yy8kmDQaPdP8eVKF7Ybo2KH3UNRCFGm8qc2HCjUeuyEUIug1tRJiwGbyfYd8tgOce1bm9QqiQ hhLpMlVtTCuPTC/sXuWBqvc6BSxTYCQXLff/d0M2KGya8XJKDbyOYmenfPU538Oz6yfvS3GnICH Y3jQ5vnZfIGc7KCJ/yOY3C3XisD5PviR4nl2cuwmMw1/fbvzofxUz4a9+OQ1LjfvYmymhAfyf0R XJhlN/aMNXRVFnQ+WTYLTpSQVt3a8AjJ5gB0nkIHeZctGq6NLUECM= X-Received: by 2002:a17:90b:5107:b0:36a:a16b:5f65 with SMTP id 98e67ed59e1d1-37c9372863cmr2233719a91.11.1781667680584; Tue, 16 Jun 2026 20:41:20 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:a0b:fabb:5b62:b85b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521d8e7bsm4513705a91.5.2026.06.16.20.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 20:41:20 -0700 (PDT) Date: Wed, 17 Jun 2026 12:41:15 +0900 From: Sergey Senozhatsky To: Sean Wang Cc: Sergey Senozhatsky , Marcel Holtmann , Luiz Augusto von Dentz , Mark-yw Chen , Sean Wang , Tomasz Figa , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v2 3/3] Bluetooth: btmtksdio: call cancel_work_sync() outside of host lock scope Message-ID: References: <20260616111224.152140-1-senozhatsky@chromium.org> <20260616111224.152140-4-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (26/06/16 19:56), Sean Wang wrote: > The patch looks good to me. Inspired by your patch, > do you think should we add another patch to keep txrx_work out of the > reset window by rejecting TX during reset, > ignoring reset-time interrupts, and making queued workers exit early? I honestly don't know, it's hard for to me judge as I'm not all that familiar with the code. To make things more complex, I don't think we see any crashes on reset path. My personal preference maybe would be to keep things the way they are? > Some code like: > > --- a/drivers/bluetooth/btmtksdio.c > +++ b/drivers/bluetooth/btmtksdio.c > @@ -567,6 +567,8 @@ static void btmtksdio_txrx_work(struct work_struct *work) > pm_runtime_get_sync(bdev->dev); > > sdio_claim_host(bdev->func); > + if (test_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state)) > + goto out; A nit: I think you can test_bit() outside of host lock scope. Other than that I'm afraid I cannot be of much help here. > /* Disable interrupt */ > sdio_writel(bdev->func, C_INT_EN_CLR, MTK_REG_CHLPCR, NULL); > @@ -628,6 +630,7 @@ static void btmtksdio_txrx_work(struct work_struct *work) > !test_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state)) > sdio_writel(bdev->func, C_INT_EN_SET, MTK_REG_CHLPCR, NULL); > > +out: > sdio_release_host(bdev->func); > > pm_runtime_put_autosuspend(bdev->dev); > @@ -646,6 +649,9 @@ static void btmtksdio_interrupt(struct sdio_func *func) > /* Disable interrupt */ > sdio_writel(bdev->func, C_INT_EN_CLR, MTK_REG_CHLPCR, NULL); > > + if (test_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state)) > + return; > + > schedule_work(&bdev->txrx_work); > } > > @@ -1250,6 +1256,9 @@ static int btmtksdio_send_frame(struct hci_dev > *hdev, struct sk_buff *skb) > { > struct btmtksdio_dev *bdev = hci_get_drvdata(hdev); > > + if (test_bit(BTMTKSDIO_HW_RESET_ACTIVE, &bdev->tx_state)) > + return -EBUSY; > + > switch (hci_skb_pkt_type(skb)) { > case HCI_COMMAND_PKT: > hdev->stat.cmd_tx++;