From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FFFC3F6606 for ; Wed, 17 Jun 2026 12:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699123; cv=none; b=ETeOC2WPAUsAzaalzkZ+w/tlnRDV4+e+Dm0Hv/pR7vMMXV9KgXbvLKzPF1yvEJDNz0Fjgmp8+zfEkoR7r/qlHc2IcLDsdG+t9MIngQjzS8awfnZwle7AZIW2XC3s8QQRwECV2t3+NTx2bDduKdyfWJPddO3n/MopyEfstg7rCH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699123; c=relaxed/simple; bh=1yJxZq3tkF0bDvOTRpsnisysrPdGXlXB3E4O1ntJTHg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nGV9+NCaw/HketluucSocACAxX2XCt56TK27fuezK1jjJGYmIFmhmlmYpzocilyEX2D0Vgmo1ykafBjyHjKHoOYt0b78ej97kFoZ1DSBTlKeOZYYH0TEbal9nUyVrI0CYiyh/XFIPoXKfJZlNPJA1tcTHD/GHdu9L4iiVE3Hz7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=al3ub1Aa; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="al3ub1Aa" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-491b390f9e9so48487965e9.0 for ; Wed, 17 Jun 2026 05:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781699118; x=1782303918; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1yJxZq3tkF0bDvOTRpsnisysrPdGXlXB3E4O1ntJTHg=; b=al3ub1Aa+DrvVM6gEt0RcABwn0dqsOPQ81H94gI0H3nh9GyialPhTFd5qEOsHPTU74 JZmfLGrLJId7/F6PaUqLQsYMvvDNOAFxc1WEsHIgjSebRtKiTN0Scfw0Sn+9EM6WIB0E LQkQt5nVWCa5gPYxoC/ydL597UQHpBGfB138pdRMJZpPKh3l4zwaqprm3n9aXRxYkH+T 4toaU5y3NsvTO8nte6GpVestg4GkoVJOvxrFGQ+Ymwshgx7euPt1pIez3OShMK0r+kto j8zFGVxW986Vd43ctXl7JdQ+TPrTg7LGkpVXEPwMGKJ18Nb4bE61GZNqPjlKP8IkWlGz o/jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781699118; x=1782303918; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1yJxZq3tkF0bDvOTRpsnisysrPdGXlXB3E4O1ntJTHg=; b=CZ+AttkfLioHsBkv+pEK75ztH8bTvCBf4h2+WgRkeYgpNTX3/rQm8RC4kcdKre7jXA QmrqV8gR13r1lxFfZNfWfzBg3fvGWnUdv/2328BQ8BN+prmgy035VOsyEDKM9hBEQ8s/ LmnYW3sLjZQHAXMJT1LzAIUWXX7V8hHE2FklMJy5a9fukNLttBxTd3f2w6ZgWpZlyvYm 9gGIKR0p05nh1BEaSLU3BN3rpPcwVktEL5FD/5YPAr6QmfZAIHToX6O9KoX0L8ixJ2o/ Q394qyNP08qTHtVQGcXwnjfKvkLMFOc79otfhe3eYH1QQTcWW7VPEUDJYoMJlOPrZelA 2qDg== X-Forwarded-Encrypted: i=1; AFNElJ/783w8Vhip/lXF2YloY70ax98d8CQr68UpOJ81N/JZMA19+A8W9thh9s/Nt6X05DIZiOuJLkw9PZvH75c=@vger.kernel.org X-Gm-Message-State: AOJu0YyyMxZ7NjhCscQEa8iTc1ny4qcR1+i8LKROu5AslKUV6xQPJ/0L BDwqPDcXEAyvVaqWBTvxd2KlOrvdH8rH74QuVVjTgvT1HkUHikdTjdkQWkjrz/veaho= X-Gm-Gg: Acq92OGIAoqPcLyA9B3fNJtP2GBDBYuGmO7ZDySa2eeeKKfW4eEYE7Cppziam7hQCil efDddw4b5Ts3RbxC47eRmTEJXRjcwiRPD8igEoTobv0U4Hovgp3+JoF20YMA9y++tEo4AqP7IZC KA+Sb9Bpy8QFAOZeC8oQu00Dqg7koKGlWIJlVknjNSKAviWdTO94RxQ2ndsCDf2uaWT8HBAQED0 Ixe9dO0MBE0rVOXwbHUGF9ET3FHd8mTsCN84LP41q1PLZNSrFfr0x9UeuH71P6kLFHgVHcLbeVA 0xxD1StfYsbd8uWd3Oa/F0OvLpV611hJ3qxVfOpHZDnM7zvtnZnPp0lIsSyMWxQO8ZGzdvOBCka xVtbTXFMPIpnDBS9BCyIjmTZlFCfc5Qs79N2avzUqHb0jIyX3AvvbkUwmiBwErhL5/WVArbL8eq 9lRJwjJ+UZ7Ro6AHccMA== X-Received: by 2002:a05:600c:c0d2:10b0:490:e5c1:b8c6 with SMTP id 5b1f17b1804b1-492333a16c3mr51513355e9.8.1781699117684; Wed, 17 Jun 2026 05:25:17 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49230a9a399sm140088385e9.14.2026.06.17.05.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 05:25:16 -0700 (PDT) Date: Wed, 17 Jun 2026 14:25:14 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Li Wang Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org, jiayuan.chen@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Muchun Song , Shakeel Butt Subject: Re: [PATCH v7 3/8] selftests/cgroup: use runtime page size for zswpin check Message-ID: References: <20260424040059.12940-1-li.wang@linux.dev> <20260424040059.12940-4-li.wang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fw3psxfcciuimhrk" Content-Disposition: inline In-Reply-To: <20260424040059.12940-4-li.wang@linux.dev> --fw3psxfcciuimhrk Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 3/8] selftests/cgroup: use runtime page size for zswpin check MIME-Version: 1.0 On Fri, Apr 24, 2026 at 12:00:54PM +0800, Li Wang wrote: > test_zswapin compares memory.stat:zswpin (counted in pages) against a > byte threshold converted with PAGE_SIZE. In cgroup selftests, PAGE_SIZE > is hardcoded to 4096, which makes the conversion wrong on systems with > non-4K base pages (e.g. 64K). >=20 > As a result, the test requires too many pages to pass and fails > spuriously even when zswap is working. >=20 > Use sysconf(_SC_PAGESIZE) for the zswpin threshold conversion so the > check matches the actual system page size. >=20 > Signed-off-by: Li Wang > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Michal Koutn=FD > Cc: Muchun Song > Cc: Nhat Pham > Cc: Tejun Heo > Cc: Roman Gushchin > Cc: Shakeel Butt > Reviewed-by: Yosry Ahmed > Acked-by: Nhat Pham > Reviewed-by: Michal Koutn=FD --fw3psxfcciuimhrk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCajKSJBsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AifigEAsoKP16b+0Ymtb3KGVhyI va7ay0/8bjusHJQkcZqNicIA/1Wml5S9Nn0nE+3XPCz+4d6nCaUqIpGdRKFGT56w XSAD =y8NZ -----END PGP SIGNATURE----- --fw3psxfcciuimhrk--