All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Oleksii Kurochko <oleksii.kurochko@gmail.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Juergen Gross <jgross@suse.com>,
	George Dunlap <gwd@xenproject.org>
Subject: Re: [PATCH v2 for-4.22? 5/7] domctl: correct return value of XEN_DOMCTL_[gs]etvcpuaffinity
Date: Wed, 17 Jun 2026 13:45:36 +0200	[thread overview]
Message-ID: <ajKI4N-z0omDXc4q@macbook.local> (raw)
In-Reply-To: <f223d669-d61f-4110-88aa-e2e71bee1f14@suse.com>

On Wed, Jun 17, 2026 at 11:29:09AM +0200, Jan Beulich wrote:
> cpumask_to_xenctl_bitmap() may return errors. Clearing the error indicator
> of an earlier such call by a (successful) later call is misleading the
> caller. For "set", keep setting soft affinity if the hard affinity copy-
> back fails; only accumulate respective errors.
> 
> While fiddling with return values, also drop a redundant clearing of
> "ret". This eliminates a Misra C:2012 rule 2.2 ("There shall be no dead
> code") violation.
> 
> Fixes: 6e4ecc6d5884 ("sched: DOMCTL_*vcpuaffinity works with hard and soft affinity")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


  parent reply	other threads:[~2026-06-17 11:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17  9:24 [PATCH v2 for-4.22? 0/7] domctl: XSA-492 and -491 follow-on Jan Beulich
2026-06-17  9:26 ` [PATCH v2 for-4.22? 1/7] sched: introduce specialization of "running only" vcpu_runstate_get() Jan Beulich
2026-06-17  9:58   ` Oleksii Kurochko
2026-06-17  9:26 ` [PATCH v2 for-4.22? 2/7] domctl: handle XEN_DOMCTL_getvcpuinfo without acquiring domctl lock Jan Beulich
2026-06-17  9:27 ` [PATCH v2 for-4.22? 3/7] domctl: move early special casing of XEN_DOMCTL_shadow_op Jan Beulich
2026-06-17 11:20   ` Roger Pau Monné
2026-06-17 13:11   ` Oleksii Kurochko
2026-06-17  9:27 ` [PATCH v2 for-4.22? 4/7] domctl: restrict permission check for XEN_DOMCTL_memory_mapping's remove form Jan Beulich
2026-06-17 11:37   ` Roger Pau Monné
2026-06-17 11:47     ` Jan Beulich
2026-06-17 11:57   ` Oleksii Kurochko
2026-06-17  9:29 ` [PATCH v2 for-4.22? 5/7] domctl: correct return value of XEN_DOMCTL_[gs]etvcpuaffinity Jan Beulich
2026-06-17 11:08   ` Jürgen Groß
2026-06-17 11:45   ` Roger Pau Monné [this message]
2026-06-17  9:30 ` [PATCH v2 for-4.22? 6/7] x86/domctl: don't imply I/O port permissions from I/O port mapping Jan Beulich
2026-06-17 11:53   ` Oleksii Kurochko
2026-06-17 15:18   ` Roger Pau Monné
2026-06-17  9:30 ` [PATCH v2 for-4.22? 7/7] x86/HVM: more checking for XEN_DOMCTL_ioport_mapping Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajKI4N-z0omDXc4q@macbook.local \
    --to=roger.pau@citrix.com \
    --cc=dfaggioli@suse.com \
    --cc=gwd@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.