From: Michal Hocko <mhocko@suse.com>
To: Kaitao Cheng <kaitao.cheng@linux.dev>
Cc: Dennis Zhou <dennis@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@gentwo.org>,
Vlastimil Babka <vbabka@kernel.org>,
muchun.song@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Kaitao Cheng <chengkaitao@kylinos.cn>
Subject: Re: [PATCH v3 3/3] mm/percpu: Avoid IO/FS reclaim in backing allocations
Date: Wed, 17 Jun 2026 15:16:50 +0200 [thread overview]
Message-ID: <ajKeQhvsPwjjVLEx@tiehlicka> (raw)
In-Reply-To: <def64c45-bbe0-426a-bba1-9ac9e4db672d@linux.dev>
On Wed 17-06-26 16:56:56, Kaitao Cheng wrote:
[...]
> __GFP_NOFAIL is actually unnecessary here. The main reason is that,
> for now, I have not found any in-kernel callers that pass __GFP_NOFAIL
> to pcpu_alloc_noprof() or its wrapper functions. The reason I added
> __GFP_NOFAIL was to address the issue reported by sashiko, and I
> provided a detailed clarification in the link below.
>
> https://lore.kernel.org/all/3de3a89b-92f0-4cd2-9f41-8e853eae4e78@linux.dev/
>
> We should probably revert the current patch back to the v2 version,
> and then add some comments explaining why pcpu_alloc_noprof() must
> not be passed the __GFP_NOFAIL flag, as suggested by Andrew Morton.
Do not add support for nofail semantic until there is a clear demand for
it. Supporting this semantic is a big commitment and it shouldn't be
done without a very good usecase in mind.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2026-06-17 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 2:26 [PATCH v3 0/3] mm/percpu: Fix possible NOFS/NOIO reclaim recursion Kaitao Cheng
2026-06-12 2:26 ` [PATCH v3 1/3] mm/vmalloc: honor GFP constraints in pcpu_get_vm_areas() Kaitao Cheng
2026-06-15 19:55 ` Shivam Kalra
2026-06-17 6:02 ` Dennis Zhou
2026-06-12 2:26 ` [PATCH v3 2/3] mm/percpu: honor GFP constraints when populating chunks Kaitao Cheng
2026-06-17 6:29 ` Dennis Zhou
2026-06-12 2:26 ` [PATCH v3 3/3] mm/percpu: Avoid IO/FS reclaim in backing allocations Kaitao Cheng
2026-06-17 6:53 ` Dennis Zhou
2026-06-17 8:56 ` Kaitao Cheng
2026-06-17 13:16 ` Michal Hocko [this message]
2026-06-17 7:03 ` [PATCH v3 0/3] mm/percpu: Fix possible NOFS/NOIO reclaim recursion Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajKeQhvsPwjjVLEx@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chengkaitao@kylinos.cn \
--cc=cl@gentwo.org \
--cc=dennis@kernel.org \
--cc=kaitao.cheng@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.