All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
	Daniel Almeida <daniel.almeida@collabora.com>,
	Petri Latvala <adrinael@adrinael.net>,
	Arkadiusz Hiler <arek@hiler.eu>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
	Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
	Steven Price <steven.price@arm.com>,
	igt-dev@lists.freedesktop.org, kernel@collabora.com
Subject: Re: [PATCH 1/2] panthor: Provide a way to access user VA range when creating a VM
Date: Wed, 17 Jun 2026 16:54:32 +0100	[thread overview]
Message-ID: <ajLDOGRXbxippTsQ@e142607> (raw)
In-Reply-To: <20260616-panthor-vmbind-checkaddr-v1-1-f35b1b067f7c@collabora.com>

On Tue, Jun 16, 2026 at 04:43:22PM +0100, Adrián Larumbe wrote:
> This will be used in a future test that will check VM_BIND map range
> does not intersect with the range reserved for internal BO's.
> 
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  lib/igt_panthor.c | 5 ++++-
>  lib/igt_panthor.h | 7 ++++++-
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_panthor.c b/lib/igt_panthor.c
> index 7ffb61eb38e9..11d8ec342f0b 100644
> --- a/lib/igt_panthor.c
> +++ b/lib/igt_panthor.c
> @@ -201,7 +201,7 @@ void igt_panthor_query(int fd, int32_t type, void *data, size_t size, int err)
>   *
>   * Creates a VM.
>   */
> -void igt_panthor_vm_create(int fd, uint32_t *vm_id, int err)
> +void igt_panthor_vm_create_userva_range(int fd, uint32_t *vm_id, int err, uint64_t *uva_range)
>  {
>  	struct drm_panthor_vm_create vm_create = {};
>  
> @@ -210,6 +210,9 @@ void igt_panthor_vm_create(int fd, uint32_t *vm_id, int err)
>  	} else {
>  		do_ioctl(fd, DRM_IOCTL_PANTHOR_VM_CREATE, &vm_create);
>  		*vm_id = vm_create.id;
> +
> +		if (uva_range)
> +			*uva_range = vm_create.user_va_range;
>  	}
>  }
>  
> diff --git a/lib/igt_panthor.h b/lib/igt_panthor.h
> index be8490840f3a..64b0e687eef1 100644
> --- a/lib/igt_panthor.h
> +++ b/lib/igt_panthor.h
> @@ -17,7 +17,7 @@ struct panthor_bo {
>  };
>  
>  void igt_panthor_query(int fd, int32_t type, void *data, size_t size, int err);
> -void igt_panthor_vm_create(int fd, uint32_t *vm_id, int err);
> +void igt_panthor_vm_create_userva_range(int fd, uint32_t *vm_id, int err, uint64_t *uva_range);
>  void igt_panthor_vm_destroy(int fd, uint32_t vm_id, int err);
>  void igt_panthor_vm_bind_offset(int fd, uint32_t vm_id, uint32_t bo_handle, uint64_t va,
>  				uint64_t size, uint64_t ofsfet, uint32_t flags, int err);
> @@ -44,6 +44,11 @@ static inline void igt_panthor_vm_bind(int fd, uint32_t vm_id, uint32_t bo_handl
>  	igt_panthor_vm_bind_offset(fd, vm_id, bo_handle, va, size, 0, flags, err);
>  }
>  
> +static inline void igt_panthor_vm_create(int fd, uint32_t *vm_id, int err)
> +{
> +	igt_panthor_vm_create_userva_range(fd, vm_id, err, 0);
> +}
> +
>  enum cs_opcode {
>  	CS_OPCODE_NOP = 0,
>  	CS_OPCODE_MOVE48 = 1,
> 
> -- 
> 2.54.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

  parent reply	other threads:[~2026-06-17 15:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 15:43 [PATCH 0/2] panthor: Test for checking vm_bind address range is legitimate Adrián Larumbe
2026-06-16 15:43 ` [PATCH 1/2] panthor: Provide a way to access user VA range when creating a VM Adrián Larumbe
2026-06-17 12:46   ` Kamil Konieczny
2026-06-17 14:33   ` Boris Brezillon
2026-06-17 15:54   ` Liviu Dudau [this message]
2026-06-16 15:43 ` [PATCH 2/2] tests/panthor/panthor_vm: Add vm_bind intersect-with-kbo-range test Adrián Larumbe
2026-06-17 12:49   ` Kamil Konieczny
2026-06-17 14:34   ` Boris Brezillon
2026-06-17 15:54   ` Liviu Dudau
2026-06-17 18:10   ` Kamil Konieczny
2026-06-16 23:32 ` ✓ Xe.CI.BAT: success for panthor: Test for checking vm_bind address range is legitimate Patchwork
2026-06-16 23:46 ` ✓ i915.CI.BAT: " Patchwork
2026-06-17  4:26 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-17 20:15 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajLDOGRXbxippTsQ@e142607 \
    --to=liviu.dudau@arm.com \
    --cc=adrian.larumbe@collabora.com \
    --cc=adrinael@adrinael.net \
    --cc=arek@hiler.eu \
    --cc=bhanuprakash.modem@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=kernel@collabora.com \
    --cc=steven.price@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.