Re: [PATCH -next] s390/idle: Add missing EXPORT_SYMBOL()

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2039 bytes --]

On Wed, Jun 17, 2026 at 04:53:13PM +0200, Heiko Carstens wrote:
> Uwe Kleine-König reported this build breakage caused by a recent commit
> which provides arch specific kcpustat_field_idle()/kcpustat_field_iowait()
> functions:
> 
> ERROR: modpost: "arch_kcpustat_field_idle" [drivers/leds/trigger/ledtrig-activity.ko] undefined!
> ERROR: modpost: "arch_kcpustat_field_iowait" [drivers/leds/trigger/ledtrig-activity.ko] undefined!
> 
> Fix this by adding the missing EXPORT_SYMBOL().

Did you consider EXPORT_SYMBOL_GPL() which AFAIK is prefered over the
non-GPL one?

> Fixes: 670e057744e0 ("s390/idle: Provide arch specific kcpustat_field_idle()/kcpustat_field_iowait()")
> Reported-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Closes: https://lore.kernel.org/r/ajKsG0JP6qTssQBX@monoceros
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
>  arch/s390/kernel/idle.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/s390/kernel/idle.c b/arch/s390/kernel/idle.c
> index 7f7851c001e0..6da8ee22a1d5 100644
> --- a/arch/s390/kernel/idle.c
> +++ b/arch/s390/kernel/idle.c
> @@ -14,6 +14,7 @@
>  #include <linux/init.h>
>  #include <linux/cpu.h>
>  #include <trace/events/power.h>
> +#include <linux/export.h>
>  #include <asm/cpu_mf.h>
>  #include <asm/cputime.h>
>  #include <asm/idle.h>

When I fixed up the reported issue in my local tree, I didn't add that
include, so it seems to be included already implicitly. But I guess
adding that explicitly is a good idea.

> @@ -83,11 +84,13 @@ u64 arch_kcpustat_field_idle(int cpu)
>  {
>  	return arch_cpu_idle_time(cpu, CPUTIME_IDLE, !nr_iowait_cpu(cpu));
>  }
> +EXPORT_SYMBOL(arch_kcpustat_field_idle);
>  
>  u64 arch_kcpustat_field_iowait(int cpu)
>  {
>  	return arch_cpu_idle_time(cpu, CPUTIME_IOWAIT, nr_iowait_cpu(cpu));
>  }
> +EXPORT_SYMBOL(arch_kcpustat_field_iowait);
>  
>  void account_idle_time_irq(void)
>  {

Tested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]