All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Jiayuan Chen <jiayuan.chen@linux.dev>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 2/6] bpf, sockmap: Fix wrong rsge offset in bpf_msg_push_data()
Date: Wed, 17 Jun 2026 09:28:56 -0700	[thread overview]
Message-ID: <ajLLL6xN4oAUBSEi@john-p8> (raw)
In-Reply-To: <20260615021959.140010-3-jiayuan.chen@linux.dev>

On Mon, Jun 15, 2026 at 10:19:55AM +0800, Jiayuan Chen wrote:
>From: Weiming Shi <bestswngs@gmail.com>
>
>When bpf_msg_push_data() splits a scatterlist element into head and
>tail, the tail's page offset is advanced by `start` (absolute message
>byte offset) instead of `start - offset` (byte position within the
>element). This makes rsge.offset overshoot by `offset` bytes, pointing
>to the wrong location within the page or beyond its boundary. Consumers
>of the corrupted entry either silently read wrong data or trigger an
>out-of-bounds access.
>
> BUG: KASAN: slab-use-after-free in bpf_msg_pull_data (net/core/filter.c:2728)
> Read of size 32752 at addr ffff8881042f0010 by task poc/130
> Call Trace:
>  __asan_memcpy (mm/kasan/shadow.c:105)
>  bpf_msg_pull_data (net/core/filter.c:2728)
>  bpf_prog_run_pin_on_cpu (include/linux/bpf.h:1402)
>  sk_psock_msg_verdict (net/core/skmsg.c:934)
>  tcp_bpf_send_verdict (net/ipv4/tcp_bpf.c:421)
>  sock_sendmsg_nosec (net/socket.c:727)
>
>Fixes: 6fff607e2f14 ("bpf: sk_msg program helper bpf_msg_push_data")
>Reported-by: Xiang Mei <xmei5@asu.edu>
>Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>
>Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
>Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
>Signed-off-by: Weiming Shi <bestswngs@gmail.com>
>Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
>---

Reviewed-by: John Fastabend <john.fastabend@gmail.com>

  parent reply	other threads:[~2026-06-17 16:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  2:19 [PATCH bpf-next v4 0/6] bpf, skmsg: some fixes for skmsg Jiayuan Chen
2026-06-15  2:19 ` [PATCH bpf-next v4 1/6] bpf, sockmap: reject overflowing copy + len in bpf_msg_push_data() Jiayuan Chen
2026-06-15  2:32   ` sashiko-bot
2026-06-17 16:28   ` John Fastabend
2026-06-15  2:19 ` [PATCH bpf-next v4 2/6] bpf, sockmap: Fix wrong rsge offset " Jiayuan Chen
2026-06-15  2:49   ` bot+bpf-ci
2026-06-17 16:28   ` John Fastabend [this message]
2026-06-15  2:19 ` [PATCH bpf-next v4 3/6] bpf, sockmap: keep sk_msg copy state in sync Jiayuan Chen
2026-06-15  2:19 ` [PATCH bpf-next v4 4/6] sockmap: Fix use-after-free in udp_bpf_recvmsg() Jiayuan Chen
2026-06-15  2:37   ` sashiko-bot
2026-06-15  2:19 ` [PATCH bpf-next v4 5/6] bpf, sockmap: fix integer overflow in bpf_msg_pop_data() bounds check Jiayuan Chen
2026-06-17 16:38   ` John Fastabend
2026-06-15  2:19 ` [PATCH bpf-next v4 6/6] selftests/bpf: add test for bpf_msg_pop_data() overflow Jiayuan Chen
2026-06-15  4:40 ` [PATCH bpf-next v4 0/6] bpf, skmsg: some fixes for skmsg patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajLLL6xN4oAUBSEi@john-p8 \
    --to=john.fastabend@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=jiayuan.chen@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.