From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89AAFCD98ED for ; Thu, 18 Jun 2026 07:56:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wa7aw-0000hE-IT; Thu, 18 Jun 2026 03:55:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wa7as-0000Zt-Pi for qemu-devel@nongnu.org; Thu, 18 Jun 2026 03:55:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wa7aq-00056r-Hq for qemu-devel@nongnu.org; Thu, 18 Jun 2026 03:55:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781769316; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rGW17PWev+DoOhgJsh5gDijaj2K0a5VvrCwka0hiDEg=; b=dvnKoEsMjYrD/8arsUY0MZoryP7JptVAWP+kOFjiXekqwQU+r19PRLGXqHuxar0krdblTZ YMLVwyx3a0jOYqwwR6mO2aWssnY9HAZzn1kpkWQXG+oM7ZyRnm9JOALy2uq9sa1weTJOeL +hIC12PRPf8gL4wsVR7CXIFx3RT1dgA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-ZaTMTS8nM-68NJwkzN-nPg-1; Thu, 18 Jun 2026 03:55:13 -0400 X-MC-Unique: ZaTMTS8nM-68NJwkzN-nPg-1 X-Mimecast-MFC-AGG-ID: ZaTMTS8nM-68NJwkzN-nPg_1781769312 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B0C519560A1 for ; Thu, 18 Jun 2026 07:55:12 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.28]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1DB1175F; Thu, 18 Jun 2026 07:55:10 +0000 (UTC) Date: Thu, 18 Jun 2026 08:55:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Tom Stellard , Stefan Hajnoczi Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] trace/control: Fix -Wunused-but-set-global warning with clang 23+ Message-ID: References: <20260617224145.1419961-1-tstellar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260617224145.1419961-1-tstellar@redhat.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org CC trace maintainer. On Wed, Jun 17, 2026 at 03:41:45PM -0700, Tom Stellard wrote: > ../trace/control.c:41:13: error: variable 'init_trace_on_startup' set but not used [-Werror,-Wunused-but-set-global] > 41 | static bool init_trace_on_startup; > | ^ > 1 error generated. > > Signed-off-by: Tom Stellard > --- > trace/control.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/trace/control.c b/trace/control.c > index 1c8c50064a..49f0a4c5cd 100644 > --- a/trace/control.c > +++ b/trace/control.c > @@ -38,7 +38,9 @@ static TraceEventGroup *event_groups; > static size_t nevent_groups; > static uint32_t next_id; > static uint32_t next_vcpu_id; > +#ifdef CONFIG_TRACE_SIMPLE > static bool init_trace_on_startup; > +#endif > static char *trace_opts_file; > > QemuOptsList qemu_trace_opts = { > @@ -295,7 +297,9 @@ void trace_opt_parse(const char *optstr) > trace_enable_events(qemu_opt_get(opts, "enable")); > } > trace_init_events(qemu_opt_get(opts, "events")); > +#ifdef CONFIG_TRACE_SIMPLE > init_trace_on_startup = true; > +#endif > g_free(trace_opts_file); > trace_opts_file = g_strdup(qemu_opt_get(opts, "file")); > qemu_opts_del(opts); > -- > 2.51.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|