From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B1ACD98F2 for ; Thu, 18 Jun 2026 10:29:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wa9zn-000397-7U; Thu, 18 Jun 2026 06:29:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wa9zl-00038T-Bv for qemu-devel@nongnu.org; Thu, 18 Jun 2026 06:29:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wa9zj-0004o3-KF for qemu-devel@nongnu.org; Thu, 18 Jun 2026 06:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781778549; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZfXkGvhP5Q4hbrOYd520zXQ6OUEW3B06aeJld+noD4Q=; b=AXX62FqLHDYm6QYU/X8jgGcbCRbWwJjGrilRIz4xFArhxL8g521CEVi9KNp7Ki93g9dnIf PVRZDDrXa/02oQmc58IbCyn3IOzmE0TxtbaAKrWrDwxjLHrHKsGAZPyv72HDnGsmONyDDJ VAp4mfqeHUD8n5M50rSoN9Uj2QoYoRM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-csZjmqUBNNORS9uoAL-TRQ-1; Thu, 18 Jun 2026 06:29:06 -0400 X-MC-Unique: csZjmqUBNNORS9uoAL-TRQ-1 X-Mimecast-MFC-AGG-ID: csZjmqUBNNORS9uoAL-TRQ_1781778545 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF1AF1800BC3; Thu, 18 Jun 2026 10:29:04 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.28]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F1EBF30001A1; Thu, 18 Jun 2026 10:29:00 +0000 (UTC) Date: Thu, 18 Jun 2026 11:28:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Christian Brauner , devel@lists.libvirt.org, Markus Armbruster , Paolo Bonzini , "Dr. David Alan Gilbert" , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 27/35] monitor: implement support for deleting QMP objects Message-ID: References: <20260610123415.2883603-1-berrange@redhat.com> <20260610123415.2883603-28-berrange@redhat.com> <178112600389.209622.8962131616398640378.b4-review@b4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <178112600389.209622.8962131616398640378.b4-review@b4> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jun 11, 2026 at 01:13:23AM +0400, marcandre.lureau@redhat.com wrote: > On Wed, 10 Jun 2026 13:34:07 +0100, Daniel P. Berrangé wrote: > > diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h > > index a82e1aacb61..2e8e5ec721e 100644 > > --- a/monitor/monitor-internal.h > > +++ b/monitor/monitor-internal.h > > @@ -134,6 +134,7 @@ struct Monitor { > > char *chardev_id; > > CharFrontend chr; > > int suspend_cnt; /* Needs to be accessed atomically */ > > + bool dead; /* awaiting drain after monitor-remove */ > > I haven't looked into the details, but 'dead' is never read here, .. This is obsolete and should have been removed. > > @@ -178,6 +179,7 @@ struct MonitorQMP { > > Monitor parent_obj; > > JSONMessageParser parser; > > bool pretty; > > + bool setup_pending; /* iothread BH has not yet set up chardev handlers */ > > and 'setup_pending' is never set. I should have been setting & clearing this across the BH that sets up the chardev in I/O thread mode. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|