From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71E5348886 for ; Thu, 18 Jun 2026 18:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781806162; cv=none; b=IDMrIBMEeNH3P34gh0PkweeTl3k2VrFsmexN7UNo5eRcNZwLFPS2M5ndYbWTIN4ADi3h/Ay0mUu4eEXI8qTMCbOy2wFLcjVj5Dwly9nf4Ep8e/KOzxlR49mhb0CHWlZ6KDBLLKpNOKlZHeY29TYWOYd7ijTPxl8wJk5PZZu3SF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781806162; c=relaxed/simple; bh=O9vhXCqFBm9GqiOgoeyeqo44S1SJEtqC9wW3rM4qH18=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uhRxbYAstpiL/uMruIhDybHo6U2t/vq4yaz2DvslJHi4ZJ7IBzPYBNgSz/Sml4PxbAPToRq4zOZzIPGhv9mo/f+V3cFcTblSkrQYb2IaxUFhu51Kd/i+zpmaQUdurcM+wb8xhXYYIjXppPOqZzync123CmCk2MF40t6Aj6r+3fo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=GJY23/mQ; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="GJY23/mQ" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-9159951f05aso151335085a.0 for ; Thu, 18 Jun 2026 11:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1781806158; x=1782410958; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MaFteEIwkz4tq/KigGnjClWvDuo1M6hpghzWE22jDHI=; b=GJY23/mQTAX3EczA/6SjmodRi29ix9hzSoXuoQtG/O1X43p0pbjYHLv0t3P1Gx8OqZ Zi9jN9VEbw6rZKrxWXxbiULC7ymdb8HubayrxReuJWNew7pYU0wdfd1YajjzHW8gwovl ZCfrYO1mz+a/PxQcN0uJNyC/pwyrLUM8/ZnReSA1322kDzIMMRSwUHBWF26hLIbFHDMc wd7LivNviF6i0doDz+G7pbTlzuwjUHCREB9iXpQD8/IJ07icc1vxrPzKTgBBy3BU1b+1 JgIGrW2o/KuG2TCEt6MmQd8pIOLRbU091SZiVv+U++fe1sa1VElRGNVEUVFQSFjGXm7S MiJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781806158; x=1782410958; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MaFteEIwkz4tq/KigGnjClWvDuo1M6hpghzWE22jDHI=; b=btQSI0EopUslhXR0iAfou2wQqpcplPlrc4OJpKQzEC5lK4GswtQdXOZfkBXnXbvnVr aVqrWdNJ9gJn6aX/l8HAWfuWJ2qslnwEqOWz5tvA8IVRiERzuuI5EqgHn4vOJ/o9EsLB viqgEhIn42kyrHISvWWobw1tW1luPIrOzfMgKG1ahk6ZADaMvqqa6Xpe0ZjG6wzojuo7 WQHRM9h5kGNQY4hGg0IKco9yoY4/v+nWVbRs1DLMv06wuxqCYMMGhP7vpbWYlhJrRRsQ FwDRTvQmmhF+G00CYpnLSgzYEm6ubiZFgBaTf1Noj9x2wzheqTXO32YAi8oEz4sydtuH Xw+w== X-Forwarded-Encrypted: i=1; AFNElJ+9PMJpXiAVsWcRCTN41TA1Qd57i+QHVCpK0Jb1qj/qMgRz7+mJetCx2IQ51RiymjaWlPhHq/3tO5S08dw=@vger.kernel.org X-Gm-Message-State: AOJu0YxwGAQvC/4WVM4xJGPXHKZlDKJ2XyX0mwXCL1R9f/Ns4cfmOKYo LslizFkFAreb/S4/1APwJyoWVU4LJnfpeWSvaGX3OVGrpZpri9m7EgXJ9vo6ZvnAdNw= X-Gm-Gg: AfdE7cnHpMNR2fkzISDFfN5wDq4QUbCm2LI9k7umUlJmuVqwY8XtbnBma56WXUxGHf5 rSgZ7kDFt2bKGdo6JaJp0DLQIfu9lYF+2QzVr6rytXO30pLTYMIgnnAYOkmxsbhOr7m4bVU9hJK 4yvwcoEglDZVsqh4+IH6mdMEQhR9b2neu7r4t205ifYCZUEMTXDCE7p17CsiSQTwFj1rqSANc9J IE5V5H1Z+mrSfDGWN21vpShYj6w9kY3e+asLAUGtA3xGWSTtcVgaZCSgOz77zTBBLWv+nGi6Yvl Ta3Hkh05nmsH9NTOB+0Xd25eigCAro4eCYn6ED+84IpFQSw4bpjd9hDRuF5car0pNLl2GEEynUg R7PdHsxcUp6qtq8Mun4E7rlMlLZ0OU1w5g7PlM418q9llomqprTNispANSfT/uxypHg987y+HmP 4FCifmhIBJpBU= X-Received: by 2002:a05:620a:4510:b0:915:eec4:49ab with SMTP id af79cd13be357-9208f155b0emr10475785a.51.1781806158503; Thu, 18 Jun 2026 11:09:18 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a00598fsm2159106285a.31.2026.06.18.11.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2026 11:09:17 -0700 (PDT) Date: Thu, 18 Jun 2026 14:09:17 -0400 From: Johannes Weiner To: Ben Dooks Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: don't build vm_numa_stat_key if CONFIG_NUMA=n Message-ID: References: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> On Thu, Jun 18, 2026 at 11:06:14AM +0100, Ben Dooks wrote: > The vm_numa_stat_key is only exported if CONFIG_NUMA is set, > so avoid the following warning by guarding it in an #ifdef > on CONFIG_NUMA: > > mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Acked-by: Johannes Weiner