All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Michel Dänzer" <michel.daenzer@mailbox.org>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm/i915: Work harder to enable VRR based refresh rate changes on eDP
Date: Thu, 18 Jun 2026 21:39:23 +0300	[thread overview]
Message-ID: <ajQ7W44qv28-i6Pq@intel.com> (raw)
In-Reply-To: <18f0c14b-f973-4e1a-948b-5274cc36895c@mailbox.org>

On Tue, Jun 16, 2026 at 09:21:01AM +0200, Michel Dänzer wrote:
> On 6/15/26 15:06, Ville Syrjälä wrote:
> > 
> > What we're doing here is selecting the actual timings to drive an internal laptop 
> > panel, given some random cooked up modeline from userspace.
> 
> How can user space know what cooked-up modes it can (not) expect to work with this?

Without VRR support it can only expect modes that have the same refresh
rate as one of the modes on the connector's mode list to work. With VRR
support anything within the VRR range should generally work. That's
assuming other parameters (eg. scaling) are acceptable of course.

> 
> 
> > We pick the actual mode from the set of "fixed modes" (ie. the modes
> > that the panel/system itself has reported as supported via
> > EDID/VBT/ACPI/etc.). For non-VRR panels we just pick the fixed mode
> > whose refresh rate is closest to the user specified mode, and reject
> > the commit if it's not close enough (<= 1 Hz).
> 
> Can't programming different mode timings result in the panel blanking intermittently?

Userspace can specify that a modeset is not allowed, thus if the
driver can't achieve the refresh rate change without blinks the
commit will be rejected.

-- 
Ville Syrjälä
Intel

      reply	other threads:[~2026-06-18 18:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 14:41 [PATCH 0/4] drm/i915: Work harder to enable VRR based refresh rate changes on eDP Ville Syrjala
2026-06-12 14:42 ` [PATCH 1/4] drm/modes: Add DRM_MODE_MATCH_TIMINGS_VRR Ville Syrjala
2026-06-13 14:19   ` Kandpal, Suraj
2026-06-12 14:42 ` [PATCH 2/4] drm/i915: Pass the full atomic state to .compute_config() Ville Syrjala
2026-06-13 14:23   ` Kandpal, Suraj
2026-06-12 14:42 ` [PATCH 3/4] drm/i915/panel: Adjust intel_panel_compute_config() calling convention Ville Syrjala
2026-06-13 14:25   ` Kandpal, Suraj
2026-06-12 14:42 ` [PATCH 4/4] drm/i915/panel: Attempt VRR based refresh rate change for !allow_modeset Ville Syrjala
2026-06-12 14:56   ` sashiko-bot
2026-06-15  5:17   ` Nautiyal, Ankit K
2026-06-18 19:10     ` Ville Syrjälä
2026-06-12 14:58 ` ✗ CI.checkpatch: warning for drm/i915: Work harder to enable VRR based refresh rate changes on eDP Patchwork
2026-06-12 14:59 ` ✓ CI.KUnit: success " Patchwork
2026-06-12 15:45 ` ✓ i915.CI.BAT: " Patchwork
2026-06-12 15:54 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-13  7:16 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-13 13:24 ` ✗ i915.CI.Full: failure " Patchwork
2026-06-15  9:06 ` [PATCH 0/4] " Michel Dänzer
2026-06-15  9:08   ` Michel Dänzer
2026-06-15 13:06     ` Ville Syrjälä
2026-06-15 13:30       ` Michel Dänzer
2026-06-15 17:00         ` Ville Syrjälä
2026-06-16  7:21       ` Michel Dänzer
2026-06-18 18:39         ` Ville Syrjälä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajQ7W44qv28-i6Pq@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michel.daenzer@mailbox.org \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.