From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 451D035B12B for ; Thu, 18 Jun 2026 15:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781795327; cv=none; b=DBFVCsNOreDyFNbYLmND2PudI9QxSiWt2yIKdnahlbkmfCVcyylBlygArA/6XKDAqJmZUBBRia4vCWXoU/eS89P1klsr1Rg7/m2kX3HapIaop9um9PIaxnv1o/DDe8puEB4YQxUsrPikYUv2zI3FlY2n0c2vmCua4dqrtcT/R9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781795327; c=relaxed/simple; bh=j7I8UJyT8BSwhSdv2GNvZCH1V+p1+5vWgg8tDCbksBo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JAtdvK8Rzk5RB+4gkKlCG3qMglIO4aiq5gzuydWSyqB5eFkHLIDCynTEjzOxD/e90HX+NwvQm7My/JLsPcmX4Z51YcfhpL6R6NJLuTJa3S7R0QwPBZoYv+pbZt+uCs+6Pfn9K6WYxxYkskgvB1q0vxu6b1YZLF9YQZYH9qqaDzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ROp79cmT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ROp79cmT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781795325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z8aF624OO+5Kg4cHSW/V1/aSmMHUP2alsVyLwZskSKw=; b=ROp79cmT7q3HcKaBuG+PUA6MhVGHCWEOc4J8JrUgsRLOR5jExBYwjQ6P+c/xtc0iRdm9Is UBEjE3MgAdLRS58ASka3DyaohAG+bAIdciRCJZTcqThZ78a191k07BjBbvS3cUCdL0xIjs QRUnEiIRTvAXkda82DP8fxPdZoEWw+Y= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-FgaREIEkMr6PdaBPsL_jJg-1; Thu, 18 Jun 2026 11:08:41 -0400 X-MC-Unique: FgaREIEkMr6PdaBPsL_jJg-1 X-Mimecast-MFC-AGG-ID: FgaREIEkMr6PdaBPsL_jJg_1781795320 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 851EA1935312; Thu, 18 Jun 2026 15:08:40 +0000 (UTC) Received: from fedora (unknown [10.44.34.12]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 59D511800664; Thu, 18 Jun 2026 15:08:38 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 18 Jun 2026 17:08:40 +0200 (CEST) Date: Thu, 18 Jun 2026 17:08:37 +0200 From: Oleg Nesterov To: David Howells Cc: Christian Brauner , Marc Dionne , linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Li RongQing Subject: Re: [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop Message-ID: References: <20260618074903.2374756-1-dhowells@redhat.com> <20260618074903.2374756-15-dhowells@redhat.com> <2478530.1781790791@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2478530.1781790791@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On 06/18, David Howells wrote: > > Oleg Nesterov wrote: > > > > --- a/fs/afs/internal.h > > > +++ b/fs/afs/internal.h > > > @@ -750,8 +750,6 @@ static inline void afs_vnode_set_cache(struct afs_vnode *vnode, > > > { > > > #ifdef CONFIG_AFS_FSCACHE > > > vnode->netfs.cache = cookie; > > > - if (cookie) > > > - mapping_set_release_always(vnode->netfs.inode.i_mapping); > > > #endif > > > > This change looks unrelated... > > If I remove that bit, can I add your R-b? Yes, thank you! Oleg.