Re: [PATCH] virtio-blk: store the zone-append sector as little-endian

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jun 18, 2026 at 11:20:59AM -0400, Stefan Hajnoczi wrote:
> On Wed, Jun 17, 2026 at 11:17:39AM -0400, Michael Bommarito wrote:
> > The zone-append completion path writes the append sector back to the
> > guest with virtio_stq_p(), the VIRTIO_F_VERSION_1-aware accessor,
> > while the rest of the zoned reply path (the zone report descriptors
> > and the report header) stores its fields with cpu_to_le64(). The
> > zoned feature is only defined for VIRTIO 1.x devices and the virtio
> > specification defines all of its fields as little-endian, so store the
> > append sector with stq_le_p() too, for a single spec-matching
> > convention across the zoned path.
> > 
> > This is not a functional change for a VIRTIO 1.x device, where
> > virtio_stq_p() already stores little-endian; it only removes the mixed
> > convention within the zoned reply path.
> > 
> > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > Assisted-by: Claude:claude-opus-4-8

^^^^^^^  strictly speaking this may not be compatible with our
policy if Claude was used to write the patch.  If Claude was
merely used for research or testing, that's fine.

If it did write the patch, we could make an exception on the
basis that there is only a single way to write this trivial fix.

None the less the Assisted-by advertizing hoarding should be
removed before merging, as even our new proposed looser policy,
rejects use of Assisted-by.

> > Signed-off-by: Michael Bommarito <michael.bommarito@gmail.com>
> > ---
> > Testing: builds (qemu-system-x86_64) and the qos-test virtio-blk cases
> > (basic, indirect, config, resize, msix, idx, nxvirtq, hotplug) pass
> > against the patched binary. No functional change on a
> > VIRTIO_F_VERSION_1 device, where virtio_stq_p() already stores
> > little-endian.
> > 
> >  hw/block/virtio-blk.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>



With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|