From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECFAE3672BE for ; Fri, 19 Jun 2026 09:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862685; cv=none; b=HTDCfX8h7mMir0YvsbGT6XvLQAADGXq0IQCv4Jj3FoRFKBSX/oRN3sZjweUQjElKM9BcjhJlc218SbmDI4dD+RQccFzOWq911K/9T9bi8kZRGQwW2UCeke0uT+7rBHNeYlSBJeh1NHmvwNEQoMm/tg4J1RYRokizLcORiAm51II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862685; c=relaxed/simple; bh=Np57y1RewaMp7S11du06k3/m28dTqQavWnT1vKBfBKQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=NohyctGVT8FXxcHg8QED3rn+9EY5Ts4955mdXgwxGU9TfhYCui6oqZw8VM8gmPlcmmZyFH62aMhIfNYqp4vQK7UbvBZomnprF1m6GxjwAGG5pvwxtB6eJYJ98oDZdwcYrHeqNxpbGi+0t2+bxNZD9rAECDwl78i2mHr3IZ6bvVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YOUYW1KF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YOUYW1KF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781862680; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=mEVtJz7H9t+nOxELny5clyRxDZa4RQAWySWdtlX0yF0=; b=YOUYW1KFyvnMYoU3cG06G07RCdiMyjThIOeKOZFVZRi425tUcd14y+GN8XDqKyMGkHVAmZ AysBn3SFztjze99bzdqKGqx0EzESYeNG/S9+DFy6vWjOKkciQnY2GS7L6DpMEucO7VXBX+ qy+/Ihmqgb+OiTDS4qZmNnkYrWKdq3A= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-di94uPLKP8OPaKfRYW1GpQ-1; Fri, 19 Jun 2026 05:51:17 -0400 X-MC-Unique: di94uPLKP8OPaKfRYW1GpQ-1 X-Mimecast-MFC-AGG-ID: di94uPLKP8OPaKfRYW1GpQ_1781862675 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 24CBC1955F74; Fri, 19 Jun 2026 09:51:15 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.122]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 55A8A1956041; Fri, 19 Jun 2026 09:51:08 +0000 (UTC) Date: Fri, 19 Jun 2026 10:51:04 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Khushit Shah Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, Eric Auger , Cornelia Huck , Peter Maydell , Richard Henderson , Marc Zyngier , Oliver Upton , Andrea Bolognani , Jiri Denemark , Gavin Shan , Shameer Kolothum , Sebastian Ott , Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jinqian Yang , Shaju Abraham , Mark Cave-Ayland Subject: Re: [RFC PATCH v2 23/29] target/arm/qmp: add query-arm-cpu-props-info Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20260605083358.1320563-1-khushit.shah@nutanix.com> <20260605083358.1320563-24-khushit.shah@nutanix.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260605083358.1320563-24-khushit.shah@nutanix.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: Ue5tlGSRt44Crf49hfkZY1IX6kohRurCCbh6MbqefNo_1781862675 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Fri, Jun 05, 2026 at 08:33:52AM +0000, Khushit Shah wrote: > Introduce 'query-arm-cpu-props-info' QMP command. This command returns > information about ARM CPU model properties, including their name, type, > supported values on the given host, and composite parent if any. Do we have to make this ARM only ? x86 has named CPU properties too. They are all basically booleans so this API offers a superset of functionality needed for x86, and thus I'd expect x86 to be folded into this new API too. > This provides management layer necessary information to determine > migration compatibility off a VM on different host. > > Signed-off-by: Khushit Shah > --- > qapi/misc-arm.json | 41 ++++++++++++++++ > stubs/qmp-arm-gic.c | 6 +++ > target/arm/arm-cpu-props-stub.c | 13 +++++ > target/arm/arm-cpu-props.c | 85 +++++++++++++++++++++++++++++++++ > target/arm/arm-cpu-props.h | 5 ++ > target/arm/arm-qmp-cmds.c | 44 +++++++++++++++++ > target/arm/cpu-idregs.c | 71 +++++++++++++++++++++++++++ > target/arm/cpu-idregs.h | 8 ++++ > 8 files changed, 273 insertions(+) > > diff --git a/qapi/misc-arm.json b/qapi/misc-arm.json > index 4dc66d00e5..1a3fb140c4 100644 > --- a/qapi/misc-arm.json > +++ b/qapi/misc-arm.json > @@ -46,6 +46,47 @@ > ## > { 'command': 'query-gic-capabilities', 'returns': ['GICCapability'] } > > +## > +# @CpuPropInfo: > +# > +# Information about a specific ARM CPU model property. > +# > +# @name: the name of the property > +# > +# @type: the type of the property, any of ('string', 'boolean', > +# 'number'). > +# > +# @supported-values: the set of values the host hardware supports > +# for the property, a list of strings. > +# > +# @composite: name of the encapsulating composite property if any. > +# > +# Since: 11.1 > +## > +{ 'struct': 'CpuPropInfo', > + 'data': { 'name': 'str', > + 'type': 'str', This should be an enumerated type, not a string. > + 'supported-values': 'any', If these values vary based on @type, then this should be a discriminated union. > + '*composite': 'str' } } > + With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|