From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E6C380FFD for ; Fri, 19 Jun 2026 13:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781875673; cv=none; b=G/eQHXYJwi3+JPZhrDXQuik9QmKXmBaZW6jdeNJIFSVS/sUzW8mGH6Yy9+N2hWbljo4deBUmrpuZQ0LVL5tphDcTaTFlfpyihdmh4IN9k4A2CRdvG25rRC2XE3gIhlyV3u+HJadI6WyI4wXUKCD4TQNkgXOmteImqPmbKSsCsTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781875673; c=relaxed/simple; bh=mnXMcXPxedRIQKYZSgpr8tdOrj/zay+ZFdFrrmp+E0s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=am5gVyOgwtwSJEzmcjaY29klgxFgN4mgt7GKCIbuk+E2wWdToG6mqCRN0OnfzdKew9ywuN5dKkQnGQC/2wUO7PhJMWQD3Tq3thrju2fok/dGYlN16hkZlnTtcYP4tmc2fXk13nm35h+puTjxHdNseawKgAZq/9+r46Zf9Vj2c/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OPr01w9R; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OPr01w9R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781875671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5YHElZW7iIEjbpQYFMEg0pumlpPYzxs0DTYqwq3pLzg=; b=OPr01w9RT9idrMyI/moffsw4Po71de0/3pyBzGtS9/I0zZA0bueCCZsHheMvO+DFtqHuhq Qletnz24Mtq6tLA9hcu93oqbgrdT8iLfyXcIIVRt8SHuQGaQ79ZW3uPcMuMXEDyUedNW0q rJ8mJT00p/6kWbeNtPzuyTylXH7oopI= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-Or__GWIeOx2jdeHkXkX8tA-1; Fri, 19 Jun 2026 09:27:49 -0400 X-MC-Unique: Or__GWIeOx2jdeHkXkX8tA-1 X-Mimecast-MFC-AGG-ID: Or__GWIeOx2jdeHkXkX8tA_1781875667 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64D4C1977521; Fri, 19 Jun 2026 13:27:47 +0000 (UTC) Received: from fedora (unknown [10.44.34.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id B4DDE3000235; Fri, 19 Jun 2026 13:27:43 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 19 Jun 2026 15:27:46 +0200 (CEST) Date: Fri, 19 Jun 2026 15:27:42 +0200 From: Oleg Nesterov To: Andrew Morton Cc: Andy Lutomirski , "Eric W. Biederman" , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] signal: turn the "bool force" arg of __send_signal_locked() into "int flags" Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 No functional change. Preparation for the next patch which will add another flag to fix the SA_IMMUTABLE signal evasion. Signed-off-by: Oleg Nesterov --- kernel/signal.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 68af503ed43c..9c607a598ba1 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1037,8 +1037,10 @@ static inline bool legacy_queue(struct sigpending *signals, int sig) return (sig < SIGRTMIN) && sigismember(&signals->signal, sig); } +#define SEND_SIGNAL_FORCE (1 << 0) + static int __send_signal_locked(int sig, struct kernel_siginfo *info, - struct task_struct *t, enum pid_type type, bool force) + struct task_struct *t, enum pid_type type, int flags) { struct sigpending *pending; struct sigqueue *q; @@ -1048,7 +1050,7 @@ static int __send_signal_locked(int sig, struct kernel_siginfo *info, lockdep_assert_held(&t->sighand->siglock); result = TRACE_SIGNAL_IGNORED; - if (!prepare_signal(sig, t, force)) + if (!prepare_signal(sig, t, flags & SEND_SIGNAL_FORCE)) goto ret; pending = (type != PIDTYPE_PID) ? &t->signal->shared_pending : &t->pending; @@ -1211,7 +1213,8 @@ int send_signal_locked(int sig, struct kernel_siginfo *info, force = true; } } - return __send_signal_locked(sig, info, t, type, force); + return __send_signal_locked(sig, info, t, type, + force ? SEND_SIGNAL_FORCE : 0); } static void print_fatal_signal(int signr) @@ -1295,6 +1298,7 @@ force_sig_info_to_task(struct kernel_siginfo *info, struct task_struct *t, unsigned long int flags; int ret, blocked, ignored; struct k_sigaction *action; + int send_flags = SEND_SIGNAL_FORCE; int sig = info->si_signo; spin_lock_irqsave(&t->sighand->siglock, flags); @@ -1315,7 +1319,7 @@ force_sig_info_to_task(struct kernel_siginfo *info, struct task_struct *t, if (action->sa.sa_handler == SIG_DFL && (!t->ptrace || (handler == HANDLER_EXIT))) t->signal->flags &= ~SIGNAL_UNKILLABLE; - ret = __send_signal_locked(sig, info, t, PIDTYPE_PID, true); + ret = __send_signal_locked(sig, info, t, PIDTYPE_PID, send_flags); /* This can happen if the signal was already pending and blocked */ if (!task_sigpending(t)) signal_wake_up(t, 0); @@ -1550,7 +1554,7 @@ int kill_pid_usb_asyncio(int sig, int errno, sigval_t addr, if (sig) { if (lock_task_sighand(p, &flags)) { - ret = __send_signal_locked(sig, &info, p, PIDTYPE_TGID, false); + ret = __send_signal_locked(sig, &info, p, PIDTYPE_TGID, 0); unlock_task_sighand(p, &flags); } else ret = -ESRCH; @@ -2259,7 +2263,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig) * parent's namespaces. */ if (sig) - __send_signal_locked(sig, &info, tsk->parent, PIDTYPE_TGID, false); + __send_signal_locked(sig, &info, tsk->parent, PIDTYPE_TGID, 0); __wake_up_parent(tsk, tsk->parent); spin_unlock_irqrestore(&psig->siglock, flags); -- 2.52.0