Re: [PATCH blktests] Fix _get_page_size()

[Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

CC+: Omar, Chaitanya,

On Jun 18, 2026 / 10:41, Jeff Moyer wrote:
> There is no CONFIG_PAGE_SHIFT stored in /boot/config-`uname -r` on RHEL
> systems (maybe all systems?).  As a result, tests that make use of
> _get_page_size() were doing the wrong thing.  For example, throtl/002
> used it to calculate I/O sizes for direct IO.  Those sizes ended up not
> being a multiple of the logical block size, and hence throtl/002 was
> failing.
> 
> Fixes: 8eca9fa ("common/rc, scsi/011, zbd/010: introduce _page_size_equals() helper")
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

Thanks for finding this out. When I applied the commit in the Fixes tag, I had
checked my Fedora system's /boot/config-* files and had found CONFIG_PAGE_SHIFT
defined. I wanted to avoid the dependency to getconf, and chose the way to rely
on CONFIG_PAGE_SHIFT. But that is not an option for other distros. Today I
checked my Debian system, and CONFIG_PAGE_SHIFT was not defined either. Now I
see that we should not use CONFIG_PAGE_SHIFT.

> 
> diff --git a/common/rc b/common/rc
> index 20f7c7a..d60a125 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -562,13 +562,8 @@ _have_systemctl_unit() {
>  	return 0
>  }
>  
> -# Get system page size from kernel conguration
>  _get_page_size() {
> -	local page_shift
> -
> -	page_shift=$(_get_kernel_option PAGE_SHIFT)
> -
> -	echo $((1<< page_shift))
> +	getconf PAGE_SIZE
>  }
>  
>  # Check if the system page size matches the required size (in bytes).
> 

The patch above should work, but it creates a new dependeny on the tool getconf.
There are 6 test cases that require page size and getconf. Then, we need to
check that getconf command is available for the test cases.

  $ git grep _page_size
  common/rc:_get_page_size() {
  common/rc:# Example: _page_size_equals 4096
  common/rc:_page_size_equals() {
  common/rc:      current_size=$(_get_page_size)
  tests/scsi/011: _page_size_equals 4096
  tests/throtl/002:       page_size=$(_get_page_size)
  tests/throtl/003:       page_size=$(_get_page_size)
  tests/throtl/007:       page_size=$(_get_page_size)
  tests/zbd/010:  _page_size_equals 4096
  tests/zbd/014:  page_size=$(_get_page_size)

Havind said that, I think now Linux eco-system is in the phase to add variety
of page sizes, and I expect more test cases that depend on page sizes will be
added in near future. So, this could be the good timing to add getconf to the
blktests minimal requirement list described in README.md. This means that
blktests users will need to install glibc-common package for Fedora, or
libc-bin package for Debian.

This is a rather fundamental change, so I would like to ask opinions from
other blktests users, especially Omar and Chaitanya. What do you think about
the idea to add getconf to the requirement list?