From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95134363C45 for ; Mon, 22 Jun 2026 09:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782119263; cv=none; b=La8/vFPq+GdBunmjw4fi7f89Gglew103OtxzvHGaHrB993tU5q+PL0OCfpDIui9v7bq4xymcQDbBt8rlovfwEBgCUXQmbENAJvJdqJ/gZSa56e7bDZZiu/KS8nTzAH0e6MWnXHdLmsLiYYjuZidpSpnXcf9UznaUDwKZBP9KA60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782119263; c=relaxed/simple; bh=j83wHl1vgswEJj6jURdFdB1HRy2jCHOk2WmWIh52g8A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eWMp3kyLKZRSK7kdYBjVClSaKZnwkDOmxLDeyljnGaoISTvotahL8G5MfQnthCu2s4ZtUxpw9HALTxac/q6IJq85Bzs9CmiUGeXvCBlYmJKaLQXNatRwetjVpTMDHoYguRWe3ml+YQrVgCLVd6tQl0BhE1AkQEtVfl705PMe7vQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W7DNruCP; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W7DNruCP" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c0c41ff84a6so264533266b.1 for ; Mon, 22 Jun 2026 02:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782119259; x=1782724059; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RDAFwnUnM/TDiKNBHO8fQu7Y5AzSk6/sx2Rrw7B/zJc=; b=W7DNruCPSWIsmdjnNW1E6gbx4mrZp+wIY6Fb7R603t4qyD0bue6Icbv43XLhHFL6IY tji+p/EH1pLLZmEIPTF1sUBSOem40RJ1MnMgHgUAH9aDggFKw0DWhaXVqI83xIbNagSY hCwydzckgjfth+T1d3Tws7a17+fBODVj9O5wCv7JR4g7fdGLwpHNffGDkW80dYI9a0FV DLOwuVbgf42cyPprPx6udTrCslnvDOdM8DOrfVj9opVAdXld4XQ9ubhrJJTy35hvhSzX 0Pa8rwDwknxFPNcDWOniu003JRT0mDBgnwyp26q67traRHuxdI6V8OZs3fUfk1LyjkQq GdCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782119259; x=1782724059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RDAFwnUnM/TDiKNBHO8fQu7Y5AzSk6/sx2Rrw7B/zJc=; b=rhV1A7Y1VbRm7JgPNi/WyMADlQBTl/e3FlH/K51hn5kEwSPkpSxL3FdkZNTqDsrWgY h7iG4Yx/y++HWYh8jbefuH9OWO0HbZEn8ZgdG6XFxf04nFOj5/ZXNeeiimOJobX3kEUT UqwFjhGWqtF2Sg66g+zweyfT6D6GtHgp37ZQz3k0pGmm+ConN0elV8y2l8HOj6rLJTRV psG9uAZB8b4iJuAexp/yVL9+ig73VXrBVped5SUuqf3OLyOFv4KBj7DKpVH8iH9t+gZc 5a0F4lhBp3hPcRYkOA5fN9aYF/kxKJzkQ05QMy+lxGUEr0m43RTwpU/y1vRqBjDASU73 1ITg== X-Forwarded-Encrypted: i=1; AFNElJ/zxHaJBuLzU+RkkkbARdOLJk5TnO/9l3BFmkEW1xxJQrbRNKTWM9LvWzwnQObDTRBgBkbK13o4M98hru8=@vger.kernel.org X-Gm-Message-State: AOJu0YyDm8geCKdgYhpWez8kyMmCbTLpMzmdKw9bo9cl4bTHWiuLVvpd fiEajNJFP3Jo+NchkFkoCUaZewFgqw2p32DmUIlOZ1GQMhKFjB9aLC4w X-Gm-Gg: AfdE7cnMM943bb2V4PmwvyV49SPEefZGNwjP00LQXgMkmXZG7Auxs5XyEWCEkv9dLND U3g/ppSEJ186+LdZHwXUrf8aX0YN2wjmwycCYnIj1LxZBL+3CoyQzhOJjgZg0w4JTWA5y8lmN/9 YZxXvObeaILGmtG0dHy7Eo7j7yi3Y2p9P7VNgp5+5N2Mv/qK1BhjSjPy2EC6tyYttfQvpGDbF3b 9o65lP+WRaIYmwwZ8/dnU/fGzot23u/xob++awPkvH75YtqIkYtjsWmO9oaQsA+1iEVh8Y+qGPc XDcgb542o3Qq88VqZ2+ZE/95BY7V8SyYp5w3OyboGeUI0i6njvnmskKuFdXYS5v94vSdPWqgCe0 Pnm8mNj5A/6bDRMQlHXT2KDKWcR79d77pjVW3BwzJbSW/TmUxgEV5Ta2WtofG8Z8fbpyHKiWzbg AFPzlGxipW X-Received: by 2002:a17:907:25c3:b0:bcb:66df:819a with SMTP id a640c23a62f3a-c097cccd477mr720797366b.40.1782119258537; Mon, 22 Jun 2026 02:07:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c610e4c76sm320651066b.46.2026.06.22.02.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 02:07:37 -0700 (PDT) Date: Mon, 22 Jun 2026 12:07:33 +0300 From: Dan Carpenter To: Serhat Kumral Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: rtl8723bs: use usleep_range instead of msleep for short delays Message-ID: References: <20260621104058.7408-1-serhatkumral1@gmail.com> <20260621104058.7408-3-serhatkumral1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260621104058.7408-3-serhatkumral1@gmail.com> On Sun, Jun 21, 2026 at 01:40:58PM +0300, Serhat Kumral wrote: > Replace msleep(10) and msleep(1) with usleep_range(10000, 20000) and > usleep_range(1000, 2000) respectively in os_intfs.c, because msleep is > imprecise and discouraged for short delays under 20ms. > This fixes the checkpatch.pl warnings: > WARNING: msleep < 20ms can sleep for up to 20ms; see function description of msleep(). > > Signed-off-by: Serhat Kumral > --- > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > index 89e41c26e..5e41f518a 100644 > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > @@ -986,7 +986,7 @@ void rtw_dev_unload(struct adapter *padapter) > if (cnt > 5) > break; > cnt++; > - msleep(10); > + usleep_range(10000, 20000); The first two are fine but this isn't. Do a search on lore for the reasons. regards, dan carpenter