Re: [PATCH 3/6] riscv: remove unreachable invalid range check in create_linear_mapping_page_table()

[Charlie Jenkins <thecharlesjenkins@gmail.com>]

On Sun, Jun 21, 2026 at 11:59:13PM +0900, Sang-Heon Jeon wrote:
> create_linear_mapping_page_table() iterates memblock regions with
> for_each_mem_range() and breaks the loop when start >= end.
> for_each_mem_range() never returns an invalid range, so start < end always.
> 
> Therefore the start >= end check is unreachable, so remove it.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>

Reviewed-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
Tested-by: Charlie Jenkins <thecharlesjenkins@gmail.com>

> ---
>  arch/riscv/mm/init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 5b1b3c88b4d1..eb93c2ac05a6 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -1229,8 +1229,6 @@ static void __init create_linear_mapping_page_table(void)
>  
>  	/* Map all memory banks in the linear mapping */
>  	for_each_mem_range(i, &start, &end) {
> -		if (start >= end)
> -			break;
>  		if (start <= __pa(PAGE_OFFSET) &&
>  		    __pa(PAGE_OFFSET) < end)
>  			start = __pa(PAGE_OFFSET);
> -- 
> 2.43.0
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv