From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44042342CB3 for ; Mon, 22 Jun 2026 17:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782151000; cv=none; b=DZ+XTCfUPeYWmChE+r6D7xLy8K+Z+4axTtyQwooCQSALWaESlCd8zkEcMBcX5y5LtQ8Q1eLWsn67OQd76sj7bInORWqhvWP6sKpDVg4f3ozOfyd1rsLh1IslmqFkSLyLh5leYCmW8hkl+xYvVN6ceezCaPrQhBcBwf9BTqndpUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782151000; c=relaxed/simple; bh=6V2CpHTmhKt8CXsxhZNW1CrZ0nQaLGnJAyPEhDFtCnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DByg+xA6i6PVzrKXsD9p1ZZ932XbcX2VhHSMd3LBQLD5rvXM8qpWN0rmo1yaBWS6yMc5i8U5od6r//7o1Wo27cH6MBCkYkn7lgtHshxOovPRtBUXitIBKOcOC3vhluEKXHdmHAGPRNXWjJAmptVeslKbyQKpk+wWz6AkflBXI2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S2PPOnRG; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S2PPOnRG" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-845385adf4cso2157456b3a.0 for ; Mon, 22 Jun 2026 10:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782150998; x=1782755798; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ALF4suzKTcfcvIWAEHl1j9uOThw4EM7gFWBHfreRwZ4=; b=S2PPOnRGpazD2aBq/lBnWeymNp31ZU3HQxzJtDxXy7QYhomd2bvq4Qlk7mq/ey/aml ZtCnxLNX/iZTN+iJgOMnDJ10+l/wNmBhrzQW0E99doJwL1dAWtLGjKFcsGcDPYs9Dpdc CXy1IIGCzHU8M6v7kuyVVNKfTmz1QBaq0LfPorNMUfFDYnjgU0HNJYnUI33V00uReepQ vnxxgSuOCJSlvXH0hitQAngK22MBWp6lyeMJ2vhs5fECs8N/euVaT8G/65vVUSaOo++M INJXPA0zYFC6RoMGu8Yc/L5LU6KBdAwvbDiBXwQjYQ7thcVfkvUNfOy+0XX8UZyZqreb aY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782150998; x=1782755798; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ALF4suzKTcfcvIWAEHl1j9uOThw4EM7gFWBHfreRwZ4=; b=Y5eLtaTAu/CzzSjX+ghdz8819tOJjZpuCqabxYtmUpvCUaUvlhI+WTh+RFQXhLPX8h MrUbq8qR+a6N8YyHg0OZlYU6bIYACziVwu9Y4RncbQEGcD/HvNxysd2rnI2lz/6yjxqM MrFFiEFdJStLDLvdT79jIFvAuoTfnGiiRUkCOvGDIxPQYovSdjTGfOFYAVnD7p7whWo3 qgFFQ2mmFWwdnkGl4wzT3ofTA2BIWS+dReP+i86kSU7vyYVYXruLhtYB8dlyefRh0yxr a/l8Bplu1KWTnz8Du22y6lby1rjxAIfzD08KqYB75ENK/M+/bPoAP+9OJwq5nUCtvO2S GhJQ== X-Forwarded-Encrypted: i=1; AFNElJ+ug+x0Xrtrp/4Jq04G778jaCk7yt2eyenXFSZPk/+24znjM/pA/n0zPOcw5zIGa8j07qSdNx29HT2yxAM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/VoKU9nUxZxdgNBQLmEe2hO7/MD3SLDX1aWucOaTXRoW2vgZX q4ZUCsRjGlfWBz85TEETScecPrRLsil2utqd5XY0Hwo9edM/x7Hb9BsA1v2I5XZ/lHI= X-Gm-Gg: AfdE7cllEeFtD3SG+YnofjPlBgtnHaM35Lp9J6lzPycrF80PHt1ZtIEY22bDPgYZjOa ZOE5CGdaxmiY4wfYUryKzoo5m+3VuJqZCaENkVT/3J8oNqaw56ZHR2XuKliIrLLIuJXtrVSPRDi Dt6p26cVd/KYby/X+BEUbAJ24nh2AjStBmGpH6i4am+eZNe1kuObSOkPe30EMB/pN8F5w1pq2BS wHK9vC+ln0Y0oDtJ8Vux7PPmklM9UvTMGYGBAus0m/fb9micEjnW12hcswh3xfYd8xGrKmfTiv/ u3nBn0mF78ZE1kw0aSLs32QPoqOOuncUDnEaGRNlB1x32JFhxgwZwB+KrwWdeBeDowh/yqRfuMP qc2Pzs7zqRC9/jIrD9irf6cq4D1+tNCEuj/EeOJl4gJI+bZmm1xI8QmD7OHBxzVwrNlaSyzbBSj rL8UzAmkBf7b5M/chn X-Received: by 2002:a05:6a00:2d98:b0:842:5634:3c1d with SMTP id d2e1a72fcca58-845507f8ca6mr15619847b3a.19.1782150998393; Mon, 22 Jun 2026 10:56:38 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:b36f:3823:3d45:dff4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ebcf45sm7685766b3a.48.2026.06.22.10.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 10:56:37 -0700 (PDT) Date: Mon, 22 Jun 2026 11:56:35 -0600 From: Mathieu Poirier To: "Rob Herring (Arm)" Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: Use presence checks for syscon props Message-ID: References: <20260612214959.1884404-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260612214959.1884404-1-robh@kernel.org> On Fri, Jun 12, 2026 at 04:49:58PM -0500, Rob Herring (Arm) wrote: > The OMAP and Keystone remoteproc drivers only need to know whether > "ti,bootreg" and "ti,syscon-dev" are present before parsing them. > Reading those properties as booleans misrepresents their DT encoding. > > Use of_property_present() for the presence tests and keep the existing > phandle parsing for the actual property values. > > Assisted-by: Codex:gpt-5-5 > Signed-off-by: Rob Herring (Arm) > --- > drivers/remoteproc/keystone_remoteproc.c | 2 +- > drivers/remoteproc/omap_remoteproc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c > index e7fde5509786..83763d640c4e 100644 > --- a/drivers/remoteproc/keystone_remoteproc.c > +++ b/drivers/remoteproc/keystone_remoteproc.c > @@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev, > struct device_node *np = pdev->dev.of_node; > struct device *dev = &pdev->dev; > > - if (!of_property_read_bool(np, "ti,syscon-dev")) { > + if (!of_property_present(np, "ti,syscon-dev")) { > dev_err(dev, "ti,syscon-dev property is absent\n"); > return -EINVAL; > } > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > index cb01354248af..6ed0f28edac9 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev, > if (!data) > return -ENODEV; > > - if (!of_property_read_bool(np, "ti,bootreg")) > + if (!of_property_present(np, "ti,bootreg")) > return 0; > I'll apply this when rc1 comes out next week. Thanks, Mathieu > oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data), > -- > 2.53.0 >