From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A1593BB122 for ; Mon, 22 Jun 2026 14:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782139118; cv=none; b=iI7bPBXVj83JWu0MTNULl1wB1UYm2etrZ8AJxJnU+CbDUjG6KOrlBfw6tvK3YtJciter//cJbmxohHfm0AYn7hBN84/R30zm3HzZADj3nLR1c7SQGd9j8TSjh5pCemG4VJzBWZ9pZ2fEN/qpTyMVfUVyf8nA7sXU7KsEHTLrwxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782139118; c=relaxed/simple; bh=ny2LxMQcVwqYpwb6jd2D1S5kV3aBfer3sX0bqWrSA+4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IO/U/btkkidPtPkMFEgEpnKO1c26K0EQFQxhpjDJ3Jh69WUOffY5zNNxAnHQTs5Ht2Gj66Bn9pUqG3cgv22ttQi2x1KJ5BlAC/e/HyyhwQsNGCqqqjhsG7xq+BPyV/r3HiSEdlAkjBe+SRg4c2tlVhZD+eow2pOfoktthCt/eek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nWZdqr85; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nWZdqr85" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDD121F000E9; Mon, 22 Jun 2026 14:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782139117; bh=ny2LxMQcVwqYpwb6jd2D1S5kV3aBfer3sX0bqWrSA+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=nWZdqr850HISQ1pRUoZjDbojw/Gs297GgPBmg893bp/gOE/ZryyXFFdNLwn0A9nK1 EpawPGm9yoUkOSk4LIaIDY4JnuRthvJ7E9BL5tDp0souDMF+u7PdPyybuR37L3nzeh qibKyOsogEH5loHSKjoIxEdwWA2OaRDGc2JlL/GDydvmqEJxTpjR1T/z3FMA2/bez/ nmlBx0XK9XYuI754ds7Llz+Ac73XvRninDskbGWDhACv+addnv+cSbN3FBQL4ovUCa JQG2/yKQWykaBCnaqhtRl+zZkRO//emExZjTiCFQmYGlRs/m5UCOqCJ2LCfQJj6tHQ 8y4oJOxgS0zbA== Date: Mon, 22 Jun 2026 08:38:35 -0600 From: Keith Busch To: Ben Dooks Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: make unexported sysfs structures static Message-ID: References: <20260622142357.494750-1-ben.dooks@codethink.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622142357.494750-1-ben.dooks@codethink.co.uk> On Mon, Jun 22, 2026 at 03:23:57PM +0100, Ben Dooks wrote: > These sysfs attributes are not exported out of sysfs.c so make > them static to remove the following sparse warnings: Thanks, though I already have this fix queued up for the next pull request that will be sent out this week: https://git.infradead.org/?p=nvme.git;a=commitdiff;h=ac48c49116d3de84fabc224c6e43f08740b1460d