From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: vkoul@kernel.org, arnd@arndb.de, lgirdwood@gmail.com,
pierre-louis.bossart@linux.dev, yung-chuan.liao@linux.intel.com,
peter.ujfalusi@linux.intel.com, oder_chiou@realtek.com,
jack.yu@realtek.com, shumingf@realtek.com, niranjan.hy@ti.com,
shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
sen@ti.com, zhangyi@everest-semi.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 1/5] soundwire: Move wait for initialisation helper to header
Date: Mon, 22 Jun 2026 16:14:51 +0100 [thread overview]
Message-ID: <ajlRa0VST7GQ77tV@opensource.cirrus.com> (raw)
In-Reply-To: <3d39f181-0d40-47db-8432-2f22dd3aeefc@sirena.org.uk>
On Mon, Jun 22, 2026 at 04:08:54PM +0100, Mark Brown wrote:
> On Sat, Jun 20, 2026 at 12:02:33PM +0100, Charles Keepax wrote:
>
> > As SoundWire devices tend to enumerate on the bus after probe, drivers
> > frequently need to wait for the device to initialise from common driver
> > code. The common system is to split drivers into a core module and then
>
> > +static inline int sdw_slave_wait_for_init(struct sdw_slave *slave, int timeout_ms)
> > +{
> > + unsigned long time;
> > +
> > + if (!slave)
> > + return 0;
> > +
> > + time = wait_for_completion_timeout(&slave->initialization_complete,
> > + msecs_to_jiffies(timeout_ms));
>
> You need to add an include of linux/jiffies.h for msecs_to_jiffies()
> otherwise we might get build breaks.
Good shout thanks I will do a respin.
Thanks,
Charles
next prev parent reply other threads:[~2026-06-22 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 11:02 [PATCH 0/5] Fix SoundWire randconfig issues Charles Keepax
2026-06-20 11:02 ` [PATCH 1/5] soundwire: Move wait for initialisation helper to header Charles Keepax
2026-06-22 4:45 ` Vinod Koul
2026-06-22 15:08 ` Mark Brown
2026-06-22 15:14 ` Charles Keepax [this message]
2026-06-20 11:02 ` [PATCH 2/5] ASoC: es9356: Add back local call to sdw_show_ping_status() Charles Keepax
2026-06-20 11:02 ` [PATCH 3/5] ASoC: max98373: " Charles Keepax
2026-06-20 11:02 ` [PATCH 4/5] ASoC: ti: " Charles Keepax
2026-06-20 11:02 ` [PATCH 5/5] ASoC: realtek: " Charles Keepax
2026-06-20 15:47 ` [PATCH 0/5] Fix SoundWire randconfig issues Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajlRa0VST7GQ77tV@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=arnd@arndb.de \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=jack.yu@realtek.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=shumingf@realtek.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.